Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Sander Vanheule <sander@svanheule.net>
To: Yury Norov <yury.norov@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Brendan Higgins <brendan.higgins@linux.dev>,
	David Gow <davidgow@google.com>,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Cc: "Maíra Canal" <mairacanal@riseup.net>,
	linux-kernel@vger.kernel.org,
	"Sander Vanheule" <sander@svanheule.net>
Subject: [PATCH v2 1/5] lib/test_cpumask: drop cpu_possible_mask full test
Date: Sat, 20 Aug 2022 17:03:09 +0200	[thread overview]
Message-ID: <6dfd4d3a4d77f97f13ab3f22bc53c96c38ba908e.1661007339.git.sander@svanheule.net> (raw)
In-Reply-To: <cover.1661007338.git.sander@svanheule.net>

When the number of CPUs that can possibly be brought online is known at
boot time, e.g. when HOTPLUG is disabled, nr_cpu_ids may be smaller than
NR_CPUS. In that case, cpu_possible_mask would not be completely filled,
and cpumask_full(cpu_possible_mask) can return false for valid system
configurations.

Fixes: c41e8866c28c ("lib/test: introduce cpumask KUnit test suite")
Link: https://lore.kernel.org/lkml/346cb279-8e75-24b0-7d12-9803f2b41c73@riseup.net/
Reported-by: Maíra Canal <mairacanal@riseup.net>
Signed-off-by: Sander Vanheule <sander@svanheule.net>
Tested-by: Maíra Canal <mairacanal@riseup.net>
Reviewed-by: David Gow <davidgow@google.com>
---
Changes in v2:
Rewrite commit message to explain why this test is wrong

 lib/test_cpumask.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/test_cpumask.c b/lib/test_cpumask.c
index a31a1622f1f6..4ebf9f5805f3 100644
--- a/lib/test_cpumask.c
+++ b/lib/test_cpumask.c
@@ -54,7 +54,6 @@ static cpumask_t mask_all;
 static void test_cpumask_weight(struct kunit *test)
 {
 	KUNIT_EXPECT_TRUE(test, cpumask_empty(&mask_empty));
-	KUNIT_EXPECT_TRUE(test, cpumask_full(cpu_possible_mask));
 	KUNIT_EXPECT_TRUE(test, cpumask_full(&mask_all));
 
 	KUNIT_EXPECT_EQ(test, 0, cpumask_weight(&mask_empty));
-- 
2.37.2


  reply	other threads:[~2022-08-20 15:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-20 15:03 [PATCH v2 0/5] cpumask: KUnit test suite fixes and improvements Sander Vanheule
2022-08-20 15:03 ` Sander Vanheule [this message]
2022-08-20 21:35   ` [PATCH v2 1/5] lib/test_cpumask: drop cpu_possible_mask full test Yury Norov
2022-08-21 13:08     ` Sander Vanheule
     [not found]       ` <CAAH8bW9yZUMn2shYAB1LaDyzgFMYtWCRUXxq=bMCiFys=gzKig@mail.gmail.com>
2022-08-21 13:27         ` Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 2/5] lib/test_cpumask: fix cpu_possible_mask last test Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 3/5] lib/test_cpumask: follow KUnit style guidelines Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 4/5] lib/cpumask_kunit: log mask contents Sander Vanheule
2022-08-20 21:46   ` Yury Norov
2022-08-21 13:13     ` Sander Vanheule
2022-08-21 14:02       ` Maíra Canal
2022-08-21 16:39         ` Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 5/5] lib/cpumask_kunit: add tests file to MAINTAINERS Sander Vanheule
2022-08-20 22:06 ` [PATCH v2 0/5] cpumask: KUnit test suite fixes and improvements Yury Norov
2022-08-21 13:25   ` Sander Vanheule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6dfd4d3a4d77f97f13ab3f22bc53c96c38ba908e.1661007339.git.sander@svanheule.net \
    --to=sander@svanheule.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brendan.higgins@linux.dev \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mairacanal@riseup.net \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox