From: Shuah Khan <skhan@linuxfoundation.org>
To: Alessandro Zanni <alessandro.zanni87@gmail.com>,
shuah@kernel.org, gregkh@linuxfoundation.org,
nfraprado@collabora.com
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] kselftest/devices/probe: Fix SyntaxWarning in regex strings for Python3
Date: Wed, 2 Oct 2024 14:33:33 -0600 [thread overview]
Message-ID: <6e023b6a-af3d-4cfc-a956-1e47852adde5@linuxfoundation.org> (raw)
In-Reply-To: <6tlfxlgukpftlfh7z4mwbklcjl74rxixo7xjauyf5dstyhwav2@wvkwd3df5am6>
On 10/2/24 03:00, Alessandro Zanni wrote:
> Hello,
>
> this email is just a friendly reminder to know if the present patch is going to be applied or not.
>
> Thank you.
> Best Regards,
> Alessandro Zanni
>
No top posting please.
> On 24/08/06 02:14, Alessandro Zanni wrote:
>> Insert raw strings to prevent Python3 from interpreting string literals
>> as Unicode strings and "\d" as invalid escaped sequence.
>>
>> Fix the warnings:
>>
>> tools/testing/selftests/devices/probe/test_discoverable_devices.py:48:
>> SyntaxWarning: invalid escape sequence '\d' usb_controller_sysfs_dir =
>> "usb[\d]+"
>>
>> tools/testing/selftests/devices/probe/test_discoverable_devices.py: 94:
>> SyntaxWarning: invalid escape sequence '\d' re_usb_version =
>> re.compile("PRODUCT=.*/(\d)/.*")
>>
>> Fixes: dacf1d7a78bf ("kselftest: Add test to verify probe of devices from
>> discoverable buses")
>>
checkpatch complained about
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 160c826b4dd0 ("selftest: hid: add missing run-hid-tools-tests.sh")'
#110:
Fixes: dacf1d7a78bf ("kselftest: Add test to verify probe of devices from
>> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
Run checkpatch before sending the patch. I fixed the problem
and applied to linux-kselftest fixes branch for next rc.
Sorry for the delay.
thanks,
-- Shuah
prev parent reply other threads:[~2024-10-02 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 12:14 [PATCH v3] kselftest/devices/probe: Fix SyntaxWarning in regex strings for Python3 Alessandro Zanni
2024-10-02 9:00 ` Alessandro Zanni
2024-10-02 20:33 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e023b6a-af3d-4cfc-a956-1e47852adde5@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=alessandro.zanni87@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox