Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: John Stultz <jstultz@google.com>, Khem Raj <raj.khem@gmail.com>
Cc: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: timers: Fix clock_adjtime for newer 32-bit arches
Date: Thu, 19 Sep 2024 11:54:50 -0600	[thread overview]
Message-ID: <713d7e8d-e6d1-4438-a47b-6bb95a4e1c61@linuxfoundation.org> (raw)
In-Reply-To: <CANDhNCoY=tvhWFmY_dZGqPdCiTZSDX3cet7qQ00zvSUBFHXLNQ@mail.gmail.com>

On 9/18/24 02:58, John Stultz wrote:
> On Wed, Sep 18, 2024 at 2:47 AM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> Newer 32-bit architectures e.g. riscv32 are using 64-bit time_t
>> from get go, they have not wired __NR_clock_adjtime at all
>> valid-adjtimex testcase fails to compile on such architectures.
>> if this condition is found then use 64-bit adjtime syscall
>>
> 
> No major objections here. Though I'm feeling a little forgetful as to
> why the test is calling the syscall directly instead of going through
> libc.
> I suspect it's likely due to the test being written prior to the libc
> implementation being common?
> 
> So I wonder if a better fix would be just to drop the local
> clock_adjtime implementation here, as I'm sure the libc has similar
> logic to what's being added here?
> 

The proposed solution works better than adding local clock_adjtime implementation
here.

thanks,
-- Shuah


  reply	other threads:[~2024-09-19 17:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18  0:47 [PATCH] selftests: timers: Fix clock_adjtime for newer 32-bit arches Khem Raj
2024-09-18  8:58 ` John Stultz
2024-09-19 17:54   ` Shuah Khan [this message]
2024-09-19 18:05     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=713d7e8d-e6d1-4438-a47b-6bb95a4e1c61@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=jstultz@google.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=raj.khem@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox