Re: [PATCH 1/9] tools/nolibc: move ioctl() to sys/ioctl.h

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Wed, May 21, 2025 at 03:08:05PM +0200, Thomas Weißschuh wrote:
> On 2025-05-21 14:03:37+0100, Mark Brown wrote:

> > > +/* make sure to include all global symbols */
> > > +#include "nolibc.h"

> > assumes that the nolibc include directory is in the include path, or
> > otherwise set up with a -I path, previously you just had to include
> > nolibc.h with the includes that are there working due to being relative
> > to nolibc.h.  I'll send a patch for the arm64 tests.

> Thanks for the report.
> Inside sys/ this should actually be #include "../nolibc.h".
> I'll doublecheck all of sys/ and see why our new header checks didn't
> catch this.

Ah, you expect what's currently there to work - good.  I noticed that
the vDSO tests had a -I for the nolibc directory which made me think it
was expected that it be there, it's the only user on most arches.

> > It looks like the RISC-V selftests are also impacted, I didn't spot any
> > other users that didn't already have an -I.

> No changes to the selftests should be necessary.

OK, that's easier for me!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]