From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 002DA18A6AB for ; Tue, 30 Jul 2024 18:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722363436; cv=none; b=mTT4bLU86ehkKtxF9ol5BXAt/iQFYOqISl7nATEqsUer3JCQwX1rd95C+KTcuAiGwjZtdZ/c1VX7xjKqTvo0T7LaQUmQpbNFEUYrnrmPTXeAKa8hlphIdqps0j6E4CIWmH0rbVpF4odnEH5lHZ83XDlpfn2RxNSQGM9+PN/O5k8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722363436; c=relaxed/simple; bh=0xYCKqriDm8/FaCQfy0mhXqPqVA08LHGxQL0mq5CEyc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ehjx2LXjqdnhEqcajfvRN5AwoypfGUEqJ8iAD/c8oxS2i1yYmzcRrZf8FYaDrzu8yB5mnunXhACIZEu/qSRE3MwrmRah5JDsdvPJG8r4txj/iijAiYegs65iEKYWDdDnxgcioKnaHamgHAFlYMOfvm8LJUDR7mCPpu9CVB+7Bmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=er2n6MOI; arc=none smtp.client-ip=209.85.166.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="er2n6MOI" Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-81f932ede28so25575339f.2 for ; Tue, 30 Jul 2024 11:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722363434; x=1722968234; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9kFXdMSSISnEMJ3bkmlAGx8cLeClwIVmn0jpSwJXKIE=; b=er2n6MOIwe2dPxl2B25MN9F3wrwRMu5l8wM1DCEBLtIuiAYaOnaZpsMi31PZ41Au9Q idr9qmODhV3yy/CJgKF7C2OYmqqFVsBslVKeyo2WUhPXyJLRx82bhVmjg/mn5MFE7P7G wQtWunmLeIj2vhqJXpGuPQCt6dN9Bsd8ksZjk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722363434; x=1722968234; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9kFXdMSSISnEMJ3bkmlAGx8cLeClwIVmn0jpSwJXKIE=; b=SijW0XhYDWWIJ/r/84/EMpArQGVV4mV0MwGJTf0pPKvgFD4tUG/thbnoHIhzkkP4IW iyn8XorA1NPTNykpY5RehXQRtgAk4ewRhl1HmU90+d7+jmjlhrgUNWW3x2R5wYOdHbel 5MAax7mYvW5MXg8R/V/C4I/OuOZPW5Hfy8Cp4NTsOblwyrC+hp+RZ1OHG3HwFKPgNusL xZwn+kljbZQYtMU1hljLpKihbHu7d4EQ5OWUR6c+8NnIHBpQ6BEwNtHrgFlrYBlyxp4q qnyLyrRgr7T61fpgPdXgyT13LaSLAp2d6jzSzaQy+BrwPO1Ls16mI3l9xZ0Gw3OwUZOO YTAQ== X-Forwarded-Encrypted: i=1; AJvYcCXn2L9ISY/1V4J6ex92jcy1FCHgMpLZJBq5ahnjhPS7wDy+bGOFoYEEgDWkNe1BCm8zuMoPvzSSNdq3P02vEI0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzw6vuEgrV6Os59qS7QniaBbdLS1nnsmEi5Q2sZDZsarOzyXGF8 Naf6ND87lMstuIwujNHETYGhY8rmh5dNv23N0xe31+RGeMFS/HkYdtkTmgyN6Vc= X-Google-Smtp-Source: AGHT+IFp5v9TO6qmYv9utxWv+Qtek8u5aXB/S1/Mv5jSUhqJcCZ1BFhOww3oNAPi4ucZAyBm/Z5w4g== X-Received: by 2002:a5d:9496:0:b0:80a:4582:cef1 with SMTP id ca18e2360f4ac-81f7d00ccbcmr1104272839f.3.1722363434096; Tue, 30 Jul 2024 11:17:14 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4c8b35847e5sm217894173.114.2024.07.30.11.17.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 11:17:13 -0700 (PDT) Message-ID: <75a2960e-d489-4440-a8e1-487a7f84902e@linuxfoundation.org> Date: Tue, 30 Jul 2024 12:17:12 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] bitmap: Rename module To: David Gow , Randy Dunlap , kees@kernel.org, Muhammad Usama Anjum Cc: Yury Norov , Andrew Morton , Rasmus Villemoes , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, John Hubbard , kernel@collabora.com, Shuah Khan References: <20240726110658.2281070-1-usama.anjum@collabora.com> <20240726110658.2281070-3-usama.anjum@collabora.com> <85f575b4-4842-4189-9bba-9ee1085a5e80@collabora.com> <714e7642-6f92-4e41-aa36-c854668e0bb0@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <714e7642-6f92-4e41-aa36-c854668e0bb0@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/30/24 09:55, Shuah Khan wrote: > On 7/30/24 04:10, David Gow wrote: >> On Mon, 29 Jul 2024 at 22:09, Randy Dunlap wrote: >>> >>> >>> >>> On 7/29/24 1:07 AM, Muhammad Usama Anjum wrote: >>>> On 7/27/24 10:35 PM, Yury Norov wrote: >>>>> On Fri, Jul 26, 2024 at 04:06:57PM +0500, Muhammad Usama Anjum wrote: >>>>>> Rename module to bitmap_kunit and rename the configuration option >>>>>> compliant with kunit framework. >>>>> >>>>> ... , so those enabling bitmaps testing in their configs by setting >>>>> "CONFIG_TEST_BITMAP=y" will suddenly get it broken, and will likely >>>>> not realize it until something nasty will happen. >>>> CONFIG_TEST_BITMAP was being enabled by the kselftest suite lib. The bitmap >>>> test and its config option would disappear. The same test can be run by >>>> just enabling KUNIT default config option: >>>> >>>> KUNIT_ALL_TESTS=y enables this bitmap config by default. >>>> >>>>> >>>>> Sorry, NAK for config rename. >>>>> >>> >>> I agree with Yury. Using KUNIT takes away test coverage for people who >>> are willing to run selftests but not use KUNIT. > > This is incorrect. There are selftest that are used to > > - regression test a subsystem or a abi during boot > - spot check on a running system to debug and test by loading >   a test module. > >> >> I can see the point that renaming the config option is just churn, but >> is there a reason people would run the bitmap selftest but be unable >> or unwilling to use KUnit? >> >> Beyond a brief period of adjustment (which could probably be made >> quite minimal with a wrapper script or something), there shouldn't >> really be any fundamental difference: KUnit tests can already run at >> boot, be configured with a config option, and write output to the >> kernel log. There's nothing really being taken away here, and the >> bonus of having easier access to run the tests with KUnit's tooling >> (or have them automatically run by systems which run KUnit tests) >> would seem worthwhile to me, especially since it's optional. And >> CONFIG_KUNIT shouldn't be heavy enough to cause problems. >> Shouldn't be is the operative word? This doesn't help people who want run a run bitmap test on a running system. This is a wrong direction to go to say all testing has to be done under kunit. What happened to the effort to run selftests as is under KUnit? What is the motivation to convert all tests to kunit instead of trying to provide support to run kselftest under kunit environment? We discussed this a few years ago as I recall. Let's work on that instead of removing existing selftests and regressing current use-cases? Can we look into providing: 1. running kselftest under kunit environment without changes as user space applications? 2. Leave kselftests alone so we don't weaken kernel testing thanks, -- Shuah