From: shuah <shuah@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alan Maguire <alan.maguire@oracle.com>,
rostedt@goodmis.org, mingo@redhat.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Po-Hsu Lin <po-hsu.lin@canonical.com>, shuah <shuah@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 2/2] ftrace/selftest: make unresolved cases cause failure if --fail-unresolved set
Date: Fri, 1 May 2020 08:25:50 -0600 [thread overview]
Message-ID: <75fc65c3-a639-41cf-0a10-554e632e9612@kernel.org> (raw)
In-Reply-To: <20200501184208.2529cac8081a34de0b48617f@kernel.org>
On 5/1/20 3:42 AM, Masami Hiramatsu wrote:
> On Wed, 19 Feb 2020 20:39:41 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
>> On Wed, 19 Feb 2020 09:33:30 +0000
>> Alan Maguire <alan.maguire@oracle.com> wrote:
>>
>>> Currently, ftracetest will return 1 (failure) if any unresolved cases
>>> are encountered. The unresolved status results from modules and
>>> programs not being available, and as such does not indicate any
>>> issues with ftrace itself. As such, change the behaviour of
>>> ftracetest in line with unsupported cases; if unsupported cases
>>> happen, ftracetest still returns 0 unless --fail-unsupported. Here
>>> --fail-unresolved is added and the default is to return 0 if
>>> unresolved results occur.
>>>
>>
>> OK, this looks good to me. One note, with this change, ftracetest doesn't
>> fail even if your test environment is not well prepared anymore.
>>
>> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Hi Shuah,
> Could you pick this up?
>
> Po-Hsu Lin seemed to face same problem recently. If this applied, it will be solved.
>
Sorry about this. I will get these in
thanks,
-- Shuah
next prev parent reply other threads:[~2020-05-01 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 9:33 [PATCH v2 0/2] ftrace/selftest: clean up failure cases Alan Maguire
2020-02-19 9:33 ` [PATCH v2 1/2] ftrace/selftests: workaround cgroup RT scheduling issues Alan Maguire
2020-02-19 9:33 ` [PATCH v2 2/2] ftrace/selftest: make unresolved cases cause failure if --fail-unresolved set Alan Maguire
2020-02-19 11:39 ` Masami Hiramatsu
2020-05-01 9:42 ` Masami Hiramatsu
2020-05-01 14:25 ` shuah [this message]
2020-05-02 4:42 ` Masami Hiramatsu
2020-02-19 19:26 ` [PATCH v2 0/2] ftrace/selftest: clean up failure cases Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75fc65c3-a639-41cf-0a10-554e632e9612@kernel.org \
--to=shuah@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=po-hsu.lin@canonical.com \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox