From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9559015099B for ; Mon, 12 Aug 2024 09:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723455333; cv=none; b=BQsWNsxzkwf7LWFLBql7Qyd7j5Fr3kFtMuBo1/1UaGnkHxvXL41/xkYohxj6bX3Xe10BSE3jFsTvmlhFQmdFGx73vKSvF1sYp7lOFe+uAZu+4VOM3ib70AHs09+brL5u0dqXkbSTkXZAMu69BVXePyBDsKQCuzTRNUSNPQAZeZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723455333; c=relaxed/simple; bh=PNupUm463iQE7T43+Zrxo6foOwsAjT1hssbqJKvS1nw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FtcqlX4IXJQtVFgxeaOVDukd4bfeRNyyjWTHdwzv2uPV+ANS1+rlRg4/Bd0HeHpqkjt3dc87dTHagoRG2Dbd4HfCNaUtg2dz9HbcEWHjr/0W0WeD2Qga0RDczoet2k2PD7gWbHPtLzKbX+LiYoS3tikPmJrJiUabzW6nwyRZoLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Qyl1BQTA; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Qyl1BQTA" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-2644f7d0fb2so497090fac.0 for ; Mon, 12 Aug 2024 02:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1723455329; x=1724060129; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LezxPZ2pblaIeFvj/f40IQFP8Cd13qWLMfSEX26uTrg=; b=Qyl1BQTAHySkQ/pKl3Ih7zqE/4ejNF7mQNvms43yYPNRhHzvqETqUiTEl2rpK17vkq Gcct5H9Njkg9NwOShXwwi6kr0+ygms1u9a+em798UjXcewizt5PnhR7zC4duRE5QTIWc 9Go6W5HgCmH7pZeb4OnHIJLK5NY3IoSc77FE8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723455329; x=1724060129; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LezxPZ2pblaIeFvj/f40IQFP8Cd13qWLMfSEX26uTrg=; b=i2AY/dcji9PvsAxzLH5MtwD4Y9QtqXZgWatw2Ig+wAEdX0x9lgVzOmNZgbGm0G0qi4 ldTZXwwsUlzXUtJlfud8JL9nichVPGtdSBUbaA3FNxPRyBWUuS5D+Q2jBpXgZKx46t69 kiqGEuaUmCJWFuegARDXiiVCZ9LvHrPeiHjVVKKkfjmoymMqIvnZkL5+Od2/66HzFx2d SyrGYXyMortXyFHNTwEJ3JnPehY41DpTO1j/wVQqrr/FzahXvxhJBMppAjfOQCS8qp37 JUmWrlTpT+3OGPEfI/ufHW6FAksiSuheUa4/GlkS91O7Z1KtlpYrazsYk15wNfd5cGJy oy/Q== X-Forwarded-Encrypted: i=1; AJvYcCV/+yvDuFq72TIr0ekPBD4PzkG+dev3iSzk9yEm/XghUgsCWEnvbto3y8bLbwjFTxWb2QN+I+4IL3sp2Ai37CI=@vger.kernel.org X-Gm-Message-State: AOJu0YwJLFtTRF3FpRs+tWpqOzrhQbNzxjw6l4LtEXaJudqXxXKHozhV WMAj3WE8FEDCXYX1fJacBRiQ6mrR5z1zW+9oxukKfn86OGQDbo+XE7E2qi6PCXw= X-Google-Smtp-Source: AGHT+IEvaBJ1EAoM7XMitug7a/NQNwZ2GMcuPj+9Pyp+pxqnYpN4Y2JKVJZhBJ6VgvqO4qrwmTDuKQ== X-Received: by 2002:a05:6871:3390:b0:261:b94:b0b with SMTP id 586e51a60fabf-26c62c1a506mr5354178fac.1.1723455329347; Mon, 12 Aug 2024 02:35:29 -0700 (PDT) Received: from [192.168.104.75] ([223.118.51.122]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710e58a8f22sm3595976b3a.46.2024.08.12.02.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 02:35:28 -0700 (PDT) Message-ID: <7612504c-cd56-4fcd-a287-d3fbc89162ea@linuxfoundation.org> Date: Mon, 12 Aug 2024 03:35:23 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kselftest/cgroup: Add missing newline in test_zswap.c To: Mohammed Anees , hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, shuah@kernel.org Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240811145900.433711-1-pvmohammedanees2003@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240811145900.433711-1-pvmohammedanees2003@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/11/24 08:58, Mohammed Anees wrote: Missing change log > Signed-off-by: Mohammed Anees > --- > tools/testing/selftests/cgroup/test_zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c > index 190096017..7c849d836 100644 > --- a/tools/testing/selftests/cgroup/test_zswap.c > +++ b/tools/testing/selftests/cgroup/test_zswap.c > @@ -351,7 +351,7 @@ static int test_zswap_writeback(const char *root, bool wb) > goto out; > > if (wb != !!zswpwb_after) { > - ksft_print_msg("zswpwb_after is %ld while wb is %s", > + ksft_print_msg("zswpwb_after is %ld while wb is %s\n", > zswpwb_after, wb ? "enabled" : "disabled"); > goto out; > } The change looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah