From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADF6E279351 for ; Tue, 19 Aug 2025 14:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755615053; cv=none; b=IGI8HXcT+6otGy6Y1lS751STIjmhpjcbB0vjk53S/LjxbtnnCdNBvzR53kMGQ91x0ZZmKBbHaOstbLzBUi2REYv3SX+kq1nvdvI7uZxa2E41jcSRf+la6d7S68qJIWG3LTqDO2yuR50twS6WLeyeBOIKDHqn6ytc56INfMgnvv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755615053; c=relaxed/simple; bh=3hgpWvB6M/Qlt7LeRCt5AZv2UMEpK7Tc8UH4bMsTtD0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cssFh8ihTgj0iatUwlyW1eBvV9WLxGhcRjR/wiwmWuZmiTassT30ShDla5CPiyQhbXIiFzML7sQHwx/wy/GPSkgFbCGo/lih9eRD6kjW5E+0LQdI8C7GgDESaEQNlVZ78Jjb2oKHF0n/lK4O25kzdllZioFcBRfZ00dYw5ygYrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SpOxiB8X; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SpOxiB8X" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-88432e29adcso134150539f.2 for ; Tue, 19 Aug 2025 07:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1755615051; x=1756219851; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nkL6Lf4qeGh6IQDwzhT4JmkS6k1uC7gHiNcx7NhA+2E=; b=SpOxiB8XlJ75PVHxL0PmecFYjNaCERKUMBF6zTTqhn0UetJQYR9/iMCN9rId0nB52/ r31EhTSuydqd7mLN7G7QfxqYD6FD7dQ0RIvE9LTBjJQq+5BvN4ME9RAs3scpBLdntsua TalPlSfhs/mYxIFYJoXk3h+NW+HgSbzD49PKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755615051; x=1756219851; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nkL6Lf4qeGh6IQDwzhT4JmkS6k1uC7gHiNcx7NhA+2E=; b=TRRB47dqr1Z/9T4dBsghQw+uZvWIpwdCs/dV/r9lvTgY2juki4BDmZ0+vLQGJ/tO9a mDfPeAH9IYew4I15onDS/vGzbSjG9NDO7DuHjJsCCZmIONXM08DyLuRZGWjl1LsP2H0H ecnYuytn1pa6s2km8rZnyz4qSx98Xr/FcHuObPaTkJqkrRz8YJAmG45PprijhUzoBSkg CF15Pw0FdLey0cG0jX8jTnOe1wMLxNYDH3BowsHh8BechBlNJjP1KYPNpJjr4oeyxRes GHOQ7BrEl7mxSzzfntpU/Y7zdxxZZC6s+yQmZo0aIzctkbWiz+v1/JZ4kmmD3NYmsqlW 0SdA== X-Forwarded-Encrypted: i=1; AJvYcCU7KLZdT67kw0ZbkmKPqZ006lb0jGKz7KXdNZ4rasgXzvoxC+wc9yrzyxCm0Ke33NDHsiIF2QqA/Il8liiZyW8=@vger.kernel.org X-Gm-Message-State: AOJu0YyAKtkicBuQD5hg1Z5NphiudXupikB7SNJ9UOvYJ9U2fKeVvp4N rQlyvnwv2OP2njLilLQGvTwqO5Vf+NGjNZ9USNVKHG2LypsiCdtRHtX9DbZs+dwDmiY= X-Gm-Gg: ASbGncthCFclAKegiwg2mILnQ9LgensNp2YNJJ6Lit2kduAEV9iFPMQY5ySQ3LdeB1Q q2jsGAkZJi/UhyyK0wZzI4WcAzADTE5QpVgJe8gBc5RHd8fK3kN5nBaj8Qmv60p1FQvDh4Cd3sd oYRojTIIS1k9zEl9XiAcJn70EzrqH2PYpxiNi90Rk1/QA+vCkkDOKDwOQUT+cp608ALBFTOJVo0 igItNdM/qHy6KOWCLoAQX3rpqW1xJNgGTI++gqWNVNUM14C8UFedkJiQXHkzvTbh5gFWgiFVWYu pa1T/1hvtfV2NVj6uUYcjpyvdlxmwk+JfjP4m1frTXj8ZIBvckhs+VRcTjMp7NNuq+LmqXRfdzx hdKAUxZ1btWiwwNTXQwKViYsMp71LdrDFLek= X-Google-Smtp-Source: AGHT+IETI7shiHyC6m4ISrsGLlHmRRKz937/t+lqa+3tqujW/NZcAWXuRerlQlDR/Icc+aM597Y4UQ== X-Received: by 2002:a05:6602:1601:b0:881:7c22:2d18 with SMTP id ca18e2360f4ac-88467ecf74fmr468337539f.8.1755615050613; Tue, 19 Aug 2025 07:50:50 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8843f9c3329sm404935039f.19.2025.08.19.07.50.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Aug 2025 07:50:50 -0700 (PDT) Message-ID: <771b7ff1-3497-4d80-8f43-a1aaf28a3999@linuxfoundation.org> Date: Tue, 19 Aug 2025 08:50:48 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/33] vfio: Introduce selftests for VFIO To: Alex Williamson , David Matlack Cc: Jason Gunthorpe , Aaron Lewis , Adhemerval Zanella , Adithya Jayachandran , Andrew Jones , Ard Biesheuvel , Arnaldo Carvalho de Melo , Bibo Mao , Claudio Imbrenda , Dan Williams , Dave Jiang , dmaengine@vger.kernel.org, Huacai Chen , James Houghton , Joel Granados , Josh Hilke , Kevin Tian , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, "Mike Rapoport (Microsoft)" , Paolo Bonzini , Pasha Tatashin , "Pratik R. Sampat" , Saeed Mahameed , Sean Christopherson , Shuah Khan , Vinicius Costa Gomes , Vipin Sharma , Wei Yang , "Yury Norov [NVIDIA]" , Shuah Khan References: <20250620232031.2705638-1-dmatlack@google.com> <20250728102737.5b51e9da.alex.williamson@redhat.com> <20250729222635.GU36037@nvidia.com> <20250818133721.32b660e3.alex.williamson@redhat.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20250818133721.32b660e3.alex.williamson@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/18/25 13:37, Alex Williamson wrote: > On Mon, 18 Aug 2025 11:59:39 -0700 > David Matlack wrote: > >> On Thu, Jul 31, 2025 at 1:55 PM David Matlack wrote: >>> >>> On Tue, Jul 29, 2025 at 3:26 PM Jason Gunthorpe wrote: >>>> >>>> On Mon, Jul 28, 2025 at 10:27:37AM -0600, Alex Williamson wrote: >>>>> On Fri, 25 Jul 2025 09:47:48 -0700 >>>>> David Matlack wrote: >>>>>> I also was curious about your thoughts on maintenance of VFIO >>>>>> selftests, since I don't think we discussed that in the RFC. I am >>>>>> happy to help maintain VFIO selftests in whatever way makes the most >>>>>> sense. For now I added tools/testing/selftests/vfio under the >>>>>> top-level VFIO section in MAINTAINERS (so you would be the maintainer) >>>>>> and then also added a separate section for VFIO selftests with myself >>>>>> as a Reviewer (see PATCH 01). Reviewer felt like a better choice than >>>>>> Maintainer for myself since I am new to VFIO upstream (I've primarily >>>>>> worked on KVM in the past). >>>>> >>>>> Hi David, >>>>> >>>>> There's a lot of potential here and I'd like to see it proceed. >>>> >>>> +1 too, I really lack time at the moment to do much with this but I'm >>>> half inclined to suggest Alex should say it should be merged in 6 >>>> weeks (to motivate any reviewing) and we can continue to work on it >>>> in-tree. >>>> >>>> As they are self tests I think there is alot more value in having the >>>> tests than having perfect tests. >>> >>> They have been quite useful already within Google. Internally we have >>> something almost identical to the RFC and have been using that for >>> testing our 6.6-based kernel continuously since March. Already they >>> have caught one (self-inflicted) regression where 1GiB HugeTLB pages >>> started getting mapped with 2MiB mappings in the IOMMU, and have been >>> very helpful with new development (e.g. Aaron's work, and Live Update >>> support). >>> >>> So I agree, it's probably net positive to merge early and then iterate >>> in-tree. Especially since these are only tests and not e.g. >>> load-bearing kernel code (although I still want to hold a high bar for >>> the selftests code). >>> >>> The only patches to hold off merging would be 31-33, since those >>> should probably go through the KVM tree? And of course we need Acks >>> for the drivers/dma/{ioat,idxd} changes, but the changes there are >>> pretty minor. >> >> Alex, how would you like to proceed? > > I think we need an ack from Shuah for the overall inclusion in > tools/testing/selftests/ Acked-by: Shuah Khan Glad to see these test in the kselftest suite. > > AFAICT the tools include files don't seem to have any central > authority, so maybe we just need to chase those ioat/idxd acks, along > with Shuah's and we can get this rolling and follow-up with the latter > KVM patches once the base is merged. Thanks, > thanks, -- Shuah