Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: dvhart@infradead.org, shuah@kernel.org, kernel@collabora.com,
	linux-kselftest@vger.kernel.org
Subject: Re: [RESEND PATCH] selftests/futex: fix build for clang
Date: Fri, 14 Oct 2022 13:50:15 -0300	[thread overview]
Message-ID: <77a5bf0b-fa72-8ef8-0d39-2056384760ee@igalia.com> (raw)
In-Reply-To: <20221010063702.1323118-1-ricardo.canuelo@collabora.com>

On 10/10/22 03:37, Ricardo Cañuelo wrote:
> Don't use the test-specific header files as source files to force a
> target dependency, as clang will complain if more than one source file
> is used for a compile command with a single '-o' flag.
> 
> Use the proper Makefile variables instead as defined in
> tools/testing/selftests/lib.mk.
> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
> ---

Reviewed-by: André Almeida <andrealmeid@igalia.com>

Thanks for the patch!

      parent reply	other threads:[~2022-10-14 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  6:37 [RESEND PATCH] selftests/futex: fix build for clang Ricardo Cañuelo
2022-10-10 17:05 ` Shuah Khan
2022-10-14 16:50 ` André Almeida [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77a5bf0b-fa72-8ef8-0d39-2056384760ee@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=dvhart@infradead.org \
    --cc=kernel@collabora.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=ricardo.canuelo@collabora.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox