Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Will Deacon <will@kernel.org>, Dev Jain <dev.jain@arm.com>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	shuah@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Anshuman.Khandual@arm.com, suzuki.poulose@arm.com,
	ryan.roberts@arm.com, rob.herring@arm.com,
	Catalin.Marinas@arm.com, broonie@kernel.org,
	mark.rutland@arm.com, linux@armlinux.org.uk
Subject: Re: [PATCH v2 0/4] A new selftests/ directory for arm compatibility testing
Date: Tue, 23 Apr 2024 13:55:07 +0500	[thread overview]
Message-ID: <78f5ee9a-084f-4a8a-9a22-be031f9baafa@collabora.com> (raw)
In-Reply-To: <20240422172108.GD6223@willie-the-truck>

On 4/22/24 10:21 PM, Will Deacon wrote:
> On Mon, Apr 22, 2024 at 12:37:13PM +0530, Dev Jain wrote:
>> This series introduces the selftests/arm directory, which tests 32 and 64-bit
>> kernel compatibility with 32-bit ELFs running on the Aarch platform.
>> The need for this bucket of tests is that 32 bit applications built on legacy
>> ARM architecture must not break on the new Aarch64 platforms and the 64-bit
>> kernel. The kernel must emulate the data structures, system calls and the
>> registers according to Aarch32, when running a 32-bit process; this directory
>> fills that testing requirement.
>>
>> One may find similarity between this directory and selftests/arm64; it is
>> advisable to refer to that since a lot has been copied from there itself.
> 
> Isn't this going to be difficult to maintain if we have two divergent copies
> of the same stuff? From a very quick skim, a bunch of the signals stuff is
> idential to what we have on arm64...
Agreed.

Why don't we follow what x86 suite has been doing? Compile tests for both
arm and arm64, and add conditionals in the tests based on architecture.

If someone has objection that the suite name is arm64, just rename it to
arm which would be a generic name.


> 
> Will
> 

-- 
BR,
Muhammad Usama Anjum

  reply	other threads:[~2024-04-23  8:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22  7:07 [PATCH v2 0/4] A new selftests/ directory for arm compatibility testing Dev Jain
2024-04-22  7:07 ` [PATCH v2 1/4] selftests/arm: Add mm test Dev Jain
2024-04-22  7:07 ` [PATCH v2 2/4] selftests/arm: Add signal tests Dev Jain
2024-04-22  7:07 ` [PATCH v2 3/4] selftests/arm: Add elf test Dev Jain
2024-04-22  7:07 ` [PATCH v2 4/4] selftests: Add build infrastructure along with README Dev Jain
2024-04-22 17:21 ` [PATCH v2 0/4] A new selftests/ directory for arm compatibility testing Will Deacon
2024-04-23  8:55   ` Muhammad Usama Anjum [this message]
2024-04-24  2:05     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78f5ee9a-084f-4a8a-9a22-be031f9baafa@collabora.com \
    --to=usama.anjum@collabora.com \
    --cc=Anshuman.Khandual@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=broonie@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@arm.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox