Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Rae Moar <rmoar@google.com>,
	shuah@kernel.org, davidgow@google.com, dlatypov@google.com,
	brendan.higgins@linux.dev
Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org, keescook@chromium.org,
	linux-hardening@vger.kernel.org, jstultz@google.com,
	tglx@linutronix.de, sboyd@kernel.org
Subject: Re: [RFC v2 6/9] kunit: memcpy: Mark tests as slow using test attributes
Date: Wed, 12 Jul 2023 18:28:00 -0700	[thread overview]
Message-ID: <7C099325-C959-4FC2-82B3-C36BB87D94FC@kernel.org> (raw)
In-Reply-To: <20230707210947.1208717-7-rmoar@google.com>

On July 7, 2023 2:09:44 PM PDT, Rae Moar <rmoar@google.com> wrote:
>Mark slow memcpy KUnit tests using test attributes.
>
>Tests marked as slow are as follows: memcpy_large_test, memmove_test,
>memmove_large_test, and memmove_overlap_test. These tests were the slowest
>of the memcpy tests and relatively slower to most other KUnit tests. Most
>of these tests are already skipped when CONFIG_MEMCPY_SLOW_KUNIT_TEST is
>not enabled.
>
>These tests can now be filtered using the KUnit test attribute filtering
>feature. Example: --filter "speed>slow". This will run only the tests that
>have speeds faster than slow. The slow attribute will also be outputted in
>KTAP.
>
>Note: This patch is intended to replace the use of
>CONFIG_MEMCPY_SLOW_KUNIT_TEST and to potentially deprecate this feature.
>This patch does not remove the config option but does add a note to the
>config definition commenting on this future shift.
>
>Signed-off-by: Rae Moar <rmoar@google.com>

I remain excited about this series. :)

Acked-by: Kees Cook <keescook@chromium.org>


-- 
Kees Cook

  reply	other threads:[~2023-07-13  1:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07 21:09 [RFC v2 0/9] kunit: Add test attributes API Rae Moar
2023-07-07 21:09 ` [RFC v2 1/9] kunit: Add test attributes API structure Rae Moar
2023-07-18  7:38   ` David Gow
2023-07-18 21:01     ` Rae Moar
2023-07-19  8:31       ` David Gow
2023-07-07 21:09 ` [RFC v2 2/9] kunit: Add speed attribute Rae Moar
2023-07-18  7:38   ` David Gow
2023-07-18 18:31     ` Rae Moar
2023-07-07 21:09 ` [RFC v2 3/9] kunit: Add module attribute Rae Moar
2023-07-18  7:39   ` David Gow
2023-07-07 21:09 ` [RFC v2 4/9] kunit: Add ability to filter attributes Rae Moar
2023-07-18  7:39   ` David Gow
2023-07-18 20:40     ` Rae Moar
2023-07-07 21:09 ` [RFC v2 5/9] kunit: tool: Add command line interface to filter and report attributes Rae Moar
2023-07-18  7:39   ` David Gow
2023-07-18 20:42     ` Rae Moar
2023-07-07 21:09 ` [RFC v2 6/9] kunit: memcpy: Mark tests as slow using test attributes Rae Moar
2023-07-13  1:28   ` Kees Cook [this message]
2023-07-07 21:09 ` [RFC v2 7/9] kunit: time: Mark test " Rae Moar
2023-07-18  7:39   ` David Gow
2023-07-07 21:09 ` [RFC v2 8/9] kunit: add tests for filtering attributes Rae Moar
2023-07-10 18:07   ` Daniel Latypov
2023-07-12 21:24     ` Rae Moar
2023-07-07 21:09 ` [RFC v2 9/9] kunit: Add documentation of KUnit test attributes Rae Moar
2023-07-18  7:39   ` David Gow
2023-07-18 20:49     ` Rae Moar
2023-07-19  8:31       ` David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7C099325-C959-4FC2-82B3-C36BB87D94FC@kernel.org \
    --to=kees@kernel.org \
    --cc=brendan.higgins@linux.dev \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=jstultz@google.com \
    --cc=keescook@chromium.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rmoar@google.com \
    --cc=sboyd@kernel.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox