From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86614D26D for ; Fri, 7 Feb 2025 06:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738908264; cv=none; b=syIfqGAD3ENHWBBLZeChWRjN2MMIzKdiRvSliK3UWACDNwXnRliOAcStXkAu0EeDww+T8NroetiL89+AbZXg2RF/ZpRut8sM9MDP3e+xeUjUp1CaiI6+1698MU/A2y0bupm1ArgNCJDwsYRHozpfDVA/tgQTCfCpes+ob16JVmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738908264; c=relaxed/simple; bh=me3r634hb1lYNk273S3Z9pLt9FrNm6dScu+Ncv6skuY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uR3disw4FUpnBJCsfSH5yFbRhFPF6IeEUsHJ4TWwlh97Mz5TkTqG9fXTTdM8wNu3hLCrNn25SODDlnI7JWj22Adt+HbybwMUQjsAjKIdlx+XGbThHMt/CSr8MO6GgDdQVYvmPAiw+HV7nWW80L0XxZvViT5+Je/x6M2CeObVrNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=m/yl3USG; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="m/yl3USG" Message-ID: <7b348ab7-7378-40bc-98e7-98eb1377f9c2@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738908253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kj+5iZXbniePrmRu1hVwpnOzPx+raFyDx6ea5ukUze4=; b=m/yl3USGeWS7hKL0QAZvR66b4HW6bA2Bf9vzho7eUY/4En1Aq1is2r5m21vU0AwQ2MR4g9 jq5EjclPOzKjL+U77zf+A2suP+dNT7jYDJhgkcusrmWZjgBC74vHCnUt/aqvTeeofqXqFF TSPJRHfbfe0Y0TcRw1NVFZwBlFJGLPc= Date: Thu, 6 Feb 2025 22:04:06 -0800 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v1 1/2] bpf: changes_pkt_data: correct the 'main' error To: Jason Xing Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, mykolal@fb.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20250204023946.16031-1-kerneljasonxing@gmail.com> <20250204023946.16031-2-kerneljasonxing@gmail.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20250204023946.16031-2-kerneljasonxing@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 2/3/25 6:39 PM, Jason Xing wrote: > When compiling the selftests, the following error is printed out: > selftests/bpf/prog_tests/changes_pkt_data.c: In function ‘test_aux’: > selftests/bpf/prog_tests/changes_pkt_data.c:22:27: error: ‘main’ is usually a function [-Werror=main] > struct changes_pkt_data *main = NULL; The bpf CI has been testing this piece with different compilers. I also don't see it in my environment. How to reproduce it and which compiler? > Fix it by replacing with 'main_data'. > > Signed-off-by: Jason Xing > --- > .../selftests/bpf/prog_tests/changes_pkt_data.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/changes_pkt_data.c b/tools/testing/selftests/bpf/prog_tests/changes_pkt_data.c > index 7526de379081..b5c9031ec470 100644 > --- a/tools/testing/selftests/bpf/prog_tests/changes_pkt_data.c > +++ b/tools/testing/selftests/bpf/prog_tests/changes_pkt_data.c > @@ -19,7 +19,7 @@ static void test_aux(const char *main_prog_name, > struct bpf_program *freplace_prog = NULL; > struct bpf_program *main_prog = NULL; > LIBBPF_OPTS(bpf_object_open_opts, opts); > - struct changes_pkt_data *main = NULL; > + struct changes_pkt_data *main_data = NULL; > char log[16*1024]; > int err; > > @@ -27,14 +27,14 @@ static void test_aux(const char *main_prog_name, > opts.kernel_log_size = sizeof(log); > if (env.verbosity >= VERBOSE_SUPER) > opts.kernel_log_level = 1 | 2 | 4; > - main = changes_pkt_data__open_opts(&opts); > - if (!ASSERT_OK_PTR(main, "changes_pkt_data__open")) > + main_data = changes_pkt_data__open_opts(&opts); > + if (!ASSERT_OK_PTR(main_data, "changes_pkt_data__open")) > goto out; > - main_prog = bpf_object__find_program_by_name(main->obj, main_prog_name); > + main_prog = bpf_object__find_program_by_name(main_data->obj, main_prog_name); > if (!ASSERT_OK_PTR(main_prog, "main_prog")) > goto out; > bpf_program__set_autoload(main_prog, true); > - err = changes_pkt_data__load(main); > + err = changes_pkt_data__load(main_data); > print_verifier_log(log); > if (!ASSERT_OK(err, "changes_pkt_data__load")) > goto out; > @@ -60,7 +60,7 @@ static void test_aux(const char *main_prog_name, > > out: > changes_pkt_data_freplace__destroy(freplace); > - changes_pkt_data__destroy(main); > + changes_pkt_data__destroy(main_data); > } > > /* There are two global subprograms in both changes_pkt_data.skel.h: