linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: <jgg@nvidia.com>, <kevin.tian@intel.com>, <corbet@lwn.net>,
	<will@kernel.org>
Cc: <bagasdotme@gmail.com>, <robin.murphy@arm.com>, <joro@8bytes.org>,
	<thierry.reding@gmail.com>, <vdumpa@nvidia.com>,
	<jonathanh@nvidia.com>, <shuah@kernel.org>, <jsnitsel@redhat.com>,
	<nathan@kernel.org>, <peterz@infradead.org>, <yi.l.liu@intel.com>,
	<mshavit@google.com>, <praan@google.com>,
	<zhangzekun11@huawei.com>, <iommu@lists.linux.dev>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-tegra@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<patches@lists.linux.dev>, <mochs@nvidia.com>,
	<alok.a.tiwari@oracle.com>, <vasant.hegde@amd.com>
Subject: [PATCH v2 13/22] iommufd: Add mmap interface
Date: Fri, 25 Apr 2025 22:58:08 -0700	[thread overview]
Message-ID: <7be26560c604b0cbc2fd218997b97a47e4ed11ff.1745646960.git.nicolinc@nvidia.com> (raw)
In-Reply-To: <cover.1745646960.git.nicolinc@nvidia.com>

For vIOMMU passing through HW resources to user space (VMs), add an mmap
infrastructure to map a region of hardware MMIO pages.

Maintain an mt_mmap per ictx for validations. To allow IOMMU drivers to
add and delete mmappable regions to/from the mt_mmap, add a pair of new
helpers: iommufd_ctx_alloc_mmap() and iommufd_ctx_free_mmap().

Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
 drivers/iommu/iommufd/iommufd_private.h |  8 +++++
 include/linux/iommufd.h                 | 15 ++++++++++
 drivers/iommu/iommufd/driver.c          | 39 +++++++++++++++++++++++++
 drivers/iommu/iommufd/main.c            | 39 +++++++++++++++++++++++++
 4 files changed, 101 insertions(+)

diff --git a/drivers/iommu/iommufd/iommufd_private.h b/drivers/iommu/iommufd/iommufd_private.h
index b974c207ae8a..db5b62ec4abb 100644
--- a/drivers/iommu/iommufd/iommufd_private.h
+++ b/drivers/iommu/iommufd/iommufd_private.h
@@ -7,6 +7,7 @@
 #include <linux/iommu.h>
 #include <linux/iommufd.h>
 #include <linux/iova_bitmap.h>
+#include <linux/maple_tree.h>
 #include <linux/rwsem.h>
 #include <linux/uaccess.h>
 #include <linux/xarray.h>
@@ -44,6 +45,7 @@ struct iommufd_ctx {
 	struct xarray groups;
 	wait_queue_head_t destroy_wait;
 	struct rw_semaphore ioas_creation_lock;
+	struct maple_tree mt_mmap;
 
 	struct mutex sw_msi_lock;
 	struct list_head sw_msi_list;
@@ -55,6 +57,12 @@ struct iommufd_ctx {
 	struct iommufd_ioas *vfio_ioas;
 };
 
+/* Entry for iommufd_ctx::mt_mmap */
+struct iommufd_mmap {
+	unsigned long pfn_start;
+	unsigned long pfn_end;
+};
+
 /*
  * The IOVA to PFN map. The map automatically copies the PFNs into multiple
  * domains and permits sharing of PFNs between io_pagetable instances. This
diff --git a/include/linux/iommufd.h b/include/linux/iommufd.h
index 5dff154e8ce1..d63e2d91be0d 100644
--- a/include/linux/iommufd.h
+++ b/include/linux/iommufd.h
@@ -236,6 +236,9 @@ int iommufd_object_depend(struct iommufd_object *obj_dependent,
 			  struct iommufd_object *obj_depended);
 void iommufd_object_undepend(struct iommufd_object *obj_dependent,
 			     struct iommufd_object *obj_depended);
+int iommufd_ctx_alloc_mmap(struct iommufd_ctx *ictx, phys_addr_t base,
+			   size_t size, unsigned long *immap_id);
+void iommufd_ctx_free_mmap(struct iommufd_ctx *ictx, unsigned long immap_id);
 struct device *iommufd_viommu_find_dev(struct iommufd_viommu *viommu,
 				       unsigned long vdev_id);
 int iommufd_viommu_get_vdev_id(struct iommufd_viommu *viommu,
@@ -262,11 +265,23 @@ static inline int iommufd_object_depend(struct iommufd_object *obj_dependent,
 	return -EOPNOTSUPP;
 }
 
+static inline int iommufd_ctx_alloc_mmap(struct iommufd_ctx *ictx,
+					 phys_addr_t base, size_t size,
+					 unsigned long *immap_id)
+{
+	return -EOPNOTSUPP;
+}
+
 static inline void iommufd_object_undepend(struct iommufd_object *obj_dependent,
 					   struct iommufd_object *obj_depended)
 {
 }
 
+static inline void iommufd_ctx_free_mmap(struct iommufd_ctx *ictx,
+					 unsigned long immap_id)
+{
+}
+
 static inline struct device *
 iommufd_viommu_find_dev(struct iommufd_viommu *viommu, unsigned long vdev_id)
 {
diff --git a/drivers/iommu/iommufd/driver.c b/drivers/iommu/iommufd/driver.c
index fb7f8fe40f95..c55336c580dc 100644
--- a/drivers/iommu/iommufd/driver.c
+++ b/drivers/iommu/iommufd/driver.c
@@ -78,6 +78,45 @@ void iommufd_object_undepend(struct iommufd_object *obj_dependent,
 }
 EXPORT_SYMBOL_NS_GPL(iommufd_object_undepend, "IOMMUFD");
 
+/* Driver should report the output @immap_id to user space for mmap() syscall */
+int iommufd_ctx_alloc_mmap(struct iommufd_ctx *ictx, phys_addr_t base,
+			   size_t size, unsigned long *immap_id)
+{
+	struct iommufd_mmap *immap;
+	int rc;
+
+	if (WARN_ON_ONCE(!immap_id))
+		return -EINVAL;
+	if (base & ~PAGE_MASK)
+		return -EINVAL;
+	if (!size || size & ~PAGE_MASK)
+		return -EINVAL;
+
+	immap = kzalloc(sizeof(*immap), GFP_KERNEL);
+	if (!immap)
+		return -ENOMEM;
+	immap->pfn_start = base >> PAGE_SHIFT;
+	immap->pfn_end = immap->pfn_start + (size >> PAGE_SHIFT) - 1;
+
+	rc = mtree_alloc_range(&ictx->mt_mmap, immap_id, immap, sizeof(immap),
+			       0, LONG_MAX >> PAGE_SHIFT, GFP_KERNEL);
+	if (rc < 0) {
+		kfree(immap);
+		return rc;
+	}
+
+	/* mmap() syscall will right-shift the immap_id to vma->vm_pgoff */
+	*immap_id <<= PAGE_SHIFT;
+	return 0;
+}
+EXPORT_SYMBOL_NS_GPL(iommufd_ctx_alloc_mmap, "IOMMUFD");
+
+void iommufd_ctx_free_mmap(struct iommufd_ctx *ictx, unsigned long immap_id)
+{
+	kfree(mtree_erase(&ictx->mt_mmap, immap_id >> PAGE_SHIFT));
+}
+EXPORT_SYMBOL_NS_GPL(iommufd_ctx_free_mmap, "IOMMUFD");
+
 /* Caller should xa_lock(&viommu->vdevs) to protect the return value */
 struct device *iommufd_viommu_find_dev(struct iommufd_viommu *viommu,
 				       unsigned long vdev_id)
diff --git a/drivers/iommu/iommufd/main.c b/drivers/iommu/iommufd/main.c
index ac51d5cfaa61..4b46ea47164d 100644
--- a/drivers/iommu/iommufd/main.c
+++ b/drivers/iommu/iommufd/main.c
@@ -213,6 +213,7 @@ static int iommufd_fops_open(struct inode *inode, struct file *filp)
 	xa_init_flags(&ictx->objects, XA_FLAGS_ALLOC1 | XA_FLAGS_ACCOUNT);
 	xa_init(&ictx->groups);
 	ictx->file = filp;
+	mt_init_flags(&ictx->mt_mmap, MT_FLAGS_ALLOC_RANGE);
 	init_waitqueue_head(&ictx->destroy_wait);
 	mutex_init(&ictx->sw_msi_lock);
 	INIT_LIST_HEAD(&ictx->sw_msi_list);
@@ -410,11 +411,49 @@ static long iommufd_fops_ioctl(struct file *filp, unsigned int cmd,
 	return ret;
 }
 
+/*
+ * Kernel driver must first do iommufd_ctx_alloc_mmap() to register an mmappable
+ * MMIO region to the iommufd core to receive an "immap_id". Then, driver should
+ * report to user space this immap_id and the size of the registered MMIO region
+ * for @vm_pgoff and @size of an mmap() call, via an IOMMU_VIOMMU_ALLOC ioctl in
+ * the output fields of its driver-type data structure.
+ *
+ * Note the @size is allowed to be smaller than the registered size as a partial
+ * mmap starting from the registered base address.
+ */
+static int iommufd_fops_mmap(struct file *filp, struct vm_area_struct *vma)
+{
+	struct iommufd_ctx *ictx = filp->private_data;
+	size_t size = vma->vm_end - vma->vm_start;
+	struct iommufd_mmap *immap;
+
+	if (size & ~PAGE_MASK)
+		return -EINVAL;
+	if (!(vma->vm_flags & VM_SHARED))
+		return -EINVAL;
+	if (vma->vm_flags & VM_EXEC)
+		return -EPERM;
+
+	/* vm_pgoff carries an index (immap_id) to an mtree entry (immap) */
+	immap = mtree_load(&ictx->mt_mmap, vma->vm_pgoff);
+	if (!immap)
+		return -ENXIO;
+	if (size >> PAGE_SHIFT > immap->pfn_end - immap->pfn_start + 1)
+		return -ENXIO;
+
+	vma->vm_pgoff = 0;
+	vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
+	vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP | VM_IO);
+	return remap_pfn_range(vma, vma->vm_start, immap->pfn_start, size,
+			       vma->vm_page_prot);
+}
+
 static const struct file_operations iommufd_fops = {
 	.owner = THIS_MODULE,
 	.open = iommufd_fops_open,
 	.release = iommufd_fops_release,
 	.unlocked_ioctl = iommufd_fops_ioctl,
+	.mmap = iommufd_fops_mmap,
 };
 
 /**
-- 
2.43.0


  parent reply	other threads:[~2025-04-26  5:59 UTC|newest]

Thread overview: 146+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-26  5:57 [PATCH v2 00/22] iommufd: Add vIOMMU infrastructure (Part-4 vCMDQ) Nicolin Chen
2025-04-26  5:57 ` [PATCH v2 01/22] iommufd/viommu: Add driver-allocated vDEVICE support Nicolin Chen
2025-04-27  6:23   ` Baolu Lu
2025-04-28  0:41     ` Tian, Kevin
2025-04-28 18:08       ` Nicolin Chen
2025-04-26  5:57 ` [PATCH v2 02/22] iommu: Pass in a driver-level user data structure to viommu_alloc op Nicolin Chen
2025-04-27  6:31   ` Baolu Lu
2025-04-28 17:19     ` Nicolin Chen
2025-04-28 17:28       ` Pranjal Shrivastava
2025-04-26  5:57 ` [PATCH v2 03/22] iommufd/viommu: Allow driver-specific user data for a vIOMMU object Nicolin Chen
2025-04-27  6:36   ` Baolu Lu
2025-04-28 17:52   ` Pranjal Shrivastava
2025-04-30 14:58   ` ALOK TIWARI
2025-04-26  5:57 ` [PATCH v2 04/22] iommu: Add iommu_copy_struct_to_user helper Nicolin Chen
2025-04-27  6:39   ` Baolu Lu
2025-04-28 17:50   ` Pranjal Shrivastava
2025-04-28 18:21     ` Nicolin Chen
2025-04-29  8:31       ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 05/22] iommufd: Add iommufd_struct_destroy to revert iommufd_viommu_alloc Nicolin Chen
2025-04-27  6:55   ` Baolu Lu
2025-04-28 17:24     ` Nicolin Chen
2025-04-26  5:58 ` [PATCH v2 06/22] iommufd/selftest: Support user_data in mock_viommu_alloc Nicolin Chen
2025-04-28 18:56   ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 07/22] iommufd/selftest: Add covearge for viommu data Nicolin Chen
2025-04-28 19:02   ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 08/22] iommufd: Abstract iopt_pin_pages and iopt_unpin_pages helpers Nicolin Chen
2025-04-27  7:22   ` Baolu Lu
2025-04-28 17:41     ` Nicolin Chen
2025-05-05 15:01       ` Jason Gunthorpe
2025-05-05 15:44         ` Nicolin Chen
2025-05-05 15:55           ` Jason Gunthorpe
2025-05-05 16:03             ` Nicolin Chen
2025-05-05 16:05               ` Jason Gunthorpe
2025-05-05 16:19                 ` Nicolin Chen
2025-05-05 16:56                   ` Jason Gunthorpe
2025-04-28 20:14   ` Pranjal Shrivastava
2025-04-28 22:12     ` Nicolin Chen
2025-04-28 23:34       ` Nicolin Chen
2025-04-29 18:03         ` Pranjal Shrivastava
2025-05-06  9:36   ` Tian, Kevin
2025-05-06 19:17     ` Nicolin Chen
2025-05-07  7:22       ` Tian, Kevin
2025-05-07  7:36         ` Nicolin Chen
2025-05-07  7:51           ` Tian, Kevin
2025-04-26  5:58 ` [PATCH v2 09/22] iommufd/viommu: Introduce IOMMUFD_OBJ_VCMDQ and its related struct Nicolin Chen
2025-04-28  1:09   ` Baolu Lu
2025-04-28 18:10     ` Nicolin Chen
2025-05-05 15:02       ` Jason Gunthorpe
2025-05-05 15:45         ` Nicolin Chen
2025-04-28 21:01   ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 10/22] iommufd/viommmu: Add IOMMUFD_CMD_VCMDQ_ALLOC ioctl Nicolin Chen
2025-04-28  1:32   ` Baolu Lu
2025-04-28 18:58     ` Nicolin Chen
2025-04-29  6:11       ` Baolu Lu
2025-04-28 12:12   ` Vasant Hegde
2025-04-28 20:02     ` Nicolin Chen
2025-04-29  5:34       ` Vasant Hegde
2025-04-29  6:45         ` Nicolin Chen
2025-04-29 10:22           ` Vasant Hegde
2025-04-29 17:14             ` Nicolin Chen
2025-04-30  4:22               ` Vasant Hegde
2025-04-30  8:01                 ` Nicolin Chen
2025-04-30 10:21                   ` Vasant Hegde
2025-05-06  9:25               ` Tian, Kevin
2025-05-06 20:12                 ` Nicolin Chen
2025-05-07  7:25                   ` Tian, Kevin
2025-05-07  7:37                     ` Nicolin Chen
2025-05-07 12:33                       ` Jason Gunthorpe
2025-05-07 20:51                         ` Nicolin Chen
2025-04-28 21:34   ` Pranjal Shrivastava
2025-04-28 22:44     ` Nicolin Chen
2025-04-29  8:28       ` Pranjal Shrivastava
2025-04-29 18:10         ` Pranjal Shrivastava
2025-04-29 18:15           ` Nicolin Chen
2025-04-29 18:57             ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 11/22] iommufd: Add for-driver helpers iommufd_vcmdq_depend/undepend() Nicolin Chen
2025-04-28  2:22   ` Baolu Lu
2025-04-28 18:17     ` Nicolin Chen
2025-04-29 12:40   ` Pranjal Shrivastava
2025-04-29 17:10     ` Nicolin Chen
2025-04-29 17:59       ` Pranjal Shrivastava
2025-04-29 18:07         ` Nicolin Chen
2025-04-29 18:44           ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 12/22] iommufd/selftest: Add coverage for IOMMUFD_CMD_VCMDQ_ALLOC Nicolin Chen
2025-04-26  5:58 ` Nicolin Chen [this message]
2025-04-28  2:50   ` [PATCH v2 13/22] iommufd: Add mmap interface Baolu Lu
2025-04-28 18:54     ` Nicolin Chen
2025-05-05 16:50     ` Jason Gunthorpe
2025-05-05 17:21       ` Nicolin Chen
2025-05-05 17:28         ` Jason Gunthorpe
2025-05-05 20:07           ` Nicolin Chen
2025-05-06  9:22             ` Tian, Kevin
2025-05-06 12:55               ` Jason Gunthorpe
2025-05-06 12:54             ` Jason Gunthorpe
2025-05-06 20:54               ` Nicolin Chen
2025-05-07 12:36                 ` Jason Gunthorpe
2025-05-07 20:49                   ` Nicolin Chen
2025-04-29 20:24   ` Pranjal Shrivastava
2025-04-29 20:34     ` Pranjal Shrivastava
2025-04-29 20:39       ` Nicolin Chen
2025-04-29 20:55         ` Pranjal Shrivastava
2025-04-29 21:05           ` Nicolin Chen
2025-04-29 21:35             ` Pranjal Shrivastava
2025-04-29 21:46               ` Nicolin Chen
2025-04-29 21:57                 ` Pranjal Shrivastava
2025-05-05 16:55                 ` Jason Gunthorpe
2025-05-05 17:27                   ` Nicolin Chen
2025-05-05 17:31                     ` Jason Gunthorpe
2025-05-05 19:50                       ` Nicolin Chen
2025-05-06 12:52                         ` Jason Gunthorpe
2025-05-06 19:30                           ` Nicolin Chen
2025-05-07 12:39                             ` Jason Gunthorpe
2025-05-07 21:09                               ` Nicolin Chen
2025-05-07 22:08                                 ` Jason Gunthorpe
2025-05-08  3:49                                   ` Nicolin Chen
2025-05-08  9:15                                     ` Tian, Kevin
2025-05-08 12:12                                       ` Jason Gunthorpe
2025-05-08 17:14                                         ` Nicolin Chen
2025-05-05 18:47                   ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 14/22] iommufd/selftest: Add coverage for the new " Nicolin Chen
2025-04-26  5:58 ` [PATCH v2 15/22] Documentation: userspace-api: iommufd: Update vCMDQ Nicolin Chen
2025-04-28 14:31   ` Bagas Sanjaya
2025-04-28 19:00     ` Nicolin Chen
2025-04-26  5:58 ` [PATCH v2 16/22] iommu/arm-smmu-v3-iommufd: Add vsmmu_alloc impl op Nicolin Chen
2025-04-29 21:36   ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 17/22] iommu/arm-smmu-v3-iommufd: Support implementation-defined hw_info Nicolin Chen
2025-04-29 21:44   ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 18/22] iommu/tegra241-cmdqv: Use request_threaded_irq Nicolin Chen
2025-04-29 21:47   ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 19/22] iommu/tegra241-cmdqv: Simplify deinit flow in tegra241_cmdqv_remove_vintf() Nicolin Chen
2025-04-29 22:05   ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 20/22] iommu/tegra241-cmdqv: Do not statically map LVCMDQs Nicolin Chen
2025-04-29 20:43   ` ALOK TIWARI
2025-04-29 22:32   ` Pranjal Shrivastava
2025-04-29 22:37     ` Nicolin Chen
2025-04-26  5:58 ` [PATCH v2 21/22] iommu/tegra241-cmdqv: Add user-space use support Nicolin Chen
2025-04-29 19:47   ` ALOK TIWARI
2025-04-29 21:12     ` Nicolin Chen
2025-04-30 21:59   ` Pranjal Shrivastava
2025-04-30 22:39     ` Nicolin Chen
2025-05-01  0:54       ` Nicolin Chen
2025-05-01 21:46         ` Pranjal Shrivastava
2025-05-01 21:45       ` Pranjal Shrivastava
2025-04-26  5:58 ` [PATCH v2 22/22] iommu/tegra241-cmdqv: Add IOMMU_VEVENTQ_TYPE_TEGRA241_CMDQV support Nicolin Chen
2025-04-30 15:07   ` ALOK TIWARI
2025-04-30 22:03   ` Pranjal Shrivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7be26560c604b0cbc2fd218997b97a47e4ed11ff.1745646960.git.nicolinc@nvidia.com \
    --to=nicolinc@nvidia.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=jsnitsel@redhat.com \
    --cc=kevin.tian@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mochs@nvidia.com \
    --cc=mshavit@google.com \
    --cc=nathan@kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=peterz@infradead.org \
    --cc=praan@google.com \
    --cc=robin.murphy@arm.com \
    --cc=shuah@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vasant.hegde@amd.com \
    --cc=vdumpa@nvidia.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    --cc=zhangzekun11@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).