From: Reinette Chatre <reinette.chatre@intel.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
<shuah@kernel.org>, <fenghua.yu@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<ilpo.jarvinen@linux.intel.com>, <tony.luck@intel.com>
Subject: Re: [PATCH v7 2/2] selftests/resctrl: Discover SNC kernel support and adjust messages
Date: Mon, 9 Dec 2024 11:37:32 -0800 [thread overview]
Message-ID: <7d97cc57-d9a1-4818-88b8-34122fd5b79a@intel.com> (raw)
In-Reply-To: <ffd4f0609a9edca8e6876c4086331d3d82e3ec3d.1733741950.git.maciej.wieczor-retman@intel.com>
Hi Maciej,
On 12/9/24 3:09 AM, Maciej Wieczor-Retman wrote:
> Resctrl selftest prints a message on test failure that Sub-Numa
> Clustering (SNC) could be enabled and points the user to check their BIOS
> settings. No actual check is performed before printing that message so
> it is not very accurate in pinpointing a problem.
>
> When there is SNC support for kernel's resctrl subsystem and SNC is
> enabled then sub node files are created for each node in the resctrlfs.
> The sub node files exist in each regular node's L3 monitoring directory.
> The reliable path to check for existence of sub node files is
> /sys/fs/resctrl/mon_data/mon_L3_00/mon_sub_L3_00.
>
> Add helper that checks for mon_sub_L3_00 existence.
>
> Correct old messages to account for kernel support of SNC in
> resctrl.
>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2024-12-09 19:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 11:09 [PATCH v7 0/2] selftests/resctrl: SNC kernel support discovery Maciej Wieczor-Retman
2024-12-09 11:09 ` [PATCH v7 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled Maciej Wieczor-Retman
2024-12-09 19:18 ` Reinette Chatre
2024-12-16 14:23 ` Maciej Wieczor-Retman
2024-12-09 11:09 ` [PATCH v7 2/2] selftests/resctrl: Discover SNC kernel support and adjust messages Maciej Wieczor-Retman
2024-12-09 19:37 ` Reinette Chatre [this message]
2024-12-09 19:19 ` [PATCH v7 0/2] selftests/resctrl: SNC kernel support discovery Reinette Chatre
2024-12-16 13:09 ` Maciej Wieczor-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d97cc57-d9a1-4818-88b8-34122fd5b79a@intel.com \
--to=reinette.chatre@intel.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=shuah@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox