From: Kevin Hilman <khilman@baylibre.com>
To: Shuah Khan <skhan@linuxfoundation.org>, shuah@kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>,
mpe@ellerman.id.au, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] selftests: Fix kselftest O=objdir build from cluttering top level objdir
Date: Wed, 11 Mar 2020 15:58:27 -0700 [thread overview]
Message-ID: <7hwo7qijn0.fsf@baylibre.com> (raw)
In-Reply-To: <58d954867391c90fe0792d87e09a82bda26ba4fc.1583358715.git.skhan@linuxfoundation.org>
Shuah Khan <skhan@linuxfoundation.org> writes:
> make kselftest-all O=objdir builds create generated objects in objdir.
> This clutters the top level directory with kselftest objects. Fix it
> to create sub-directory under objdir for kselftest objects.
>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Only somewhat related to this patch, another problem that wasn't in your
doci is that the current O= support doesn't support relative paths.
For example, using O=/tmp/build-arm64 works, but O=build-arm64 doesn't.
Try this:
$ make ARCH=arm64 HOSTCC=gcc CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 defconfig
$ make ARCH=arm64 HOSTCC=gcc CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 kselftest-all
make[1]: Entering directory '/work/kernel/linux/build-arm64'
make --no-builtin-rules INSTALL_HDR_PATH=$BUILD/usr \
ARCH=arm64 -C ../../.. headers_install
make[4]: ../scripts/Makefile.build: No such file or directory
make[4]: *** No rule to make target '../scripts/Makefile.build'. Stop.
Makefile:500: recipe for target 'scripts_basic' failed
make[3]: *** [scripts_basic] Error 2
Makefile:151: recipe for target 'khdr' failed
make[2]: *** [khdr] Error 2
/work/kernel/linux/Makefile:1220: recipe for target 'kselftest-all' failed
make[1]: *** [kselftest-all] Error 2
make[1]: Leaving directory '/work/kernel/linux/build-arm64'
Makefile:179: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2
Kevin
> ---
> tools/testing/selftests/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 6ec503912bea..cd77df3e6bb8 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -91,7 +91,7 @@ override LDFLAGS =
> override MAKEFLAGS =
> endif
>
> -# Append kselftest to KBUILD_OUTPUT to avoid cluttering
> +# Append kselftest to KBUILD_OUTPUT and O to avoid cluttering
> # KBUILD_OUTPUT with selftest objects and headers installed
> # by selftests Makefile or lib.mk.
> ifdef building_out_of_srctree
> @@ -99,7 +99,7 @@ override LDFLAGS =
> endif
>
> ifneq ($(O),)
> - BUILD := $(O)
> + BUILD := $(O)/kselftest
> else
> ifneq ($(KBUILD_OUTPUT),)
> BUILD := $(KBUILD_OUTPUT)/kselftest
> --
> 2.20.1
next prev parent reply other threads:[~2020-03-11 22:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 22:13 [PATCH 0/4] Kselftest integration into Kernel CI - Part 1 Shuah Khan
2020-03-04 22:13 ` [PATCH 1/4] selftests: Fix kselftest O=objdir build from cluttering top level objdir Shuah Khan
2020-03-11 22:58 ` Kevin Hilman [this message]
2020-03-11 23:31 ` Shuah Khan
2020-05-15 2:27 ` Randy Dunlap
2020-05-15 14:15 ` Shuah Khan
2020-03-04 22:13 ` [PATCH 2/4] selftests: Fix seccomp to support relocatable build (O=objdir) Shuah Khan
2020-03-04 22:42 ` Kees Cook
2020-03-04 23:15 ` Shuah Khan
2020-03-05 0:22 ` Michael Ellerman
2020-03-05 0:29 ` Shuah Khan
2020-03-04 22:13 ` [PATCH 3/4] selftests: android: ion: Fix ionmap_test compile error Shuah Khan
2020-03-04 22:13 ` [PATCH 4/4] selftests: android: Fix custom install from skipping test progs Shuah Khan
2020-03-04 23:09 ` [PATCH 0/4] Kselftest integration into Kernel CI - Part 1 Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hwo7qijn0.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox