From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647CEC001B0 for ; Thu, 13 Jul 2023 15:46:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234076AbjGMPqi (ORCPT ); Thu, 13 Jul 2023 11:46:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbjGMPqh (ORCPT ); Thu, 13 Jul 2023 11:46:37 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 62823270B; Thu, 13 Jul 2023 08:46:35 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A68F71570; Thu, 13 Jul 2023 08:47:17 -0700 (PDT) Received: from [10.1.30.48] (C02Z41KALVDN.cambridge.arm.com [10.1.30.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5A0F3F73F; Thu, 13 Jul 2023 08:46:33 -0700 (PDT) Message-ID: <803bb28b-b25c-510d-bc70-b6726f750538@arm.com> Date: Thu, 13 Jul 2023 16:46:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 9/9] selftests/mm: Run all tests from run_vmtests.sh To: Mark Brown Cc: David Hildenbrand , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , John Hubbard , Florent Revest , "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230713135440.3651409-1-ryan.roberts@arm.com> <20230713135440.3651409-10-ryan.roberts@arm.com> <2b586ba2-7522-a823-afd6-7b4d978f18c2@arm.com> <97742685-e026-417b-8c8f-938330027636@sirena.org.uk> <8d2e75e7-0d38-6e6c-a02a-b66a18515dfb@arm.com> <5b4fcf62-98c3-458e-a0e7-8e86ec354cb9@sirena.org.uk> From: Ryan Roberts In-Reply-To: <5b4fcf62-98c3-458e-a0e7-8e86ec354cb9@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 13/07/2023 16:43, Mark Brown wrote: > On Thu, Jul 13, 2023 at 04:36:18PM +0100, Ryan Roberts wrote: >> On 13/07/2023 16:30, Mark Brown wrote: > >>> The results parsers I'm aware of like the LAVA one will DTRT with nested >>> kselftests since that's required to pull see individual test cases run >>> by a single binary so it's the common case to see at least one level of >>> nesting. > >> That's good to hear. But bear in mind that run_vmtests.sh does not use TAP. So >> you end up with a single top-level test who's result is reported with >> run_kselftest.sh's TAP output. Then you have a second level (run_vmtests.sh) >> using custom reporting, then _some_ of the tests invoked use TAP so you >> sometimes have TAP at level 3. But those tests at level 2 that don't do their >> own TAP output probably won't be parsed by LAVA? > > I think that should mostly mean that all the tests that don't > individually produce KTAP output get ignored by parsers and those which > do produce KTAP output will be seen as nesting one level up from where > they are (ie, the individual cases will run directly from vmtest), > though there's likely to be confusion about expected run numbers for > things that actually pay attention to that. I suspect it wouldn't be technically dififcult to add a --tap option to run_vmtests.sh, which would switch the output format to TAP. If people are amenable. > >> Since you agreed to put this into the CI, I was going to call this part "your >> problem" ;-) > > It'll run, the results are a different story. :P