From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: "Shuah Khan" <shuah@kernel.org>,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org,
"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/5] selftests/resctrl: Remove duplicate feature check from CMT test
Date: Wed, 13 Sep 2023 14:11:49 +0300 (EEST) [thread overview]
Message-ID: <80695068-4a6-b8e9-107f-8d29ab3543be@linux.intel.com> (raw)
In-Reply-To: <40ba8890-32d1-e440-29fd-b8f8db69acc5@intel.com>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Tue, 12 Sep 2023, Reinette Chatre wrote:
> On 9/11/2023 4:19 AM, Ilpo Järvinen wrote:
> > The test runner run_cmt_test() in resctrl_tests.c checks for CMT
> > feature and does not run cmt_resctrl_val() if CMT is not supported.
> > Then cmt_resctrl_val() also check is CMT is supported.
> >
> > Remove the duplicated feature check for CMT from cmt_resctrl_val().
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > Cc: <stable@vger.kernel.org>
>
> This does not look like stable material to me.
I know but when constructing this series I had 2 options:
Either convert also this when changing validate_resctrl_feature_request()
or remove this call entirely.
Given it's duplicate of the other CMT check, I chose to just remove it
(which I'd do anyway). As patch 4/5 requires 3/5 which in turn requires
this, this has to go stable if 4/5 goes too.
--
i.
next prev parent reply other threads:[~2023-09-13 11:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 11:19 [PATCH 0/5] selftests/resctrl: Fixes to failing tests Ilpo Järvinen
2023-09-11 11:19 ` [PATCH 1/5] selftests/resctrl: Extend signal handler coverage to unmount on receiving signal Ilpo Järvinen
2023-09-12 22:06 ` Reinette Chatre
2023-09-13 10:01 ` Ilpo Järvinen
2023-09-13 20:58 ` Reinette Chatre
2023-09-14 10:16 ` Ilpo Järvinen
2023-09-14 15:04 ` Reinette Chatre
2023-09-14 17:05 ` Ilpo Järvinen
2023-09-14 17:29 ` Reinette Chatre
2023-09-11 11:19 ` [PATCH 2/5] selftests/resctrl: Remove duplicate feature check from CMT test Ilpo Järvinen
2023-09-12 22:06 ` Reinette Chatre
2023-09-13 11:11 ` Ilpo Järvinen [this message]
2023-09-13 20:58 ` Reinette Chatre
2023-09-14 9:58 ` Ilpo Järvinen
2023-09-14 15:04 ` Reinette Chatre
2023-09-11 11:19 ` [PATCH 3/5] selftests/resctrl: Refactor feature check to use resource and feature name Ilpo Järvinen
2023-09-12 22:09 ` Reinette Chatre
2023-09-13 11:02 ` Ilpo Järvinen
2023-09-13 20:59 ` Reinette Chatre
2023-09-14 11:06 ` Ilpo Järvinen
2023-09-11 11:19 ` [PATCH 4/5] selftests/resctrl: Fix feature checks Ilpo Järvinen
2023-09-11 11:19 ` [PATCH 5/5] selftests/resctrl: Reduce failures due to outliers in MBA/MBM tests Ilpo Järvinen
2023-09-12 22:10 ` Reinette Chatre
2023-09-13 11:43 ` Ilpo Järvinen
2023-09-13 21:00 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80695068-4a6-b8e9-107f-8d29ab3543be@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox