From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011048.outbound.protection.outlook.com [52.101.65.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2CF730BB9B; Tue, 5 May 2026 11:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.48 ARC-Seal:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777980529; cv=fail; b=MQWhkA03vuiir+5hEosX6Kl2wMS9q1tIStXQB3kw2ux4rfzFCLv5wCUzOcXV7g/tnqB7yYCsdd3UTnEHU84AydMor7hmqCz4x6oL4ZGuuZ369tYZzMVh11yUL+lDRpeUgx/MHYze9u8ZSdaXBKJ1eLajCOant515sLxD9yURj4U= ARC-Message-Signature:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777980529; c=relaxed/simple; bh=C0zFgux972gJyEdmFS28eW5g4VnnZlAcCGbXNGy1pr4=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=HTMki+90HDbJdogsYNH15f0one5uCt8HuREyXDpIYtX7dlttNkxZ5KzF70Htr7w64Make82NCIZ/qnUKAqEBhHzZoRo9h5TCu2ir2ZBkvH2r1IQF58SvOOwnBGtKrcUgaUGCsTM3vPXi/f+LjU1+P2VknKnLYIviGpbIROdtPlM= ARC-Authentication-Results:i=3; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=B4cc3ALI; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=B4cc3ALI; arc=fail smtp.client-ip=52.101.65.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="B4cc3ALI"; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="B4cc3ALI" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=WhztLOsPlC4/2FQAJTLpjicKEBJtD+pQk8F9b2MsVbUg1RbVSgVNBptZrdUwMy9Hh00AGyrWOhJSH+la/Fgt0l31jJbqYk6ukjtInS5tjtTBQbV9uDrOY8mOWMTg6S/ujqv3En+f3O1p+xHfWe8ZNYz6JLX/Z7npqiLbWjSjw0u76lpULG3Vw9537F+fsZwrvbzOdvwdYNIZO2+Igb49lTG7Ga1eM7lnvMGWmywLMV1HzJuvsotZfA3SgfOMulIyAPvT7q+aaMbMB+hGmO/X+uK4NGWvMCOw9ZWzYKN3QNdIYQqmLYG+utVx0pEQ/I5SA0yPgialNq6SzUjubw/oKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XOjzXEc0PrSRWuBcgphpOvVoVg22Tfgi9nnp2xEp0y4=; b=bhzohHQOYaXfW89gYzFkqsErElzyLnoajRa0pz2aqaaJ/2qJKjJpIVnlKFdimlWgSdzKS4jVwmrvhfIWVXAAycSNM6PRrD8pu9i3Xgfq5/0Mc5NxhlPUToIw6+yCRLHVeVVwta++PyyC/LmbM1BDyO/pI318ozitGBAVsoJUnhhui50lRBXD9qm7v++C7WzpLIhpxtndPoWwBfzoJS6vfKKr/5GTTfSH2XTBGiLGMyR1C/X3EKpU6V39jq6j45ZZ1KjjpkzbN+Cp5GJnuaOhPZG44NR7K4H1wKkQ+ZLwwO/jXQWa1Qc9JCiTEawakQfCG7QM8uQ/rzO1z33c26w6XA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XOjzXEc0PrSRWuBcgphpOvVoVg22Tfgi9nnp2xEp0y4=; b=B4cc3ALId2hvf/mlLUzuFY6EEPdtN1HXe5rf8jSmSUXSxBE8b/s+Itt3yJ7mC/Whb3jMsAsvq4WkcCZbhvWVtOoLVRaQqR2LGu/DFroDe+awGWKan1HmTbf0MKZYyAyxxZF73YGlMjNWR3kaseHyufT3jrdewacl0ULvZgpMoYc= Received: from AS9PR06CA0520.eurprd06.prod.outlook.com (2603:10a6:20b:49d::23) by DBBPR08MB5946.eurprd08.prod.outlook.com (2603:10a6:10:1f6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Tue, 5 May 2026 11:28:39 +0000 Received: from AM4PEPF00025F9C.EURPRD83.prod.outlook.com (2603:10a6:20b:49d:cafe::3d) by AS9PR06CA0520.outlook.office365.com (2603:10a6:20b:49d::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9870.25 via Frontend Transport; Tue, 5 May 2026 11:28:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM4PEPF00025F9C.mail.protection.outlook.com (10.167.16.11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.1 via Frontend Transport; Tue, 5 May 2026 11:28:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DLu3DSbaqMpII9IyabbvAc+xxlmYKBbjipWHRMoP4WF3tnZfvz9BSYoCP4KGyoxkVMw/Lke6joqEf4vqpghio+a1O0I/zytDWo97s3O2OGIe+u8Fm44bLda9U7OiOSPuRmwrplo6tWODjLqXxIWpBk5Dktzo7RT7Vlbge2sFyr2WNf5stoPzvfqsjyHxCyRR7PMtnFhNsvyGuOHykRfYyze0jDj3rTUaGco7BOZ+6ANEw2+/nCNU8iKePMB7e+THf9uJo4J9L+73unzom+MnR6cDtxmD/pDMx/i2C3AnuN8Zuuuy1nCjZJrcfw6fVSMCsftNYJ+aeIY1luyQaP0eOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XOjzXEc0PrSRWuBcgphpOvVoVg22Tfgi9nnp2xEp0y4=; b=igFOCNCMkHgf3uPj38vq4mzfLhIel6lvaBPJAKnTEqYKs8OCplkvQ6Omv0AE4Xs/SgeAmc+lwscNm+1ClZz+coatH6pxLRn0NRh7OSTyS/M3CHHuPwO7mAy3+yxyl8iETuDxF2sIyD9P7wjQ8PYEANcU/+EasfjcSqlh+4u/7ZimEGyiVu84wX9N0CVj6q/KGltCtikNYN2ZfXZakOnXTc+nqVjwSN9vXkbIyY1+w1zXYgj+s+luT+zETmK4EFvPMSzZ5sawyK5pQn3v58p8/keZ61gG5l/w4UNcHFAa5K47UPSVWxHYgaSx1LMnZYe5TOzEyKzxPhkMQTbDqBIvpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XOjzXEc0PrSRWuBcgphpOvVoVg22Tfgi9nnp2xEp0y4=; b=B4cc3ALId2hvf/mlLUzuFY6EEPdtN1HXe5rf8jSmSUXSxBE8b/s+Itt3yJ7mC/Whb3jMsAsvq4WkcCZbhvWVtOoLVRaQqR2LGu/DFroDe+awGWKan1HmTbf0MKZYyAyxxZF73YGlMjNWR3kaseHyufT3jrdewacl0ULvZgpMoYc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) by AMBPR08MB11654.eurprd08.prod.outlook.com (2603:10a6:20b:737::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Tue, 5 May 2026 11:27:35 +0000 Received: from DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047]) by DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047%2]) with mapi id 15.20.9870.023; Tue, 5 May 2026 11:27:35 +0000 Message-ID: <8255ff5b-a4a2-4115-948e-9a2198f27167@arm.com> Date: Tue, 5 May 2026 16:57:26 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 50/54] selftests/mm: uffd-wp-mremap: add setup of HugeTLB pages To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Luiz Capitulino , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260428204240.1924129-1-rppt@kernel.org> <20260428204240.1924129-51-rppt@kernel.org> From: Sarthak Sharma Content-Language: en-US In-Reply-To: <20260428204240.1924129-51-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA5P287CA0191.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:1b6::7) To DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB9203:EE_|AMBPR08MB11654:EE_|AM4PEPF00025F9C:EE_|DBBPR08MB5946:EE_ X-MS-Office365-Filtering-Correlation-Id: 554cd7e4-288c-4452-e837-08deaa997487 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info-Original: 6qpBHcp+ymIW/xn7ItcEq3+78QtBSOEjh5LWjSHombtirlVjiWbjbcH+4WBTcu7P2daENJWR9V5MQ8glIilUTa0OMtG9la2LH+L2Zh1IuW7HIKXnD5izXApX8zhE2MOXff9HoUSBi33OaWMHz662rVkOxSA9R2I7A4ue9bN42xGhTxmFR6VUO/QFP/yWhSNsTzXZU7fqr6VIOA28akBRXI3ZkleCyxUHHibm6X1T7vT9U44I1MP2CQ+9bBbn/f1+UnpemXBEKoAY5b1Po5XVSc/CZ37fXIDj4TaiO6MmEX5u3Rc8wFKpKnW7iQop0gi+cU1QRedKJ+l/xMvsgMebu2zkZAbnlrmO4P+XktP9mjkGH/Ttl/4OReXFGkzRRkn9UURWfLvSi1Lx2iWp6HtmJuwSdvbwQaLB08GvFjcY0AcQSuWWv1775zxmM0YxwyBmIqO+AwFdsvQoTHq5ZxbqH7lx4oyb1JlBkp7kU89QPpLdiWXQV2LmyYBPM1J0XmEYVfowhj++Dg47XmmvQelvjJwGKuS+s9xI1xCw+gBhqU6b6BGY27QRJ4+QqmYAFi664h0Xwre/Q5c4hCzp+sAysGlIsAF0yD/6vkH7DSxZBJ1RJMG7hdawu1GqnAumXIM4QpHIhG3hX2T2Dgg89WbKFQIKhA8uARToxCRImSfhieLQtIf5RmG7jxERXGc7rBQt X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB9203.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: O/8YD84obmANhQ4thgHBllyUyFtxA/0lmIjf1gw9xB/C7vdGM6JJDAen08ytefAwLRTbDwxpv8kQZs78ai31ev7XBv1NiS4FczbOMbKJ7eBnsEGbVIX9j5B8GUZHxFQm7/1aQgGGmCGFslb0EXt5eHdZGnRFBHkz1hvWMvxZXaa5A2yPAFCYV8msDOMMtjiW6tIhMETJRPFyX0r83zXZtFbw7hX4vttOerRHqLbBYB5wAOa//+p21V4hp92K3REjNTXIlaiLhZL1OhTaXwJZpPYOdNy1vSCJ0y47Yy18EOI/xubmmeD7Y9v4b7VCVfqH6DWG4kX+iOVbo7AmUmHz4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMBPR08MB11654 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00025F9C.EURPRD83.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fb75a950-bf60-45a4-d393-08deaa994dc9 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|14060799003|7416014|376014|1800799024|82310400026|35042699022|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: n26ypGN9/VkssOF27W7vqxGVlaiZ3ssHjZHGwIt8GqFd3Wqf+8vvVoHIlCEgydV+qgGbzdX/PDYUe2zdfKjdTJYUzITbgo1Wa6HaRp60gT+n0yMNxkW2rXj73ZUg7fmXbIb3OSNph7QYR6acCXGKXx8DV7D10KmROP9/9B7cvUHy4l/wPNCrfmDzmmXTj9XuVP0cm7b213jjBrFGlXFCPCZtSow9C7NX232iNOOXXhWlomlpBtmX3FBlUZnhF4PSRTqndmTbFWLHL9p8ewbf9c8MpbIGL3Dbz63ZcKpAkeCe3lDCE62XSfPxaGdKO1ljfiJ1VUcg6MqyhbMlCo3bfpZbUbHqZ/OOyUuZQXpnk21qjlBPn5ePdrOMfmalYU6bRagPtI6gE9PtFSUpHejX/kbNfQEMDz7w/4p9pcPa7KcRyBPFT7QcUc9h+4Bs2uSVCaE69GjzgCb9AzYCF6U/Q9qPGR7hpqVFGGzGflwBiLhgqM2HOc+HCBkmp0f+xwITGZElQLjwDajq5gsSHLgIHnQHspcOIsZVddl65oDUc+pv+trWI6VA4SxZ9cAAXeFM1bxl4AjBrQ0yGJtNQle5cPxF98Jqh+rp+OULBSFaeHK2mQfhSwCU8WEXSPiiiymJ+JJ3zKqY7UUy8gpb+0GVfxfC6kDO9CxDG8JgIlMhxm6gAiUV4YY7daGAE0KDBGKWhOl94vO/KUbGNDj/M8+xrakq9SEi8GW4wQgX5PpyRBs= X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(14060799003)(7416014)(376014)(1800799024)(82310400026)(35042699022)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ObyaUWG8wVd5AD7hJLjkj9GqE+0nJEGhhde86/VBtgNLcJn7AsjXD/NL7R5kLwMgOFIKAh7a8/drcoOUP5d/W3Pd5xOMoilt2NTy9Cmw31gveDXKqz0aZ3D8jRQkHL3V9ezHG0jQhCsmhy+alIZwoZHCr0CB2EECOiBZw5ReSExIo1lOcjV9JYRlQA951Azo9v/ir8/lWo/I+3yaBm3HB5G5bCVIZplvRbS8+EJdNxy0/FzvPhZYgW2p5v7UMcWw0G+RwmJH7uLZsLVepjmXTz/smZFg3FZkZvliXQ9aAKdLPZK1LyNj2leIdW4NEF+zWul3vF5KOlMOTxMpi8fY7zelvLVZC6YrvcXTcAYwUwPpeXwO4goqWivuArdo3hjoDnQfcVruqtljWaOGmq6oXjOcLw08ij2C3JVnk1O8Aah5irlUaUUuTIQG/ChDKECf X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2026 11:28:39.4015 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 554cd7e4-288c-4452-e837-08deaa997487 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F9C.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5946 Hi Mike! On 4/29/26 2:12 AM, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > uffd-wp-remap skips HugeTLB tests if there are no free huge pages > prepared by a wrapper script. > > Add setup of HugeTLB pages to the test and make sure that the original > settings are restored on the test exit. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > tools/testing/selftests/mm/uffd-wp-mremap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/selftests/mm/uffd-wp-mremap.c > index 9d67b11c2f28..f63fe02f404f 100644 > --- a/tools/testing/selftests/mm/uffd-wp-mremap.c > +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c > @@ -336,14 +336,14 @@ int main(int argc, char **argv) > struct thp_settings settings; > int i, j, plan = 0; > > + hugepage_save_settings(true, true); Since hugetlb_setup below already calls hugepage_save_settings() internally, perhaps we can change this to hugepage_save_settings(true, false) or simply keep thp_save_settings()? Otherwise we're saving the HugeTLB state twice here and it seems redundant. > + > pagesize = getpagesize(); > nr_thpsizes = detect_thp_sizes(thpsizes, ARRAY_SIZE(thpsizes)); > - nr_hugetlbsizes = detect_hugetlb_page_sizes(hugetlbsizes, > - ARRAY_SIZE(hugetlbsizes)); > + nr_hugetlbsizes = hugetlb_setup(1, hugetlbsizes, ARRAY_SIZE(hugetlbsizes)); > > /* If THP is supported, save THP settings and initially disable THP. */ > if (nr_thpsizes) { > - thp_save_settings(); > thp_read_settings(&settings); > for (i = 0; i < NR_ORDERS; i++) { > settings.hugepages[i].enabled = THP_NEVER;