Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Gerd Bayer <gbayer@linux.ibm.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
	"chenxiang (M)" <chenxiang66@hisilicon.com>,
	Shuah Khan <shuah@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux.dev, linux-kselftest@vger.kernel.org,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] dma-mapping: benchmark: Fix compile error in user-space tool
Date: Mon, 09 Jan 2023 17:45:36 +0100	[thread overview]
Message-ID: <8315d3374f6129d99c07eb965f7f7bb2bd0bbd25.camel@linux.ibm.com> (raw)
In-Reply-To: <cdfc618a-5091-8989-7ca2-5d8d467b4adb@linuxfoundation.org>

On Wed, 2022-12-21 at 09:44 -0700, Shuah Khan wrote:
> On 12/21/22 09:39, Shuah Khan wrote:
> > On 12/16/22 07:35, Gerd Bayer wrote:
> > > On Tue, 2022-12-06 at 11:13 +0800, chenxiang (M) wrote:
> > > > 
> > > > 在 2022/12/5 21:50, Gerd Bayer 写道:
> > > > > Since [1] the user-space program dma_map_benchmark shares the
> > > > > header file
> > > > > linux/map_benchmark.h with the kernel driver in
> > > > > kernel/dma/map_benchmark.c.
> > > > > With latest kernel version this does not compile any more.
 [...]
> > > > 
> > > > It also solves the compile error on arm64 platform.
> > > > Acked-by:  Xiang Chen <chenxiang66@hisilicon.com>
> > > 
> > > Hi Xiang Chen, hi Shuah,
> > > 
> > > so is there any chance to have this compile fix integrated into
> > > linux-
> > > next still, or is this too late now?
> > Plan to apply this after the merge window closes
> > 
> 
> The reason for the delay is this patch doesn't have the right commit
> header. This should have been "selftests:dma -----"
> 
> It makes it easier for maintainers to parse and pay attention to the
> patches if they indicate the area they fall under. Something to
> keep in mind for your future patches.
> 
> Please resend the patch with the Acks you received and a correct
> commit header.
> 
> thanks,
> -- Shuah

Shuah,

thank you for your explanation. I'm working on resending the patch.

Thanks,
Gerd

      reply	other threads:[~2023-01-09 16:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 13:50 [PATCH] dma-mapping: benchmark: Fix compile error in user-space tool Gerd Bayer
2022-12-06  3:13 ` chenxiang (M)
2022-12-16 14:35   ` Gerd Bayer
2022-12-19  0:40     ` chenxiang (M)
2022-12-21 10:27       ` Christoph Hellwig
2022-12-21 16:39     ` Shuah Khan
2022-12-21 16:44       ` Shuah Khan
2023-01-09 16:45         ` Gerd Bayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8315d3374f6129d99c07eb965f7f7bb2bd0bbd25.camel@linux.ibm.com \
    --to=gbayer@linux.ibm.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=schnelle@linux.ibm.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox