Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Shuah Khan <shuah@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
	Peter Xu <peterx@redhat.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Guillaume Tucker <gtucker@gtucker.io>
Subject: Re: [PATCH 0/2] Fix selftests/mm build without requiring "make headers"
Date: Thu, 28 Mar 2024 10:28:38 -0700	[thread overview]
Message-ID: <834542e1-bb29-49ed-98ee-13a79168819f@nvidia.com> (raw)
In-Reply-To: <6d82298b-b17b-440a-beef-590177d0ff50@collabora.com>

On 3/28/24 2:02 AM, Muhammad Usama Anjum wrote:
> On 3/28/24 8:34 AM, John Hubbard wrote:
>> Hi,
>>
>> As mentioned in each patch, this implements the solution that we discussed in
>> December 2023, in [1]. This turned out to be very clean and easy. It should also
>> be quite easy to maintain.
> There is another way. The headers should be built automatically by make
> dependency. The topmost make file always builds headers before building
> kselftest i.e., make kselftest
> 

I think we talked through this already: Peter Z. pointed out the problems
with requiring this kind of prerequisite. And it really it overkill. The
approach here is simple, easy to maintain, and avoids breaking the various
unusual build setups that people have.

I'll shut up now and let others weigh in, though. :)


thanks,
-- 
John Hubbard
NVIDIA


      reply	other threads:[~2024-03-28 17:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  3:34 [PATCH 0/2] Fix selftests/mm build without requiring "make headers" John Hubbard
2024-03-28  3:34 ` [PATCH 1/2] selftests: break the dependency upon local header files John Hubbard
2024-04-04 18:45   ` David Hildenbrand
2024-03-28  3:34 ` [PATCH 2/2] selftests/mm: fix additional build errors for selftests John Hubbard
2024-04-04 18:46   ` David Hildenbrand
2024-03-28  9:02 ` [PATCH 0/2] Fix selftests/mm build without requiring "make headers" Muhammad Usama Anjum
2024-03-28 17:28   ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834542e1-bb29-49ed-98ee-13a79168819f@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=broonie@kernel.org \
    --cc=david@redhat.com \
    --cc=gtucker@gtucker.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox