From: Vlastimil Babka <vbabka@suse.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Xu <peterx@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
Rik van Riel <riel@surriel.com>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 01/10] mm/mremap: perform some simple cleanups
Date: Thu, 10 Jul 2025 13:09:34 +0200 [thread overview]
Message-ID: <841160e5-4ae2-4e8d-b2dc-aa93f17a5c00@suse.cz> (raw)
In-Reply-To: <067bd59f92c552fa4ed5bc22b051ec086bbc0235.1751865330.git.lorenzo.stoakes@oracle.com>
On 7/7/25 07:27, Lorenzo Stoakes wrote:
> We const-ify the vrm flags parameter to indicate this will never change.
>
> We rename resize_is_valid() to remap_is_valid(), as this function does not
> only apply to cases where we resize, so it's simply confusing to refer to
> that here.
>
> We remove the BUG() from mremap_at(), as we should not BUG() unless we are
> certain it'll result in system instability.
>
> We rename vrm_charge() to vrm_calc_charge() to make it clear this simply
> calculates the charged number of pages rather than actually adjusting any
> state.
>
> We update the comment for vrm_implies_new_addr() to explain that
> MREMAP_DONTUNMAP does not require a set address, but will always be moved.
>
> Additionally consistently use 'res' rather than 'ret' for result values.
>
> No functional change intended.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2025-07-10 11:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 5:27 [PATCH 00/10] mm/mremap: permit mremap() move of multiple VMAs Lorenzo Stoakes
2025-07-07 5:27 ` [PATCH 01/10] mm/mremap: perform some simple cleanups Lorenzo Stoakes
2025-07-10 11:09 ` Vlastimil Babka [this message]
2025-07-07 5:27 ` [PATCH 02/10] mm/mremap: refactor initial parameter sanity checks Lorenzo Stoakes
2025-07-10 11:38 ` Vlastimil Babka
2025-07-07 5:27 ` [PATCH 03/10] mm/mremap: put VMA check and prep logic into helper function Lorenzo Stoakes
2025-07-10 13:10 ` Vlastimil Babka
2025-07-07 5:27 ` [PATCH 04/10] mm/mremap: cleanup post-processing stage of mremap Lorenzo Stoakes
2025-07-10 13:49 ` Vlastimil Babka
2025-07-10 15:28 ` Lorenzo Stoakes
2025-07-07 5:27 ` [PATCH 05/10] mm/mremap: use an explicit uffd failure path for mremap Lorenzo Stoakes
2025-07-07 7:56 ` kernel test robot
2025-07-07 10:13 ` Lorenzo Stoakes
2025-07-07 10:20 ` Lorenzo Stoakes
2025-07-10 14:24 ` Vlastimil Babka
2025-07-07 5:27 ` [PATCH 06/10] mm/mremap: check remap conditions earlier Lorenzo Stoakes
2025-07-10 14:36 ` Vlastimil Babka
2025-07-07 5:27 ` [PATCH 07/10] mm/mremap: move remap_is_valid() into check_prep_vma() Lorenzo Stoakes
2025-07-10 14:44 ` Vlastimil Babka
2025-07-07 5:27 ` [PATCH 08/10] mm/mremap: clean up mlock populate behaviour Lorenzo Stoakes
2025-07-10 14:47 ` Vlastimil Babka
2025-07-07 5:27 ` [PATCH 09/10] mm/mremap: permit mremap() move of multiple VMAs Lorenzo Stoakes
2025-07-09 18:13 ` Liam R. Howlett
2025-07-10 10:41 ` Lorenzo Stoakes
2025-07-11 8:17 ` Mark Brown
2025-07-11 8:22 ` Mark Brown
2025-07-11 8:31 ` Lorenzo Stoakes
2025-07-07 5:27 ` [PATCH 10/10] tools/testing/selftests: extend mremap_test to test multi-VMA mremap Lorenzo Stoakes
2025-07-07 6:12 ` [PATCH 00/10] mm/mremap: permit mremap() move of multiple VMAs Hugh Dickins
2025-07-07 10:31 ` Lorenzo Stoakes
2025-07-07 10:34 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841160e5-4ae2-4e8d-b2dc-aa93f17a5c00@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=peterx@redhat.com \
--cc=pfalcato@suse.de \
--cc=riel@surriel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).