From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6205C001DF for ; Thu, 3 Aug 2023 13:23:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235466AbjHCNXJ (ORCPT ); Thu, 3 Aug 2023 09:23:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236010AbjHCNXB (ORCPT ); Thu, 3 Aug 2023 09:23:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B3BE1712 for ; Thu, 3 Aug 2023 06:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691068938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BNTHDdg/8y8LZ/kyOzqf0q4Up0RQizeLF6R2Nz/km3o=; b=bakDvd5rFfSJup0hV2VK9NCHVEnIQAdCiHOjC11gbBzBWY9bDrlMBL1im1G9HckLOqlE1W yrz3MuBjkWuiR+/AYwXhyv8TyS/TS1Z9whvCNPeuzE50XxavOzRwgfNEXYPkKZSguiAW8p KhnsNfFk5Wd7tCiygo7zf9cDcvMWX0Q= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-NPScIX2sOXmJyFI2l6CJjQ-1; Thu, 03 Aug 2023 09:22:17 -0400 X-MC-Unique: NPScIX2sOXmJyFI2l6CJjQ-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-76cb292df12so24504385a.0 for ; Thu, 03 Aug 2023 06:22:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691068936; x=1691673736; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BNTHDdg/8y8LZ/kyOzqf0q4Up0RQizeLF6R2Nz/km3o=; b=SnWDi13Nx5+uWbOfOEeSX9ugea1ELfmCCvVhrTu4aazWxX9M+3gKyYnbypHi2MQOfx 8dl/m6EDRGfVr4sgow1cYnysARytTBMSJfs3jRJBO+jg2Z52MdZLV2fUfQJVfkORDmw0 HXv2yMfk78UelT3a+LiQnpfY66oTuTospBTrBPXqRoXSCDdWET7GJ50ZPIZsGRqaiXat 1Elx3JLoSxPoXUvKO6j2JviUVjBo+XczgrsWvgOUK3eap2HcfK4r4Z/afGpJqYSjyuDs uaSqWuWhlZVyEPIrYvvfj6p3Rj/jGRqosqJeD6sXqU0/w6QSSr8F084UjBxSKEXUo3Lu ZsVg== X-Gm-Message-State: ABy/qLZbVwwmQD7yNnRGBT3secWPUjiBDKu+RMGutvakXqI8KQuf767U RnY7i4fKpGE5dOqPYMFnm3Msn4/GEXUJQ7zijAcp2C2tSOYGs+IDEo/Grxyh3Y3Q1ukgDpfZegR gAk9Z1pYpXRJvmX3gGA8PUuPjEYOd/D5b/zFb X-Received: by 2002:ac8:7d90:0:b0:400:a9a4:8517 with SMTP id c16-20020ac87d90000000b00400a9a48517mr17924166qtd.4.1691068936709; Thu, 03 Aug 2023 06:22:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqLxU/E4sYmLXRhgaw/0xEY4EC2L0mYwpjXh1EAJzhzXzHaIC/+6zCE6ZmGqdXbhMs9U4PhQ== X-Received: by 2002:ac8:7d90:0:b0:400:a9a4:8517 with SMTP id c16-20020ac87d90000000b00400a9a48517mr17924148qtd.4.1691068936451; Thu, 03 Aug 2023 06:22:16 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-226-226.dyn.eolo.it. [146.241.226.226]) by smtp.gmail.com with ESMTPSA id a26-20020ac8001a000000b00403ad6ec2e8sm6217311qtg.26.2023.08.03.06.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 06:22:16 -0700 (PDT) Message-ID: <8470c431e0930d2ea204a9363a60937289b7fdbe.camel@redhat.com> Subject: Re: [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases From: Paolo Abeni To: Aaron Conole , netdev@vger.kernel.org Cc: dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Pravin B Shelar , Adrian Moreno , Ilya Maximets Date: Thu, 03 Aug 2023 15:22:12 +0200 In-Reply-To: <20230801212226.909249-1-aconole@redhat.com> References: <20230801212226.909249-1-aconole@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, 2023-08-01 at 17:22 -0400, Aaron Conole wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic feature / upcall tests. This is useful to validate > the control path. >=20 > Add the ability to program some of the more common flows with actions. Th= is > can be improved overtime to include regression testing, etc. >=20 > v2->v3: > 1. Dropped support for ipv6 in nat() case > 2. Fixed a spelling mistake in 2/5 commit message. >=20 > v1->v2: > 1. Fix issue when parsing ipv6 in the NAT action > 2. Fix issue calculating length during ctact parsing > 3. Fix error message when invalid bridge is passed > 4. Fold in Adrian's patch to support key masks FTR, this apparently requires an [un?]fairly recent version of pyroute2. Perhaps you could explicitly check for a minimum working version and otherwise bail out (skip) the add-flow tests. Cheers, Paolo