Re: [GIT PULL] nolibc changes for 6.6-rc1

[Shuah Khan <skhan@linuxfoundation.org>]

On 8/15/23 12:48, Willy Tarreau wrote:
> Hello Shuah,
> 
> On Tue, Aug 15, 2023 at 12:13:24PM -0600, Shuah Khan wrote:
>> On 8/15/23 08:39, Shuah Khan wrote:
>>> On 8/15/23 08:35, Willy Tarreau wrote:
>>>> On Tue, Aug 15, 2023 at 08:25:51AM -0600, Shuah Khan wrote:
>>>>>> The following changes since commit 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5:
>>>>>>
>>>>>>      Linux 6.5-rc1 (2023-07-09 13:53:13 -0700)
>>>>>>
>>>>>> are available in the Git repository at:
>>>>>>
>>>>>>      https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git/ 20230806-for-6.6-1
>>>>>>
>>>>>> for you to fetch changes up to d98c1e27e46e47a3ae67e1d048f153598ba82611:
>>>>>>
>>>>>>      tools/nolibc: stackprotector.h: make __stack_chk_init static (2023-08-06 18:44:47 +0200)
>>>>>>
>>>>>
>>>>> Hi Willy,
>>>>>
>>>>> I am sorry for the delay on this. I was traveling last week
>>>>> and getting back to digging myself out of emails.
>>>>
>>>> No problem, thanks for getting back :-)
>>>>
>>>>> I am having trouble pulling this request though:
>>>>>
>>>>> git request-pull https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git/ 20230806-for-6.6-1
>>>>>
>>>>> gives me the following error
>>>>>
>>>>> fatal: Not a valid revision: git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git/
>>>>>
>>>>> I don't see a tag at https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git
>>>>
>>>> Ah sorry for the misunderstanding, that's the branch name, I'll set a
>>>> tag then.
>>>>
>>>
>>> No worries. Could you also share the test you run? I will pull
>>> you request and run tests.
>>>
>>
>> Please send either another pull request or send the tag details.
> 
> I've pushed a tag named 20230815-for-6.6-2 in the repo below:
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git
> 
> Please let me know if you want me to resend a PR.
> 

Pull worked fine and my verify_fixes script failed on the following patches.

Commit: 6c931bf0c732 ("selftests/nolibc: avoid buffer underrun in space printing")
	Fixes tag: Fixes: 8a27526f49f9 ("selftests/nolibc: add EXPECT_PTREQ, EXPECT_PTRNE and EXPECT_PTRER")
	Has these problem(s):
		- Target SHA1 does not exist
Commit: 40f12898b479 ("tools/nolibc/stdio: add setvbuf() to set buffering mode")
	Fixes tag: Fixes: ecb7fe2cd610 ("selftests: line buffer test program's stdout")
	Has these problem(s):
		- Target SHA1 does not exist


Will you be able to add the right commit IDs and resend the pull, so there
are no mistakes if I guess it wrong.

thanks,
-- Shuah