From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63283C433FE for ; Thu, 20 Oct 2022 14:48:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230265AbiJTOsa (ORCPT ); Thu, 20 Oct 2022 10:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230261AbiJTOs1 (ORCPT ); Thu, 20 Oct 2022 10:48:27 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 174161ABA00 for ; Thu, 20 Oct 2022 07:48:25 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id p16so17363768iod.6 for ; Thu, 20 Oct 2022 07:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xyEdOXlSndo4uPk0KrVGETvK2q5egPgUditt+XNxMhY=; b=OR/n+1S46f9Lbwdl/bgTk3mD6NamxcPNZRk3ZIHZ5tJM3eBKfya/KL7bwJ8DBc02bM wy+c1jHW/LJnGfAvqETtwqd8B8V222mpUAPfT8IvsA118iY4NcNnpneGkU19DEfgKab4 xZrpZ01PcEHUdttIvcdgNJq21ocLQIm4MOvhw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xyEdOXlSndo4uPk0KrVGETvK2q5egPgUditt+XNxMhY=; b=SYvcG9JY3jreGx6OGXEesDqudJl1AbpwWa8orMJGJG5MabnU69ZT5xzjswsCMM/v4i I3qyex5Ef2IzTvx8XCFBdeBV6fdjazCS5/5rj9MNqltxV8GhHNhnkMiREotbKDuTYcqZ BKSFX6ZHw2v3cOcuG8xzIx6tlNa2j+tJ9rMWNmYrVSvroRv+rSvXI+IfezemCUxgZbGJ 0Bc/jrn5gMcMfhraQ6REEn5BSVty1hfMRSyOrslT73BDDZNdeJQzjpDN2IjWo17rLt2u 6MS7yM7QFo0mbYAF04YCOsG+sJY0b9dimGdaNe6G3/3q/G6ovly5wbQVwdCpEKio0AT8 yE/w== X-Gm-Message-State: ACrzQf0Hs2WARDh2DRc8O1Ic6CwGklqs8mvbQA3m1+RiJi6FaNOqn26r LLU3/q+J6p47jCQU3h7un7CDEuS4PCeQhQ== X-Google-Smtp-Source: AMsMyM6he7Y1M5zvSAzivZb5Bof1fIpsetVQw2snw3rRtp0M4glmp6g2HZ+ju3wV9Zth78xTjuZsUw== X-Received: by 2002:a05:6602:134f:b0:6a4:cd04:7842 with SMTP id i15-20020a056602134f00b006a4cd047842mr10252219iov.172.1666277304428; Thu, 20 Oct 2022 07:48:24 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id m21-20020a023c15000000b0035a40af60fcsm3350204jaa.86.2022.10.20.07.48.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 07:48:23 -0700 (PDT) Message-ID: <8612a1aa-4920-e069-b252-137c51c6b04f@linuxfoundation.org> Date: Thu, 20 Oct 2022 08:48:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1] selftests: Use optional USERCFLAGS and USERLDFLAGS Content-Language: en-US To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Cc: Anders Roxell , Guillaume Tucker , Mark Brown , linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, stable@vger.kernel.org, Shuah Khan References: <20220909103901.1503436-1-mic@digikod.net> <80053942-2e24-b31a-8795-1f81d4b52e67@digikod.net> From: Shuah Khan In-Reply-To: <80053942-2e24-b31a-8795-1f81d4b52e67@digikod.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/20/22 08:17, Mickaël Salaün wrote: > Hi Shuah, what do you think about this patch? > Thanks for the ping. > On 09/09/2022 12:39, Mickaël Salaün wrote: >> This change enables to extend CFLAGS and LDFLAGS from command line, e.g. >> to extend compiler checks: make USERCFLAGS=-Werror USERLDFLAGS=-static >> >> USERCFLAGS and USERLDFLAGS are documented in >> Documentation/kbuild/makefiles.rst and Documentation/kbuild/kbuild.rst >> >> This should be backported (down to 5.10) to improve previous kernel >> versions testing as well. >> >> Cc: Shuah Khan >> Cc: stable@vger.kernel.org >> Signed-off-by: Mickaël Salaün >> Link: https://lore.kernel.org/r/20220909103901.1503436-1-mic@digikod.net >> --- >>   tools/testing/selftests/lib.mk | 5 +++++ >>   1 file changed, 5 insertions(+) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index d44c72b3abe3..da47a0257165 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -119,6 +119,11 @@ endef >>   clean: >>       $(CLEAN) >> +# Enables to extend CFLAGS and LDFLAGS from command line, e.g. >> +# make USERCFLAGS=-Werror USERLDFLAGS=-static >> +CFLAGS += $(USERCFLAGS) >> +LDFLAGS += $(USERLDFLAGS) >> + >>   # When make O= with kselftest target from main level >>   # the following aren't defined. >>   # >> >> base-commit: 7e18e42e4b280c85b76967a9106a13ca61c16179 Sorry for the delay. Looks good to me. I will apply to next to get some soak time and get this into 6.2. thanks, -- Shuah