From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D07F613A3F7; Thu, 29 May 2025 11:48:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748519288; cv=none; b=ipKPUqjzTqzNYjCFPjN/umqMLMf0fZD1RWD7aszNNkKWNTNDLWBnYr+phGBbE49h7vSe/gfHcrtHLb1p/n9Lb1z0qdj/VCAmfKC+1TPy3palcMQ6slPkmZ08jOj1aeYm+320Ayqcewck4OebTzKIxiUbbkuEfTc8fj3TUBWfM2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748519288; c=relaxed/simple; bh=P7souVYNDTCPcO1CXMYGoclN1/o/FL5aiEHy0SwZIR4=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=kjCi8wpm31DepW38Z5UhDhEiQhE2KbmtMSi0cL0wwMShbap1tts3cKmWCpvM0xruSErfd8cZRm8+7yC8eKP+B764258p0d53paa1alVgEdrGe/Rbf0KxXtVCdmR7tQFOpCWbmM/bgwEt4yr7sa6ACYjBVrnMMSmTI8Ospf7LsBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MsQQPjxS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MsQQPjxS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33FD2C4CEE7; Thu, 29 May 2025 11:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748519288; bh=P7souVYNDTCPcO1CXMYGoclN1/o/FL5aiEHy0SwZIR4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MsQQPjxSX+4DmYyhHGCpSURnuD0cmkl4qu3BbZUy07xbxOHBZySYUKM1CNg1Impvd jFhl1sras34WV5jDj2ARxFbselPnvdCeGBX/0eI3BxG4PiyVx1SF7vzJyCzS8/ycj7 eWasMHhhL1/SsYfthIZpZfaeZi2TJiJ39y14cuMYeQh4h7KM8hNbUP7aowkQt6vEAr MRO4II492FsEbgtuY8bUWwQyWnhssfZR8sLVqQbbdeGUZQhFUylja5L081wmJfHUOJ zGzEmOcB/Cx+/YgfA8kD0lE0IMqIZyyqwE79fO3E0GntYoQXkNX4BneWixatifPs5I cQKUKuyc2tWRQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uKbjx-001YLY-Ia; Thu, 29 May 2025 12:48:05 +0100 Date: Thu, 29 May 2025 12:48:05 +0100 Message-ID: <86a56veiyy.wl-maz@kernel.org> From: Marc Zyngier To: Ganapatrao Kulkarni Cc: Eric Auger , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, seanjc@google.com, darren@os.amperecomputing.com Subject: Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests In-Reply-To: <7bf7bd52-7553-42a7-afdb-a5e95f8699b5@os.amperecomputing.com> References: <20250512105251.577874-1-gankulkarni@os.amperecomputing.com> <92c7e99c-5574-422c-92f1-62d5cde58fec@redhat.com> <7bf7bd52-7553-42a7-afdb-a5e95f8699b5@os.amperecomputing.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: gankulkarni@os.amperecomputing.com, eauger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, seanjc@google.com, darren@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 29 May 2025 11:29:58 +0100, Ganapatrao Kulkarni wrote: > > > Hi Eric, > > On 5/28/2025 6:58 PM, Eric Auger wrote: > > Hi Ganapatrao, > > > > On 5/12/25 12:52 PM, Ganapatrao Kulkarni wrote: > >> This patch series makes the selftest work with NV enabled. The guest code > >> is run in vEL2 instead of EL1. We add a command line option to enable > >> testing of NV. The NV tests are disabled by default. > > > > For commodity, I would add in the coverletter that for all tests > > enhanced with vEL2 testing "-g 1" option shall be added to force that mode. > > Sure, will do. > > > > > I don't really get how you chose tests capable to run at vEL2 and > > excluded others? Wouldn't it make sense to have a way to run all tests > > in either mode? > There is no selection as such. I have worked on around 50% of the tests and sent for the early review. > Yes, almost all tests can/should run in vEL2 except few. Define EL2. You are so far assuming a E2H RES1 guest, and I don't see anything that is even trying E2H RES0. After all the complaining that E2H0 wasn't initially supported, this is a bit... disappointing. Also, running EL2 is the least of our worries, because that's pretty easy to deal with. It is running at EL1/0 when EL2 is present that is interesting, and I see no coverage on that front. M. -- Without deviation from the norm, progress is not possible.