From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B6A1EA8F; Mon, 13 May 2024 08:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715588880; cv=none; b=NB+LMrDbICuZAdaTyCGQziosp7JTr370NO2u8F6dT5RkhHbQAoGCBbc28+HQwgK5aTDoyPfYwSwCTfURVDu/uL1dToYfgq13Ji9MlzJ6+QF0lc1dhVxYbFiq76RvsV4IVPmTPgMhtFj5r5ixNekTpX1BFkKaY/9Aq8UFR1af4Kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715588880; c=relaxed/simple; bh=KvcnjCyjTkeTtXOV8cNt7JFpqH6iplwYmt5RghSUA4E=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=cIfIL0eAP8jSw3S7BDaYI3Ed9BTGagdf/9587vrZBdx0G3PKxyxMFckqLooJB/d9OUxJ0YbwQAs4vbpXv0paILNmoryn3b5I7hBYhxUWtwvzrKlV00hYXLWkb6SuC/wdgesPbeWiFD1K5bqkPxeWPxFfYBFJuXx+KT+Gaseqbmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ruLKaRup; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ruLKaRup" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51D66C113CC; Mon, 13 May 2024 08:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715588880; bh=KvcnjCyjTkeTtXOV8cNt7JFpqH6iplwYmt5RghSUA4E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ruLKaRup83lDJ1pnNLz4iugrEQJ1No9G22zd9XXPU1JLSc2oa9bTOlyGMyU9bgO9d /03IrvzoHFAbJmV141tyaUbGkOSPH/kFMKu6xosLfiTIUwH/BRwrKD87ZU9b/1s11k 7jkKt/Ynnwcj25e0Q7sTAqmYjFlo+GoPOZLGxRg9njdOgpjMwAye/+IBz4/QredsCM aEJKL6TMJlFflcgmtVVVoUxdAqkdOdIC3809gaqZxLE3c+lCZV8MpYxljU5t8DYc9S tyqJcBs3KZLxz8Qu+0dUxLTEJuKjlPH+LDj2t+q4sF66kfHeYcLsRQpTRb9hODmT1c WGal839zOIrQg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s6R2L-00ClXb-OX; Mon, 13 May 2024 09:27:57 +0100 Date: Mon, 13 May 2024 09:27:57 +0100 Message-ID: <86zfsum7zm.wl-maz@kernel.org> From: Marc Zyngier To: Pavel Machek Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Oliver Upton , pbonzini@redhat.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF In-Reply-To: References: <20240507231231.394219-1-sashal@kernel.org> <20240507231231.394219-8-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pavel@denx.de, sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, oliver.upton@linux.dev, pbonzini@redhat.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 13 May 2024 09:20:38 +0100, Pavel Machek wrote: > > Hi! > > > Assert that accesses to a non-existent vgic-v2 CPU interface > > consistently fail across the various KVM device attr ioctls. This also > > serves as a regression test for a bug wherein KVM hits a NULL > > dereference when the CPUID specified in the ioctl is invalid. > > > > Note that there is no need to print the observed errno, as TEST_ASSERT() > > will take care of it. > > I don't think this fixes the bug... and thus we should not need it in > stable. Given that this goes together with an actually bug fix that was backported, it *is*, for once, actually useful to have it in stable. M. -- Without deviation from the norm, progress is not possible.