From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00768EB64DD for ; Thu, 13 Jul 2023 06:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbjGMGId (ORCPT ); Thu, 13 Jul 2023 02:08:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbjGMGIc (ORCPT ); Thu, 13 Jul 2023 02:08:32 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C322B1BC6; Wed, 12 Jul 2023 23:08:31 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 60D741F8D9; Thu, 13 Jul 2023 06:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689228510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LQjoMOuDYWVyTBw8okmanAfIbcPTrQ1gl3sbWKCUhxY=; b=dXrwWQhMGcSaIhgFB3ZwGALWDt+omPHExLwdA0WE+EtnfRANm34FO5HMLxboq2ltsVweMi Dx1JeRQkaLZUwtscJr+IaFiies7a6gZabZirJzbmRR0OlglOCdzFbmrAkhyXlhrQHm3wnq c5F6pQZ+dvU5yg1zV8hsX7DuOx4If3M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689228510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LQjoMOuDYWVyTBw8okmanAfIbcPTrQ1gl3sbWKCUhxY=; b=Z4SirNNwXt4OQsKULKDcn4lRQ0PduBGfu7fDJ8kJ+dBfF2/Rv8JRLD32QJIQ9azxu+GY3L hvXnKSO0lraYG8Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 24259138ED; Thu, 13 Jul 2023 06:08:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YPLaB96Ur2TrOAAAMHmgww (envelope-from ); Thu, 13 Jul 2023 06:08:30 +0000 Date: Thu, 13 Jul 2023 08:08:29 +0200 Message-ID: <871qhcgx7m.wl-tiwai@suse.de> From: Takashi Iwai To: Colin Ian King Cc: Ivan Orlov , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shuah Khan , alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] selftests: ALSA: Fix fclose on an already fclosed file pointer In-Reply-To: <20230712140122.457206-1-colin.i.king@gmail.com> References: <20230712140122.457206-1-colin.i.king@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, 12 Jul 2023 16:01:22 +0200, Colin Ian King wrote: > > In the case where a sysfs file cannot be opened the error return path > fcloses file pointer fpl, however, fpl has already been closed in the > previous stanza. Fix the double fclose by removing it. > > Fixes: 10b98a4db11a ("selftests: ALSA: Add test for the 'pcmtest' driver") > Signed-off-by: Colin Ian King Thanks, applied. Takashi