Re: [PATCH v6 0/4] fat: add support for the renameat2 RENAME_EXCHANGE flag

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Javier Martinez Canillas <javierm@redhat.com> writes:

> The series adds support for the renameat2 system call RENAME_EXCHANGE flag
> (which allows to atomically replace two paths) to the vfat filesystem code.
>
> There are many use cases for this, but we are particularly interested in
> making possible for vfat filesystems to be part of OSTree [0] deployments.
>
> Currently OSTree relies on symbolic links to make the deployment updates
> an atomic transactional operation. But RENAME_EXCHANGE could be used [1]
> to achieve a similar level of robustness when using a vfat filesystem.
>
> Patch #1 is just a preparatory patch to introduce the RENAME_EXCHANGE
> support, patch #2 moves some code blocks in vfat_rename() to a set of
> helper functions, that can be reused by tvfat_rename_exchange() that's
> added by patch #3 and finally patch #4 adds some kselftests to test it.
>
> This is a v6 that addresses issues pointed out in v5:
>
> https://lkml.org/lkml/2022/6/9/361
>
> [0]: https://github.com/ostreedev/ostree
> [1]: https://github.com/ostreedev/ostree/issues/1649

Looks good this patchset.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>