From mboxrd@z Thu Jan 1 00:00:00 1970 From: bauerman at linux.vnet.ibm.com (Thiago Jung Bauermann) Date: Wed, 28 Mar 2018 20:51:42 -0300 Subject: [PATCH v12 07/22] selftests/vm: fixed bugs in pkey_disable_clear() In-Reply-To: <34fd1ae9-9697-ac6c-d6bc-7c25b4515a25@intel.com> References: <1519264541-7621-1-git-send-email-linuxram@us.ibm.com> <1519264541-7621-8-git-send-email-linuxram@us.ibm.com> <87muys3p2v.fsf@morokweng.localdomain> <34fd1ae9-9697-ac6c-d6bc-7c25b4515a25@intel.com> Message-ID: <878tabvjw1.fsf@morokweng.localdomain> Dave Hansen writes: > On 03/28/2018 01:47 PM, Thiago Jung Bauermann wrote: >>>> if (flags) >>>> - assert(rdpkey_reg() > orig_pkey_reg); >>>> + assert(rdpkey_reg() < orig_pkey_reg); >>>> } >>>> >>>> void pkey_write_allow(int pkey) >>> This seems so horribly wrong that I wonder how it worked in the first >>> place. Any idea? >> The code simply wasn't used. pkey_disable_clear() is called by >> pkey_write_allow() and pkey_access_allow(), but before this patch series >> nothing called either of these functions. >> > > Ahh, that explains it. Can that get stuck in the changelog, please? Yes, will be in the next version. -- Thiago Jung Bauermann IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: bauerman@linux.vnet.ibm.com (Thiago Jung Bauermann) Date: Wed, 28 Mar 2018 20:51:42 -0300 Subject: [PATCH v12 07/22] selftests/vm: fixed bugs in pkey_disable_clear() In-Reply-To: <34fd1ae9-9697-ac6c-d6bc-7c25b4515a25@intel.com> References: <1519264541-7621-1-git-send-email-linuxram@us.ibm.com> <1519264541-7621-8-git-send-email-linuxram@us.ibm.com> <87muys3p2v.fsf@morokweng.localdomain> <34fd1ae9-9697-ac6c-d6bc-7c25b4515a25@intel.com> Message-ID: <878tabvjw1.fsf@morokweng.localdomain> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180328235142.j--u3XT9X4Qr5pdLYbRkfpaOn96Na8-2mIFa_h-BGO4@z> Dave Hansen writes: > On 03/28/2018 01:47 PM, Thiago Jung Bauermann wrote: >>>> if (flags) >>>> - assert(rdpkey_reg() > orig_pkey_reg); >>>> + assert(rdpkey_reg() < orig_pkey_reg); >>>> } >>>> >>>> void pkey_write_allow(int pkey) >>> This seems so horribly wrong that I wonder how it worked in the first >>> place. Any idea? >> The code simply wasn't used. pkey_disable_clear() is called by >> pkey_write_allow() and pkey_access_allow(), but before this patch series >> nothing called either of these functions. >> > > Ahh, that explains it. Can that get stuck in the changelog, please? Yes, will be in the next version. -- Thiago Jung Bauermann IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html