From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D721AC6FD20 for ; Fri, 24 Mar 2023 06:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbjCXGu7 (ORCPT ); Fri, 24 Mar 2023 02:50:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbjCXGu5 (ORCPT ); Fri, 24 Mar 2023 02:50:57 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 147E021979 for ; Thu, 23 Mar 2023 23:50:57 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1F061339D0; Fri, 24 Mar 2023 06:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679640655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NxyX9q1VYVSFzYPMQaaKPjGrb1QDBq295V4jkkU49IY=; b=rCUi29E2/NT6lntN1p6jq6ObXr/jOE+j8IljXyD7/G+eEVOxpRWRT9U8wJOn11jUJWoB5i FoOiMiJtv4Ib8SyxdLHL5g2nxIgWv/33A42zC90OgygYgDy8LW6yEyJzHWjeUyf/27i+7d ZijIAXorRvzH3GiG0ds0ezefJZ3zBXo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679640655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NxyX9q1VYVSFzYPMQaaKPjGrb1QDBq295V4jkkU49IY=; b=bCxQiSTOMwt/7tpEJF/Dsrch7G8gETK9f2Wx4LHCAx7QSsNxHmWcXhFshqkD3P8gd/PBLz Rz5tGhdkFREy5/BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EDB5F133E5; Fri, 24 Mar 2023 06:50:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z9NOOU5IHWQtTAAAMHmgww (envelope-from ); Fri, 24 Mar 2023 06:50:54 +0000 Date: Fri, 24 Mar 2023 07:50:54 +0100 Message-ID: <87a602hcc1.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Jaroslav Kysela , Takashi Iwai , Shuah Khan , alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] kselftest/alsa - pcm-test: Don't include diagnostic message in test name In-Reply-To: <20230323-alsa-pcm-test-names-v1-1-8be67a8885ff@kernel.org> References: <20230323-alsa-pcm-test-names-v1-1-8be67a8885ff@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, 23 Mar 2023 19:48:28 +0100, Mark Brown wrote: > > When reporting errors or skips we currently include the diagnostic message > indicating why we're failing or skipping. This isn't ideal since KTAP > defines the entire print as the test name, so if there's an error then test > systems won't detect the test as being the same one as a passing test. Move > the diagnostic to a separate ksft_print_msg() to avoid this issue, the test > name part will always be the same for passes, fails and skips and the > diagnostic information is still displayed. > > Signed-off-by: Mark Brown Thanks, applied now. Takashi