From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7DCC0018C for ; Mon, 7 Dec 2020 20:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29A062396D for ; Mon, 7 Dec 2020 20:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbgLGUKU (ORCPT ); Mon, 7 Dec 2020 15:10:20 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:12618 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbgLGUKU (ORCPT ); Mon, 7 Dec 2020 15:10:20 -0500 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B7K2LJM099528; Mon, 7 Dec 2020 15:09:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=nN3vw7s91F5b2/SYNKHIo2K2amQAL+DaevfDPQsVXLc=; b=q7UJIfmOxwwqcSDtAZY43rasSXcRgE4bDMCArPVfCgK5xadK0KQbvtmLlhfEKfvSUqX5 gEGGBjKQAnLtNeSVzC/TXDmYJLnz8RECExEXrfs+zbmTQpkmuX6WZ6vE1VLQLpflNGg2 wIXpq/ncLHfiDznGGFzQ5guOsbqS7vsOXeU2SoP96b3i8YsPxbXQoFdgCiFayYZMLBw+ N3Q2yY7qUpZGMxEd6KJz1EPaZYfwUOUGQtsc2dF1U/D3E84yI8dixR0/39KSz23DxnvT 4aOUweYZY/Sc+M2tLQ8N1fulfIWxe/G4xjxZwbqo6+BfTg40uzMZjvEpD8fwIWxIL/Yl 9w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 358r4v86fk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Dec 2020 15:09:38 -0500 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0B7K2jW3100548; Mon, 7 Dec 2020 15:09:37 -0500 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com with ESMTP id 358r4v86dp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Dec 2020 15:09:37 -0500 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0B7K3iia020544; Mon, 7 Dec 2020 20:09:34 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06fra.de.ibm.com with ESMTP id 3581fhhenj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Dec 2020 20:09:34 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0B7K9Vdq63635890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Dec 2020 20:09:31 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 81C3211C04A; Mon, 7 Dec 2020 20:09:31 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 11FF311C04C; Mon, 7 Dec 2020 20:09:31 +0000 (GMT) Received: from oc7455500831.ibm.com (unknown [9.171.4.19]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 7 Dec 2020 20:09:30 +0000 (GMT) Subject: Re: [PATCH v4] self_tests/kvm: sync_regs test for diag318 To: Collin Walling , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com, cohuck@redhat.com, pbonzini@redhat.com, imbrenda@linux.ibm.com References: <20201207154125.10322-1-walling@linux.ibm.com> <2ea47a0e-40fb-35bc-5819-63a9e7b2ec59@de.ibm.com> From: Christian Borntraeger Message-ID: <87bf5fb7-26bf-f757-1efa-d2a49bde5188@de.ibm.com> Date: Mon, 7 Dec 2020 21:09:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2020-12-07_16:2020-12-04,2020-12-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012070129 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 07.12.20 21:06, Collin Walling wrote: > On 12/7/20 2:32 PM, Christian Borntraeger wrote: >> On 07.12.20 16:41, Collin Walling wrote: >>> The DIAGNOSE 0x0318 instruction, unique to s390x, is a privileged call >>> that must be intercepted via SIE, handled in userspace, and the >>> information set by the instruction is communicated back to KVM. >>> >>> To test the instruction interception, an ad-hoc handler is defined which >>> simply has a VM execute the instruction and then userspace will extract >>> the necessary info. The handler is defined such that the instruction >>> invocation occurs only once. It is up to the caller to determine how the >>> info returned by this handler should be used. >>> >>> The diag318 info is communicated from userspace to KVM via a sync_regs >>> call. This is tested During a sync_regs test, where the diag318 info is >>> requested via the handler, then the info is stored in the appropriate >>> register in KVM via a sync registers call. >>> >>> If KVM does not support diag318, then the tests will print a message >>> stating that diag318 was skipped, and the asserts will simply test >>> against a value of 0. >>> >>> Signed-off-by: Collin Walling >> >> Interestingly enough, this testcase actually trigger a bug: >> While we gracefully handle this (no crash) >> debugfs: Directory 'kvm-200206' with parent 's390dbf' already present! >> is certainly not ideal.... >> > > Odd... I wonder what triggered this behavior? > > I run my tests with a simple command: > > make summary=0 TARGETS=kvm kselftest > > This must have something to do with spinning up another VM to get the > diag318 data. I think if I have the sync_regs test call the diag handler > first, and then have the sync regs create a VM, that might solve that > issue... Yes, the s390dbf code will try to create a file named kvm-%pid. With 2 VMs the 2nd one fails. Luckily the kvm will be created anyway and also the shutdown seems to be fine, still.... > > May I ask how you encountered this bug so I may replicate in on my end? I just did make TARGETS=kvm selftests and then the error is on dmesg.