From: Jakub Sitnicki <jakub@cloudflare.com>
To: patchwork-bot+netdevbpf@kernel.org
Cc: Geliang Tang <geliang@kernel.org>,
andrii@kernel.org, eddyz87@gmail.com, mykolal@fb.com,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, shuah@kernel.org,
tanggeliang@kylinos.cn, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix prog numbers in test_sockmap
Date: Wed, 22 May 2024 10:17:51 +0200 [thread overview]
Message-ID: <87bk4yxntc.fsf@cloudflare.com> (raw)
In-Reply-To: <171631563033.25358.8200564796951629702.git-patchwork-notify@kernel.org> (patchwork-bot's message of "Tue, 21 May 2024 18:20:30 +0000")
On Tue, May 21, 2024 at 06:20 PM GMT, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to bpf/bpf-next.git (master)
> by Andrii Nakryiko <andrii@kernel.org>:
>
> On Fri, 17 May 2024 14:21:46 +0800 you wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> bpf_prog5 and bpf_prog7 are removed from progs/test_sockmap_kern.h in
>> commit d79a32129b21 ("bpf: Selftests, remove prints from sockmap tests"),
>> now there are only 9 progs in it, not 11:
>>
>> SEC("sk_skb1")
>> int bpf_prog1(struct __sk_buff *skb)
>> SEC("sk_skb2")
>> int bpf_prog2(struct __sk_buff *skb)
>> SEC("sk_skb3")
>> int bpf_prog3(struct __sk_buff *skb)
>> SEC("sockops")
>> int bpf_sockmap(struct bpf_sock_ops *skops)
>> SEC("sk_msg1")
>> int bpf_prog4(struct sk_msg_md *msg)
>> SEC("sk_msg2")
>> int bpf_prog6(struct sk_msg_md *msg)
>> SEC("sk_msg3")
>> int bpf_prog8(struct sk_msg_md *msg)
>> SEC("sk_msg4")
>> int bpf_prog9(struct sk_msg_md *msg)
>> SEC("sk_msg5")
>> int bpf_prog10(struct sk_msg_md *msg)
>>
>> [...]
>
> Here is the summary with links:
> - [bpf-next] selftests/bpf: Fix prog numbers in test_sockmap
> https://git.kernel.org/bpf/bpf-next/c/6c8d7598dfed
>
> You are awesome, thank you!
We don't need prog_types and attach_types at all.
I was too late too comment so here's a patch to address that:
https://lore.kernel.org/bpf/20240522080936.2475833-1-jakub@cloudflare.com/
prev parent reply other threads:[~2024-05-22 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 6:21 [PATCH bpf-next] selftests/bpf: Fix prog numbers in test_sockmap Geliang Tang
2024-05-21 18:20 ` patchwork-bot+netdevbpf
2024-05-22 8:17 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk4yxntc.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=geliang@kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox