From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A206AC28CF5 for ; Wed, 26 Jan 2022 13:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231904AbiAZNFG (ORCPT ); Wed, 26 Jan 2022 08:05:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231691AbiAZNFF (ORCPT ); Wed, 26 Jan 2022 08:05:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58A8AC06161C for ; Wed, 26 Jan 2022 05:05:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E953461A6D for ; Wed, 26 Jan 2022 13:05:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56E5CC340E3; Wed, 26 Jan 2022 13:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643202304; bh=aRSD0q8QbNlli6eHa3NnFpfLKDi1bW68kqnD1RqIhjc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sv520NMzkWC3oJ5r3ashYHWDr0wfjkTiKCWfmcOVuri48k8f1ER/s7HLWwmsjUVJw AfTExaG+VhAnGAMO2p4UTRltLcTuB/bDbXYitLw4a7bP83oY5gUDVlwg2QYItBgC9O XJNcww3cNFzNLUTQGLJ0CrcZS7lkm7+Vjg/3jFCx6Uk/PMp2hgTAUPnapvwgy5nPnm jgAKClyRGQadVZnamG+uxCrggvf1+ILfZ9kK97iiGjsFUNKG5iSgdu2qoxHQus8ESn r5f6e1Zbdo2Q0RE3Fsv4I9ReSZ3LtfP9AxVXTHEY2348rtKheZmT1KG1QYx1gBZ9W3 sAQnc8H/QjLLg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nChyw-003DX9-9C; Wed, 26 Jan 2022 13:05:02 +0000 Date: Wed, 26 Jan 2022 13:05:01 +0000 Message-ID: <87czke7ima.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Shuah Khan , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] kselftest: kvm/arm64: Skip tests if we can't create a vgic-v3 In-Reply-To: References: <20220125192851.3907611-1-broonie@kernel.org> <87h79q7tln.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, shuah@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, 26 Jan 2022 12:52:22 +0000, Mark Brown wrote: > > On Wed, Jan 26, 2022 at 09:07:48AM +0000, Marc Zyngier wrote: > > Mark Brown wrote: > > > > /* Distributor setup */ > > > - gic_fd = kvm_create_device(vm, KVM_DEV_TYPE_ARM_VGIC_V3, false); > > > + gic_fd = kvm_create_device(vm, KVM_DEV_TYPE_ARM_VGIC_V3, true); > > > So you now only test whether it is possible to create a virtual GICv3, > > but don't actually create it. How does this work? > > Oh, that's rather obscure in the API - so the file descriptor returned > if the test flag is specified can't actually be used? No file descriptor is returned at all from the kernel, so you should always get -1 as populated by kvm_create_device(). See virt/kvm/kvm_main.c::kvm_ioctl_create_device(). M. -- Without deviation from the norm, progress is not possible.