linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Ben Zong-You Xie <ben717@andestech.com>
Cc: mingo@redhat.com, peterz@infradead.org, dvhart@infradead.org,
	dave@stgolabs.net, andrealmeid@igalia.com, shuah@kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	tim609@andestech.com, Ben Zong-You Xie <ben717@andestech.com>,
	Cynthia Huang <cynthia@andestech.com>
Subject: Re: [PATCH v2] selftests: futex: define SYS_futex on 32-bit architectures with 64-bit time_t
Date: Sun, 06 Jul 2025 10:19:44 +0200	[thread overview]
Message-ID: <87ldp1spcv.ffs@tglx> (raw)
In-Reply-To: <20250627090812.937939-1-ben717@andestech.com>

On Fri, Jun 27 2025 at 17:08, Ben Zong-You Xie wrote:

> glibc does not define SYS_futex for 32-bit architectures using 64-bit

Kinda. The kernel does not provide sys_futex() on 32-bit architectures,
which do not support 32-bit time representations. As a consequence glibc
obviously cannot define SYS_futex either.

> time_t e.g. riscv32, therefore this test fails to compile since it does not
> find SYS_futex in C library headers. Define SYS_futex as SYS_futex_time64
> in this situation to ensure successful compilation and compatibility.
>
> Signed-off-by: Cynthia Huang <cynthia@andestech.com>
> Signed-off-by: Ben Zong-You Xie <ben717@andestech.com>
> ---
> Changes since v1:
>   - Fix the SOB chain

Mostly.

If Cynthia authored the patch, then this still lacks a 'From: Cynthia...'
at the top of the change log so she can be identified as the
author. Otherwise tooling will attribute autorship to you.

Thanks,

        tglx

      parent reply	other threads:[~2025-07-06  8:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27  9:08 [PATCH v2] selftests: futex: define SYS_futex on 32-bit architectures with 64-bit time_t Ben Zong-You Xie
2025-06-28  9:28 ` Muhammad Usama Anjum
2025-07-06  8:19 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldp1spcv.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=andrealmeid@igalia.com \
    --cc=ben717@andestech.com \
    --cc=cynthia@andestech.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=tim609@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).