From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB6FC64EC4 for ; Wed, 8 Mar 2023 05:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbjCHFfB (ORCPT ); Wed, 8 Mar 2023 00:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbjCHFfA (ORCPT ); Wed, 8 Mar 2023 00:35:00 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2442C8C824 for ; Tue, 7 Mar 2023 21:34:59 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CBAF91FE3B; Wed, 8 Mar 2023 05:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678253697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VawpRHzYcbBuCvOj+J7KDDgL3Eo0II1MhJl1pVKzdm8=; b=h3pmL8X8OTP6WbmF6U5g+YzvWLWbDwXHE9Jqokr43MNGfIkUykJgAGVbLoMze//gtYmaQf KTqmPYtUxBZsAvzoO5IttX4Qdw0sA1BjuAvPzVUk9ib7EEQfMEZYf9dC7Glud2OF/0DmK2 2kZ5gC5H0/HhUvtBSWU/n1hJHWKx/nc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678253697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VawpRHzYcbBuCvOj+J7KDDgL3Eo0II1MhJl1pVKzdm8=; b=01Ia7HSRXXzghFyQEU0TrDjEoXBJBrPHFLsQiVn9oMITpc/vLW2rHwYpjsHDYulrNiQS4t o6sjuRSoH+EqLPCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9C6B513596; Wed, 8 Mar 2023 05:34:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hlV6JYEeCGQcPgAAMHmgww (envelope-from ); Wed, 08 Mar 2023 05:34:57 +0000 Date: Wed, 08 Mar 2023 06:34:57 +0100 Message-ID: <87mt4niz5q.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Jaroslav Kysela , Takashi Iwai , Shuah Khan , alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] kselftest/alsa - mixer-test: Don't fail tests if we can't restore default In-Reply-To: <20230224-alsa-mixer-test-restore-invalid-v1-1-454f0f1f2c4b@kernel.org> References: <20230224-alsa-mixer-test-restore-invalid-v1-1-454f0f1f2c4b@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, 06 Mar 2023 15:20:03 +0100, Mark Brown wrote: > > If a control has an invalid default value then we might fail to set it > when restoring the default value after our write tests, for example due to > correctly implemented range checks in put() operations. Currently this > causes us to report the tests we were running as failed even when the > operation we were trying to test is successful, making it look like there > are problems where none really exist. Stop doing this, only reporting any > issues during the actual test. > > We already have validation for the initial readback being in spec and for > writing the default value back so failed tests will be reported for these > controls, and we log an error on the operation that failed when we write so > there will be a diagnostic warning the user that there is a problem. > > Signed-off-by: Mark Brown Applied to for-next branch. Thanks. Takashi