From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3388DC6FD20 for ; Fri, 24 Mar 2023 09:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbjCXJpw (ORCPT ); Fri, 24 Mar 2023 05:45:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230377AbjCXJpa (ORCPT ); Fri, 24 Mar 2023 05:45:30 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04FA02B2AD for ; Fri, 24 Mar 2023 02:44:40 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A1F5C21A31; Fri, 24 Mar 2023 09:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679651070; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=33uKntMu11Vs+rboUdjOFUJmtl0bbLHgVVH4VTx9L3k=; b=nFWvQYBnMNmQdUv88hkxq1drzzuah+misGcyQrlAA0wI8dfaO4tIlV+dDJaiwOqgnduiZ8 LsHzdK5uXh31l/FHT5uRBqtThoRzRZcFZxjvb8RbFfaJto93Sdwc2dzCe6mM/DKm/Sy/Im 6xGJLzl0L2GiwHBbyQ+X4EgrRQGN/Jk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679651070; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=33uKntMu11Vs+rboUdjOFUJmtl0bbLHgVVH4VTx9L3k=; b=tYPCC8DMB2vXmka8n+YkLrk7UmKJcH5FPYi0RlU2juuWL6ro4X8SR9YH7F51cduY5L3XQp x35IOwdsna35NFBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 77081138ED; Fri, 24 Mar 2023 09:44:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8gZEHP5wHWS2KAAAMHmgww (envelope-from ); Fri, 24 Mar 2023 09:44:30 +0000 Date: Fri, 24 Mar 2023 10:44:29 +0100 Message-ID: <87r0te5vr6.wl-tiwai@suse.de> From: Takashi Iwai To: Alexander Heinrich Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] kselftest/alsa: Fix -Wformat compiler warnings In-Reply-To: <87sfdu5vsl.wl-tiwai@suse.de> References: <20230324092806.363253-1-hallo@alexanderheinrich.de> <87sfdu5vsl.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, 24 Mar 2023 10:43:38 +0100, Takashi Iwai wrote: > > On Fri, 24 Mar 2023 10:28:06 +0100, > Alexander Heinrich wrote: > > > > I noticed some -Wformat compiler warnings in pcm-test.c while building > > kselftest, fix them by using the same types for format specifier and arguments. > > > > Signed-off-by: Alexander Heinrich > > Those variables (rates, channels, etc) should be rather int instead of > long, as these are not 64bit parameters on 32bit archs. > On top of that, the whole '%l' prefix and cast should be dropped. > > The only concern is the string to int conversion, and this should be > checked carefully, but other than that, it must be straightforward. > > Care to work on that way? ... and the code has been already changed meanwhile. Please work on for-next branch of my sound.git tree. thanks, Takashi