From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Ignat Korchagin <ignat@cloudflare.com>,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
Hangbin Liu <liuhangbin@gmail.com>, Yi Chen <yiche@redhat.com>
Subject: Re: [PATCH net 2/2] selftests: udpgro: no need to load xdp for gro
Date: Wed, 14 Aug 2024 12:19:39 +0200 [thread overview]
Message-ID: <87v803csp0.fsf@toke.dk> (raw)
In-Reply-To: <20240814075758.163065-3-liuhangbin@gmail.com>
Hangbin Liu <liuhangbin@gmail.com> writes:
> After commit d7db7775ea2e ("net: veth: do not manipulate GRO when using
> XDP"), there is no need to load XDP program to enable GRO. On the other
> hand, the current test is failed due to loading the XDP program. e.g.
>
> # selftests: net: udpgro.sh
> # ipv4
> # no GRO ok
> # no GRO chk cmsg ok
> # GRO ./udpgso_bench_rx: recv: bad packet len, got 1472, expected 14720
> #
> # failed
>
> [...]
>
> # bad GRO lookup ok
> # multiple GRO socks ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520
> #
> # ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520
> #
> # failed
> ok 1 selftests: net: udpgro.sh
>
> After fix, all the test passed.
>
> # ./udpgro.sh
> ipv4
> no GRO ok
> [...]
> multiple GRO socks ok
>
> Fixes: d7db7775ea2e ("net: veth: do not manipulate GRO when using XDP")
> Reported-by: Yi Chen <yiche@redhat.com>
> Closes: https://issues.redhat.com/browse/RHEL-53858
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2024-08-14 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 7:57 [PATCH net 0/2] selftests: Fix udpgro failures Hangbin Liu
2024-08-14 7:57 ` [PATCH net 1/2] selftests: udpgro: report error when receive failed Hangbin Liu
2024-08-14 10:19 ` Paolo Abeni
2024-08-14 14:20 ` Hangbin Liu
2024-08-14 14:17 ` Hangbin Liu
2024-08-14 7:57 ` [PATCH net 2/2] selftests: udpgro: no need to load xdp for gro Hangbin Liu
2024-08-14 10:19 ` Toke Høiland-Jørgensen [this message]
2024-08-14 10:20 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v803csp0.fsf@toke.dk \
--to=toke@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ignat@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=yiche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox