From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E1FC433DB for ; Fri, 26 Mar 2021 05:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0538561A43 for ; Fri, 26 Mar 2021 05:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229639AbhCZFph (ORCPT ); Fri, 26 Mar 2021 01:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbhCZFpQ (ORCPT ); Fri, 26 Mar 2021 01:45:16 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C24C0613B0 for ; Thu, 25 Mar 2021 22:45:14 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id m7so3856682pgj.8 for ; Thu, 25 Mar 2021 22:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=OqOZYiaXe2/4wha1fEs1gVf5T6I4+DZt+BtbIfVMO+A=; b=NTfOSkbbavoRe1I6wHo5nMJh++tgT4yErZ9HicwtA0cg85vQvQq9byvRgoV807Y5p0 pKkzxaDg7V4iAOPeZn/xEAXQQo+vZ5eIUNo9sQEm8xVW7PEb0906GAQJFs9brSP4pxVL zFUl4mAYffjkMLE2jAY8RPKeBsfsr0w8pWQSY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=OqOZYiaXe2/4wha1fEs1gVf5T6I4+DZt+BtbIfVMO+A=; b=VJf3ZaPuhZOnHtctmTF/75Cnjzo+FdN/t4tUY7SKt9L41OQgCDnI4twwFx0HDVMFsE 3xrOVOSRLtFPriWUdixJinL7fzJIl6I1dsEAHY2Kh8nqquAe8muhwOIDOHUmi3srAGjq BoQfpCMdHK7655ozBhK5xsxd3H85pLz81d0NtCIdeHTgCmKP+cMvsvaY87AzSBfjuwGp n6owbWIup990VlvJ5Ih6DYjZJYx7DfdBrhq3RSzNV/y/PKpO5V6dKVCAVC+AAgIys5mN +KuxXlxAwxDy/auV331ocJozil+vGVSmSMlPwCf2GtVhan6QPJISFnyO8TEwcUHTew8G ISFw== X-Gm-Message-State: AOAM53103zSHDKSRtvTM3Wf4u7btxLL8l1f6JetOeE7u38+fwF1BsdwO vB6PnhFj9e0/EgEThwBiItJkfDB3khMk4A== X-Google-Smtp-Source: ABdhPJzNEr7O3Y4iBRs57Wo7KFkaic8g91kRGbfEuj3r1OipG51u0rllrwWAbzkp4/W2IqFt/5InAw== X-Received: by 2002:a05:6a00:c8f:b029:213:db69:18af with SMTP id a15-20020a056a000c8fb0290213db6918afmr11139010pfv.76.1616737513575; Thu, 25 Mar 2021 22:45:13 -0700 (PDT) Received: from localhost (2001-44b8-111e-5c00-39c5-e677-fdb8-5d64.static.ipv6.internode.on.net. [2001:44b8:111e:5c00:39c5:e677:fdb8:5d64]) by smtp.gmail.com with ESMTPSA id u2sm6875572pgf.93.2021.03.25.22.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 22:45:13 -0700 (PDT) From: Daniel Axtens To: Wan Jiabing , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Shuah Khan , Wan Jiabing , linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kael_w@yeah.net Subject: Re: [PATCH] [v2] tools: testing: Remove duplicate includes In-Reply-To: <20210323061604.289958-1-wanjiabing@vivo.com> References: <20210323061604.289958-1-wanjiabing@vivo.com> Date: Fri, 26 Mar 2021 16:45:10 +1100 Message-ID: <87v99e79jt.fsf@linkitivity.dja.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Wan Jiabing writes: > sched.h has been included at line 33, so remove the > duplicate one at line 36. > pthread.h has been included at line 17,so remove the > duplicate one at line 20. I can see that both of these are correct from the diff. > inttypes.h has been included at line 19, so remove the > duplicate one at line 23. For this one I checked the file. Indeed there is another inttypes.h, so this is also correct. Again, all the automated checks pass. (although I don't think any of the automated builds include selftests.) So: Reviewed-by: Daniel Axtens Kind regards, Daniel > > Signed-off-by: Wan Jiabing > --- > tools/testing/selftests/powerpc/mm/tlbie_test.c | 1 - > tools/testing/selftests/powerpc/tm/tm-poison.c | 1 - > tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/powerpc/mm/tlbie_test.c b/tools/testing/selftests/powerpc/mm/tlbie_test.c > index f85a0938ab25..48344a74b212 100644 > --- a/tools/testing/selftests/powerpc/mm/tlbie_test.c > +++ b/tools/testing/selftests/powerpc/mm/tlbie_test.c > @@ -33,7 +33,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c > index 29e5f26af7b9..27c083a03d1f 100644 > --- a/tools/testing/selftests/powerpc/tm/tm-poison.c > +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c > @@ -20,7 +20,6 @@ > #include > #include > #include > -#include > > #include "tm.h" > > diff --git a/tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c b/tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c > index e2a0c07e8362..9ef37a9836ac 100644 > --- a/tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c > +++ b/tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > > #include "tm.h" > #include "utils.h" > -- > 2.25.1