From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92793C2D0E4 for ; Thu, 19 Nov 2020 06:03:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED07122259 for ; Thu, 19 Nov 2020 06:03:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="V4dsU87A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725778AbgKSGDk (ORCPT ); Thu, 19 Nov 2020 01:03:40 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:51637 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbgKSGDk (ORCPT ); Thu, 19 Nov 2020 01:03:40 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Cc8Hs6Rdnz9sTv; Thu, 19 Nov 2020 17:03:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1605765817; bh=+pZz8i6g7OW4NmP3Iuj693zPmlv8QYjXt7afMQdN6hE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=V4dsU87ALmKVfy4tqYomzsbnaVJHR20L5N3ndFKpV2IVqKhJ/yqxgQ8p151HOofey 1xrEuX6BOPCEF5p9l3fGBjt+CiS2hkL1YGoFyxG2zfi04+UNz5nwZoixuYHj01+Sae 2haUvRoyfyYWCCGT0wMp/3I3l16XUkFrh7+40y81m6X3hFxD3AXYQy+Tfc7tn94Fjg dr4sefW4e08FS5xumP7CmJHp48+8kEriOc85xKdgorrf8K0i8/ig+LO/S2HD+0rlxC Digtvx5vBb+UvSVaRyuMms4qN8wSmUj7XFWwds7EiJxQPqU3KY962y+gsUBSGoP//u 6jNsEKLf97VFA== From: Michael Ellerman To: Kees Cook , linux-kernel@vger.kernel.org Cc: Kees Cook , Thadeu Lima de Souza Cascardo , Andy Lutomirski , Will Drewry , linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests/seccomp: powerpc: Fix typo in macro variable name In-Reply-To: <20201117210104.1000661-1-keescook@chromium.org> References: <20201117210104.1000661-1-keescook@chromium.org> Date: Thu, 19 Nov 2020 17:03:34 +1100 Message-ID: <87y2ix2895.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Kees Cook writes: > A typo sneaked into the powerpc selftest. Fix the name so it builds again. > > Fixes: 46138329faea ("selftests/seccomp: powerpc: Fix seccomp return value testing") > Signed-off-by: Kees Cook > --- > tools/testing/selftests/seccomp/seccomp_bpf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I hit that and thought I'd sent a patch for it, but seems I never actually sent it. So thanks. I assume Shuah will take it. Acked-by: Michael Ellerman cheers > diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c > index 76c458055c54..26c72f2b61b1 100644 > --- a/tools/testing/selftests/seccomp/seccomp_bpf.c > +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c > @@ -1758,10 +1758,10 @@ TEST_F(TRACE_poke, getpid_runs_normally) > * and the code is stored as a positive value. \ > */ \ > if (_result < 0) { \ > - SYSCALL_RET(_regs) = -result; \ > + SYSCALL_RET(_regs) = -_result; \ > (_regs).ccr |= 0x10000000; \ > } else { \ > - SYSCALL_RET(_regs) = result; \ > + SYSCALL_RET(_regs) = _result; \ > (_regs).ccr &= ~0x10000000; \ > } \ > } while (0) > -- > 2.25.1