From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAA7C2D0292 for ; Thu, 3 Jul 2025 08:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751531386; cv=none; b=F12pweFQaA5uUBCOUbmRncbarFND8SFhm/jX3rxy469Xe+w7UpYk2gO1LfV+noe8cj434dfT+3IMJRdB3kIrQpVAT7eapq8Rqc1kgA6c4XfeBlxaIGMjimjgFD0lK4KvqFh4gcNp3iC8PRwS5bLKPj1QUuC9xif7OsOgOuCL1so= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751531386; c=relaxed/simple; bh=JmFTr4VG2yzIn+6cqotg3dpPO5cEw0/ijns6BC8xnpU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cQG5/kbIoOtzIruu2BdnnGj7uMwq7fxXNNlY3Lzb6rd5ayJn/wpqXjyQFU8J77+IOaDlNPe+sIk+Z/ec9bDinICHmngtOn7wuMo3wkgTntMypGJ+pYAZBb8LoJFbNP9LD7rWz4h+kk0HsyNg/sE83n+oYd/sOKEdNKwfxrVHkWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QIpMpdd7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QIpMpdd7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751531383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ao7iXo6bPr/lMtF2Dn4u+FVUcO1qO3WglYeGUpi07GA=; b=QIpMpdd7vZmNIgWCWVv2G1gqI7l0adVmA0o7fpjRGU3eGSoUor2rsWsWRZKD28NclLrAd2 LylLW5+ViSn5NxK/1/YWMPuhQ8MBZl+S/rptE8I1rvIsjq5OMgmYyJsGqi0MRjQ0DqWOYb DqFwOlVj6IRi1a8lIbjhN4VCIeitOIA= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-MsXNAS7UOnOdbQilSph3rA-1; Thu, 03 Jul 2025 04:29:41 -0400 X-MC-Unique: MsXNAS7UOnOdbQilSph3rA-1 X-Mimecast-MFC-AGG-ID: MsXNAS7UOnOdbQilSph3rA_1751531380 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-ae3c8477f1fso128892266b.3 for ; Thu, 03 Jul 2025 01:29:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751531379; x=1752136179; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ao7iXo6bPr/lMtF2Dn4u+FVUcO1qO3WglYeGUpi07GA=; b=kRT1Jpnp7TZj2TZPPNDJZHBl0ooYitps3YK4BvON9ORGqdLMWFU0dd195nG5DNt6Rw x0ZPg8DWyDHjmTgMzjZJTeMHhz59UaIc+TXxDm2XvARcacVMh+CTFfIvnAdunATlkySY EYEcIw7pUxmomHh06Jk57EcwgY5+nf4mSuB+VJfaoFmCHi78n44+efpi7Y4Ea0Qa0TLx tEA6vOcQsqoYBSSgGxG22SeDx8hE1236l3k3HO/R6Xrbd6fJDSl/uLHtvGCZsxUvOBq/ WwJCrf/w425VpQZjdTqRPCy2GRO60F8GBxyARLmezlqWt5SyFQUAk25MQUw2LOip2/ym L0UQ== X-Forwarded-Encrypted: i=1; AJvYcCV2gHJiadOp9d4R1P7SWCabp5l6fkqAig1COXQW1Gn+HYP2dQr048hfWbGEiz7EV6s2BTZUwYArsG45OZWBBsw=@vger.kernel.org X-Gm-Message-State: AOJu0YytZovqnRoyc27kZyOZe9NAWBYq58T+tK7QIekSSKl9TfsJIBS1 ul0ewVm7Ba12w6ooPv6pZMlCRdV3qZXYFiMcldwl45xJ9blbc4u5cWSBPMYMbitYRzSqzr9ftUi 8EK7Cu9Y1BJZTtzVoIrNpnB2RVCSFyeDZtJQfIjgVNm/07UnmIqCbetmtzOykWSZ4CIQg4A== X-Gm-Gg: ASbGncuHEObN9kVtgmHTHvZuPGBvi0I68dV3qGh9PYPHnK3a9D6rHIQRCqA1zPi/0E5 8Yma5HxwxJgB3ABA/v0v8p+QAcJPJWw9NjnZVoJ5Xt9s+IQZnXHH4rE9dtcPKWkxn8E/RmvfKcZ DDcS1Apeev61Lec+5EcpgrQwcMgERV9hSUGdk3NwINpC1nHhP/HLI5YI0VdL3LX+paAe10CIOTT P5tyE0bB5SixlsOu5R7F3q+EF8XmqxhXj4XyDz/89i2iNMxULToHjgo97KnZj0ll/+Cvey6FYx9 /ueoN5hpHdU1570hTRfCEndeAL7kIPsESG4LzS9CLjws X-Received: by 2002:a17:906:ee89:b0:add:ede0:b9d4 with SMTP id a640c23a62f3a-ae3d7dec8c4mr211837966b.0.1751531379338; Thu, 03 Jul 2025 01:29:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQR9Sq+kwX+EgrNsiJGUPRsQvrn7rKaEleIhOhduYW9+Qa0jv7W//ZA8gBY3JGvvrmcUIaZQ== X-Received: by 2002:a17:906:ee89:b0:add:ede0:b9d4 with SMTP id a640c23a62f3a-ae3d7dec8c4mr211834566b.0.1751531378784; Thu, 03 Jul 2025 01:29:38 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c6beb8sm1226408166b.132.2025.07.03.01.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 01:29:38 -0700 (PDT) Message-ID: <897dbcbf-d98e-4177-9d38-3d179c7d560b@redhat.com> Date: Thu, 3 Jul 2025 10:29:37 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] selftests/mm: Fix child process exit codes in ksm_functional_tests To: Aboorva Devarajan , akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com References: <20250703060656.54345-1-aboorvad@linux.ibm.com> <20250703060656.54345-6-aboorvad@linux.ibm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250703060656.54345-6-aboorvad@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03.07.25 08:06, Aboorva Devarajan wrote: > In ksm_functional_tests, test_child_ksm() returned negative values > to indicate errors. However, when passed to exit(), these were > interpreted as large unsigned values (e.g, -2 became 254), leading to > incorrect handling in the parent process. As a result, some tests > appeared to be skipped or silently failed. > > This patch changes test_child_ksm() to return positive error codes > (1, 2, 3) and updates test_child_ksm_err() to interpret them correctly. > This ensures the parent accurately detects and reports child process > failures. > > -------------- > Before patch: > -------------- > - [RUN] test_unmerge > ok 1 Pages were unmerged > ... > - [RUN] test_prctl_fork > - No pages got merged > - [RUN] test_prctl_fork_exec > ok 7 PR_SET_MEMORY_MERGE value is inherited > ... > Bail out! 1 out of 8 tests failed > - Planned tests != run tests (9 != 8) > - Totals: pass:7 fail:1 xfail:0 xpass:0 skip:0 error:0 > > -------------- > After patch: > -------------- > - [RUN] test_unmerge > ok 1 Pages were unmerged > ... > - [RUN] test_prctl_fork > - No pages got merged > not ok 7 Merge in child failed > - [RUN] test_prctl_fork_exec > ok 8 PR_SET_MEMORY_MERGE value is inherited > ... > Bail out! 2 out of 9 tests failed > - Totals: pass:7 fail:2 xfail:0 xpass:0 skip:0 error:0 > > Fixes: 6c47de3be3a0 ("selftest/mm: ksm_functional_tests: extend test case for ksm fork/exec") > Signed-off-by: Aboorva Devarajan Surprising, but seems to be the right thing to do. Acked-by: David Hildenbrand -- Cheers, David / dhildenb