From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2AA5FA3740 for ; Mon, 31 Oct 2022 10:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229961AbiJaKEY (ORCPT ); Mon, 31 Oct 2022 06:04:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiJaKEX (ORCPT ); Mon, 31 Oct 2022 06:04:23 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1089CDF1E for ; Mon, 31 Oct 2022 03:04:23 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id d59-20020a17090a6f4100b00213202d77e1so15441683pjk.2 for ; Mon, 31 Oct 2022 03:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2ObNEkjqN+lu4jH4ydICZPkDgwHSGo3Ukk+qxm2AujQ=; b=T75uSG4buYYXToFBL7XmOlzbTr+TZ348vLw3zqO5tzk7mzBL1wU9s6R74VemFg9ybB gbObqIBV9qBXhOgL6P4N4K/8DsS6qDg8mc/WHCCRM35mv9jt5wx9bmHL9YTBs0bGzgZ6 vx5tNKX3RLxuf0wHPGIcgtKwTI1fOxLhDOWEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2ObNEkjqN+lu4jH4ydICZPkDgwHSGo3Ukk+qxm2AujQ=; b=QFRlRG0s0sOSino0Qq2SO/TMh8M4z8tC7/Qjq9nlhS19LvDGl7C/AZMkjvu4WbMOFM M1uMcvElxmcUDWHTZmy5zLOl0BwB889fnx8sK1taaLqg6Zh/q0huAOzIn/KrEDTtIz0k ydGWBSmkB5tbeZsaEUt1Biu8tUP9RprlvgFMpQDx+WqLUp4nK1Ey+jsSPxPHZvHDKyg+ K0q5E46AGlNX21x/ZCuy3mmN5rfzMafb2cwQ8Bhykyr42jSKorSP4Dt8KSraBMpvjrGl FHgWWXPQWUPj5Wu513tiuMZrGx1yG5hzFw551am7TPKpR3mLZL1S4QdY1luNJicuYU7N MZGg== X-Gm-Message-State: ACrzQf1uX6rmj29AivmZysdvPlMmcMYP5m3TZK9CxKnp5bpq3P9E3F87 EnVAqcO98N6mTPksIs/sbg+1Aw== X-Google-Smtp-Source: AMsMyM5rmdIIAnl9/bT5xIF5fi6q/lDxI4yLFe8/1JXcsrt33hEAa/F8kD5qxLsOMJa1doRIksZtLg== X-Received: by 2002:a17:90b:254c:b0:20a:8a92:ea5b with SMTP id nw12-20020a17090b254c00b0020a8a92ea5bmr14009867pjb.81.1667210662429; Mon, 31 Oct 2022 03:04:22 -0700 (PDT) Received: from [192.168.0.168] ([103.99.10.63]) by smtp.gmail.com with ESMTPSA id x66-20020a623145000000b00565cf8c52c8sm4301245pfx.174.2022.10.31.03.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 03:04:21 -0700 (PDT) Message-ID: <899fc0ab-18d1-a563-10ea-b91623422570@linuxfoundation.org> Date: Mon, 31 Oct 2022 04:04:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH V5 0/5] Add tbench/gitsource new test cases for amd-pstate-ut To: Meng Li , Huang Rui , linux-kselftest@vger.kernel.org Cc: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , Alex Deucher , Mario Limonciello , Shimmer Huang , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , linux-kernel@vger.kernel.org, Shuah Khan References: <20221031084924.1742169-1-li.meng@amd.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20221031084924.1742169-1-li.meng@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/31/22 02:49, Meng Li wrote: > Hi all: > > First, rename amd-pstate-ut.sh to basic.sh as a basic test, mainly for > AMD P-State kernel drivers. The purpose of this modification is to > facilitate the subsequent addition of gitsource, tbench and other tests. > > Second, split basic.sh into run.sh and basic.sh. > The modification makes basic.sh more pure, just for test basic kernel > functions. The file of run.sh mainly contains functions such as test > entry, parameter check, prerequisite and log clearing etc. > > Third, add tbench.sh trigger the tbench testing and monitor the cpu. > > Fourth, add gitsource.sh trigger the gitsource testing and monitor the cpu > information. > > Finally, modify rst document to introduce test steps and results etc. > > > Changes from V4->V5: > - selftests: amd-pstate: > - - rename amd-pstate-ut.sh to basic.sh. > - - split basic.sh into run.sh and basic.sh. > - - modify tbench.sh to prompt to install tbench. > - - modify commit messages and description informations of shell files. > - Documentation: amd-pstate: > - - correct spell errors. > v5 series looks good. Please cleanup checkpatch errors in a couple of files. Not too concerned about long line warnings as these seem like "echo" statements with output text. thanks, -- Shuah