From: Shuah Khan <skhan@linuxfoundation.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-rtc@vger.kernel.org, shuah@kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests/rtc:Fix a resource leak
Date: Wed, 10 Jul 2024 10:00:16 -0600 [thread overview]
Message-ID: <8e4d88f3-a45b-4d30-bec6-75636c854d43@linuxfoundation.org> (raw)
In-Reply-To: <20240710075513332c564f@mail.local>
On 7/10/24 01:55, Alexandre Belloni wrote:
> On 10/07/2024 00:43:09-0700, Zhu Jun wrote:
>> The opened file should be closed before exit, otherwise resource leak
>> will occur that this problem was discovered by code reading
>
> The question is still why should it be closed before exit as it will be
> closed on exit?
>
Zhu Jun,
+1 on this. I have responded to your other patches that do the same
in other tests. There is no need to make such changes.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-07-10 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 6:07 [PATCH] selftests/rtc:Fix a resource leak Zhu Jun
2024-07-10 7:16 ` Alexandre Belloni
2024-07-10 7:43 ` [PATCH v2] " Zhu Jun
2024-07-10 7:55 ` Alexandre Belloni
2024-07-10 16:00 ` Shuah Khan [this message]
2024-07-16 17:58 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4d88f3-a45b-4d30-bec6-75636c854d43@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox