From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254D3C001DF for ; Fri, 28 Jul 2023 14:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236939AbjG1Ofu (ORCPT ); Fri, 28 Jul 2023 10:35:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236932AbjG1Oft (ORCPT ); Fri, 28 Jul 2023 10:35:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 135503A9A for ; Fri, 28 Jul 2023 07:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690554909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T8f2jcEWHe85NAwJ+QYf2QWkY01PugbZbbWPEErvXII=; b=dSVtRjN92KOaajraJrUYmBCnKfqcPZ5pJVGB8DgkLkZKCXXSTBDyuIOYfFlFpwbttnCGCZ 6j/IGfB0tbmaJgceleS4Iw4SFrrc3fGc2pdmOgz4hD3TmXnRKIpcdEuwyNpZFGo7TFnrij IyLDLOIvaIBJUNFJZ7+TG1NN815hnNo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-YLagTAmGNOSUUui0CAeYVg-1; Fri, 28 Jul 2023 10:35:07 -0400 X-MC-Unique: YLagTAmGNOSUUui0CAeYVg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fbb0c01e71so11858655e9.0 for ; Fri, 28 Jul 2023 07:35:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690554906; x=1691159706; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T8f2jcEWHe85NAwJ+QYf2QWkY01PugbZbbWPEErvXII=; b=Htu18IKDhFeQT/vTcyGUS+wu4RYWfYBgmwF/xFfB77LY7J3kRcU7mfZEC60h73MoS1 Yw5BTpGWpTLhxrM/vcI0kc0n3/mVCzBn1iQG7gITTv2K6ncpNQssPrlJiGNUOGIeNMCk l9IP+E5hBb3zRjpYDXtTmNCrXU/jv5Cih9S9yJ5oAYmvN07Cr4ImgdRECjvsFanCiN3p BahtNRfCjYrxvRbqpLgWKd/UtzDsEEyMSNRzbwK1Fk2KTfas/0grApO7S6Ot2ipgZXZj 3R5pGVzzYS+s0f0t59JNIjj0JZBl1HF2YTq5ihjhQUL9+HADITi84Lk8oa2zEVvGv5QA NNgg== X-Gm-Message-State: ABy/qLYiZL/mZbdoPpCmkN2EaqquXbE+vFxpBFh7MmfL9O/mdydrDHeX z9YXpHdYKRqpcplnXmQXpLY6N0cnToiPrB8jOJURlnLlNAaikCIhg37//cQS0yepdD4WLk2EnpP oUKm/Wj+Dvu/qMsRJmdl5ygxouVrM X-Received: by 2002:a05:600c:2248:b0:3fb:ffa8:6d78 with SMTP id a8-20020a05600c224800b003fbffa86d78mr1882089wmm.36.1690554906731; Fri, 28 Jul 2023 07:35:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlGghZKLFi0VL5qxS7EG+DsAnMC4z1b9QjFmvxxsSdSuv02WebYTiWKZNZ14tKbZSFP1Q1dm0w== X-Received: by 2002:a05:600c:2248:b0:3fb:ffa8:6d78 with SMTP id a8-20020a05600c224800b003fbffa86d78mr1882076wmm.36.1690554906382; Fri, 28 Jul 2023 07:35:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:6b00:bf49:f14b:380d:f871? (p200300cbc7066b00bf49f14b380df871.dip0.t-ipconnect.de. [2003:cb:c706:6b00:bf49:f14b:380d:f871]) by smtp.gmail.com with ESMTPSA id f2-20020a7bc8c2000000b003fbc9b9699dsm4324357wml.45.2023.07.28.07.35.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 07:35:05 -0700 (PDT) Message-ID: <8e4d9fa7-7550-87a9-ead1-2d2a8691cdab@redhat.com> Date: Fri, 28 Jul 2023 16:35:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] selftests: mm: ksm: Fix incorrect evaluation of parameter Content-Language: en-US To: Ayush Jain , akpm@linux-foundation.org, shuah@kernel.org, pasha.tatashin@soleen.com, zhansayabagdaulet@gmail.com, tyhicks@linux.microsoft.com, raghavendra.kodsarathimmappa@amd.com Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Narasimhan.V@amd.com, Santosh.Shukla@amd.com References: <20230728060109.4403-1-ayush.jain3@amd.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230728060109.4403-1-ayush.jain3@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 28.07.23 08:01, Ayush Jain wrote: > A missing break in kms_tests leads to kselftest hang when the > parameter -s is used. > In current code flow because of missing break in -s, -t parses > args spilled from -s and as -t accepts only valid values as 0,1 > so any arg in -s >1 or <0, gets in ksm_test failure > > This went undetected since, before the addition of option -t, > the next case -M would immediately break out of the switch > statement but that is no longer the case > > Add the missing break statement. > > ----Before---- > ./ksm_tests -H -s 100 > Invalid merge type > > ----After---- > ./ksm_tests -H -s 100 > Number of normal pages: 0 > Number of huge pages: 50 > Total size: 100 MiB > Total time: 0.401732682 s > Average speed: 248.922 MiB/s > > Fixes: 9e7cb94ca218 ("selftests: vm: add KSM merging time test") I think this actually fixes 07115fcc15b4 ("selftests/mm: add new selftests for KSM") that added the "t" parsing. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb