Re: [PATCH net-next v24 00/23] Introducing OpenVPN Data Channel Offload

[Antonio Quartulli <antonio@openvpn.net>]

Hi Sabrina,

do you plan to drop more comments at the patchset at this point?

I have gone through all requested changes and I'll just get the patches 
ready for submission once net-next is open again.

Thanks a lot!

Cheers,

On 18/03/2025 02:40, Antonio Quartulli wrote:
> Notable changes since v23:
> * dropped call to netif_tx_start/stop_all_queues()
> * dropped NETIF_F_HW_CSUM and NETIF_F_RXCSUM dev flags
> * dropped conditional call to skb_checksum_help() due to the point above
> * added call to dst_cache_reset() in nl_peer_modify()
> * dropped obsolete comment in ovpn_peer_keepalive_work()
> * reversed scheduling delay computation in ovpn_peer_keepalive_work()
> 
> Please note that some patches were already reviewed/tested by a few
> people. These patches have retained the tags as they have hardly been
> touched.
> 
> The latest code can also be found at:
> 
> https://github.com/OpenVPN/ovpn-net-next
> 
> Thanks a lot!
> Best Regards,
> 
> Antonio Quartulli
> OpenVPN Inc.
> 
> ---
> Antonio Quartulli (23):
>        net: introduce OpenVPN Data Channel Offload (ovpn)
>        ovpn: add basic netlink support
>        ovpn: add basic interface creation/destruction/management routines
>        ovpn: keep carrier always on for MP interfaces
>        ovpn: introduce the ovpn_peer object
>        ovpn: introduce the ovpn_socket object
>        ovpn: implement basic TX path (UDP)
>        ovpn: implement basic RX path (UDP)
>        ovpn: implement packet processing
>        ovpn: store tunnel and transport statistics
>        ovpn: implement TCP transport
>        skb: implement skb_send_sock_locked_with_flags()
>        ovpn: add support for MSG_NOSIGNAL in tcp_sendmsg
>        ovpn: implement multi-peer support
>        ovpn: implement peer lookup logic
>        ovpn: implement keepalive mechanism
>        ovpn: add support for updating local or remote UDP endpoint
>        ovpn: implement peer add/get/dump/delete via netlink
>        ovpn: implement key add/get/del/swap via netlink
>        ovpn: kill key and notify userspace in case of IV exhaustion
>        ovpn: notify userspace when a peer is deleted
>        ovpn: add basic ethtool support
>        testing/selftests: add test tool and scripts for ovpn module
> 
>   Documentation/netlink/specs/ovpn.yaml              |  367 +++
>   Documentation/netlink/specs/rt_link.yaml           |   16 +
>   MAINTAINERS                                        |   11 +
>   drivers/net/Kconfig                                |   15 +
>   drivers/net/Makefile                               |    1 +
>   drivers/net/ovpn/Makefile                          |   22 +
>   drivers/net/ovpn/bind.c                            |   55 +
>   drivers/net/ovpn/bind.h                            |  101 +
>   drivers/net/ovpn/crypto.c                          |  211 ++
>   drivers/net/ovpn/crypto.h                          |  145 ++
>   drivers/net/ovpn/crypto_aead.c                     |  409 ++++
>   drivers/net/ovpn/crypto_aead.h                     |   29 +
>   drivers/net/ovpn/io.c                              |  455 ++++
>   drivers/net/ovpn/io.h                              |   34 +
>   drivers/net/ovpn/main.c                            |  330 +++
>   drivers/net/ovpn/main.h                            |   14 +
>   drivers/net/ovpn/netlink-gen.c                     |  213 ++
>   drivers/net/ovpn/netlink-gen.h                     |   41 +
>   drivers/net/ovpn/netlink.c                         | 1250 ++++++++++
>   drivers/net/ovpn/netlink.h                         |   18 +
>   drivers/net/ovpn/ovpnpriv.h                        |   57 +
>   drivers/net/ovpn/peer.c                            | 1364 +++++++++++
>   drivers/net/ovpn/peer.h                            |  163 ++
>   drivers/net/ovpn/pktid.c                           |  129 ++
>   drivers/net/ovpn/pktid.h                           |   87 +
>   drivers/net/ovpn/proto.h                           |  118 +
>   drivers/net/ovpn/skb.h                             |   61 +
>   drivers/net/ovpn/socket.c                          |  244 ++
>   drivers/net/ovpn/socket.h                          |   49 +
>   drivers/net/ovpn/stats.c                           |   21 +
>   drivers/net/ovpn/stats.h                           |   47 +
>   drivers/net/ovpn/tcp.c                             |  592 +++++
>   drivers/net/ovpn/tcp.h                             |   36 +
>   drivers/net/ovpn/udp.c                             |  442 ++++
>   drivers/net/ovpn/udp.h                             |   25 +
>   include/linux/skbuff.h                             |    2 +
>   include/uapi/linux/if_link.h                       |   15 +
>   include/uapi/linux/ovpn.h                          |  109 +
>   include/uapi/linux/udp.h                           |    1 +
>   net/core/skbuff.c                                  |   18 +-
>   net/ipv6/af_inet6.c                                |    1 +
>   net/ipv6/udp.c                                     |    1 +
>   tools/testing/selftests/Makefile                   |    1 +
>   tools/testing/selftests/net/ovpn/.gitignore        |    2 +
>   tools/testing/selftests/net/ovpn/Makefile          |   31 +
>   tools/testing/selftests/net/ovpn/common.sh         |   92 +
>   tools/testing/selftests/net/ovpn/config            |   10 +
>   tools/testing/selftests/net/ovpn/data64.key        |    5 +
>   tools/testing/selftests/net/ovpn/ovpn-cli.c        | 2395 ++++++++++++++++++++
>   tools/testing/selftests/net/ovpn/tcp_peers.txt     |    5 +
>   .../testing/selftests/net/ovpn/test-chachapoly.sh  |    9 +
>   .../selftests/net/ovpn/test-close-socket-tcp.sh    |    9 +
>   .../selftests/net/ovpn/test-close-socket.sh        |   45 +
>   tools/testing/selftests/net/ovpn/test-float.sh     |    9 +
>   tools/testing/selftests/net/ovpn/test-tcp.sh       |    9 +
>   tools/testing/selftests/net/ovpn/test.sh           |  113 +
>   tools/testing/selftests/net/ovpn/udp_peers.txt     |    5 +
>   57 files changed, 10054 insertions(+), 5 deletions(-)
> ---
> base-commit: 702e3fa16cd42ba712825e8d6171ea4755bc0491
> change-id: 20241002-b4-ovpn-eeee35c694a2
> 
> Best regards,

-- 
Antonio Quartulli
OpenVPN Inc.