From: Shuah Khan <skhan@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Brendan Higgins <brendanhiggins@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: Kunit fixes update for Linux 5.10-rc3
Date: Thu, 5 Nov 2020 15:34:21 -0700 [thread overview]
Message-ID: <8fda76e3-4495-571b-6f8b-0b76da511108@linuxfoundation.org> (raw)
In-Reply-To: <CAHk-=wiscEwD+a4M2mns1kf2S+yE6gcPp0sn4znVt0ZUxaP3Wg@mail.gmail.com>
On 11/5/20 1:02 PM, Linus Torvalds wrote:
> On Thu, Nov 5, 2020 at 8:55 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> .../kunit/test_data/test_config_printk_time.log | Bin 1584 -> 1605 bytes
>> .../test_data/test_interrupted_tap_output.log | Bin 1982 -> 2003 bytes
>> .../test_data/test_kernel_panic_interrupt.log | Bin 1321 -> 1342 bytes
>> .../kunit/test_data/test_multiple_prefixes.log | Bin 1832 -> 1861
>
> This diffstat is a bit annoying.
>
> And the reason is that we have
>
> [torvalds@ryzen linux]$ cat tools/testing/kunit/.gitattributes
> test_data/* binary
>
> iow, you're telling git that everything in that test_data directory is
> binary blobs. Which isn't actually true.
>
> This isn't new, but it was just more noticeable this time around.
>
> That binary marker comes from commit afc63da64f1e ("kunit:
> kunit_parser: make parser more robust") and I'm not really seeing the
> reason for it.
>
You are right. It appears there is no need to add these binary blobs.
Brendan and I discussed this and he will send a fix to remove the blobs
and redo the test output. In other words fix commit afc63da64f1e.
Sorry for not catching this earlier.
thanks,
-- Shuah
prev parent reply other threads:[~2020-11-05 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 16:55 Kunit fixes update for Linux 5.10-rc3 Shuah Khan
2020-11-05 20:02 ` Linus Torvalds
2020-11-05 20:25 ` Linus Torvalds
2020-11-05 22:01 ` Shuah Khan
2020-11-05 22:54 ` Linus Torvalds
2020-11-05 22:34 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fda76e3-4495-571b-6f8b-0b76da511108@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=brendanhiggins@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox