Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Liam Merwick <liam.merwick@oracle.com>
To: Maxim Levitsky <mlevitsk@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Liam Merwick <liam.merwick@oracle.com>
Subject: Re: [PATCH] KVM: selftests: memslot_perf_test: increase guest sync timeout
Date: Mon, 7 Oct 2024 14:02:10 +0000	[thread overview]
Message-ID: <9071cc6f-05af-4f00-9a95-3b413b92de84@oracle.com> (raw)
In-Reply-To: <20241004220153.287459-1-mlevitsk@redhat.com>

On 04/10/2024 23:01, Maxim Levitsky wrote:
> When memslot_perf_test is run nested, first iteration of test_memslot_rw_loop
> testcase, sometimes takes more than 2 seconds due to build of shadow page tables.
> 
> Following iterations are fast.
> 
> To be on the safe side, bump the timeout to 10 seconds.
> 
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>

I see the issue without this fix.

Tested-by: Liam Merwick <liam.merwick@oracle.com>
Reviewed-by: Liam Merwick <liam.merwick@oracle.com>


> ---
>   tools/testing/selftests/kvm/memslot_perf_test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/memslot_perf_test.c b/tools/testing/selftests/kvm/memslot_perf_test.c
> index 893366982f77b..e9189cbed4bb6 100644
> --- a/tools/testing/selftests/kvm/memslot_perf_test.c
> +++ b/tools/testing/selftests/kvm/memslot_perf_test.c
> @@ -415,7 +415,7 @@ static bool _guest_should_exit(void)
>    */
>   static noinline void host_perform_sync(struct sync_area *sync)
>   {
> -	alarm(2);
> +	alarm(10);
>   
>   	atomic_store_explicit(&sync->sync_flag, true, memory_order_release);
>   	while (atomic_load_explicit(&sync->sync_flag, memory_order_acquire))


  reply	other threads:[~2024-10-07 14:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 22:01 [PATCH] KVM: selftests: memslot_perf_test: increase guest sync timeout Maxim Levitsky
2024-10-07 14:02 ` Liam Merwick [this message]
2024-10-09 14:58 ` Sean Christopherson
2024-11-05  5:55   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9071cc6f-05af-4f00-9a95-3b413b92de84@oracle.com \
    --to=liam.merwick@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mlevitsk@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox