From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87A6F413231 for ; Mon, 2 Mar 2026 15:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772466875; cv=none; b=jyQULztTJTu2Vc1UxLWdKSa+OF8e82ZmWpgyTWQAf/eg/a07Z2Tqvi5QDohdfy4TwNdunyLiZtIDFMYJn071HH0/l4zIZ5ZwtzvKAas3VhuA5Wz8OL0VLyEcYNJV87AR2Oc9Pfj4brkE6omu43DyC1qYc0feu61WsxQC21mccUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772466875; c=relaxed/simple; bh=dDpcbfDi0yi7fEFTxd12xIV5BQ3X3OV+mFeaeykwVCM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A+hhvU7FiWLGRjrEIvgLcmADf54h4cucdCjwWCVzs5lv0+PwTgnCul/qiqWqEoqawbnj7bwDsOzl6s5VUZvJq5GYDUpTJNeO1ZfbJTusPiaI5JHanyMjBgBq+gKEw4BbIHfLQyYraeI3BdUf73DnpWDb+OUgohqgXYrdvEf0+P0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=davidwei.uk; spf=none smtp.mailfrom=davidwei.uk; dkim=pass (2048-bit key) header.d=davidwei-uk.20230601.gappssmtp.com header.i=@davidwei-uk.20230601.gappssmtp.com header.b=zHZDllC4; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=davidwei.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=davidwei.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=davidwei-uk.20230601.gappssmtp.com header.i=@davidwei-uk.20230601.gappssmtp.com header.b="zHZDllC4" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-12758ce1e8dso5527365c88.0 for ; Mon, 02 Mar 2026 07:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=davidwei-uk.20230601.gappssmtp.com; s=20230601; t=1772466870; x=1773071670; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vYKX84PLbw1ik011AtUFY/JoiQVlKtt+8d30XwsrbyA=; b=zHZDllC4F8vhmIye6X0hKfi9I2znFzlhAdHfhUzK/9PJ1wSMBFVNUcRV2K/Q0E6FbO dGSLu/ViHr6mZbr+JxW8NvqoUglssyBfP4LnrZ1BmfutjquEOmST1/7G3ZETOXSA3Z0y A4Jidrl15Ex/tcF6Vn2k/gjER8+zmvFhkeNhvoIwCZTIa5GZc16Qbo7QHNFDudOqu7CE 0ZfH7KVe56T242mitHDwKgrCsLFynQRTJ0MY5TI7EIBEEYNUhAsh6l/UPSPfsESPvRzM kdXFOVjBgWDRvAm1jA4hweX9x96FI8oH3LchAe6U58mnQkFtCsbUjkHTdL3Iee3u5Blt 5C9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772466870; x=1773071670; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vYKX84PLbw1ik011AtUFY/JoiQVlKtt+8d30XwsrbyA=; b=LsCDoGlIqhtXJ+5+RI07YFeJAy0YADxX17Q1OTyHzNZKKf7XWBVWzcB7a6gctGQEVt 8mjy4wNrgFMxdeA/SJKHDkZQ4BLmAwOOhVMH2rHozuOTYNP7Kngi0STRJa7iNiterZiK X1VXiKOtNfK9VmymCuDRnIBTBXR97obr6IBzeqkrfY3n22TKbNBkit3OZNDSOTQl2d1b xgK4Yc5i6szx+P0GqhUjbXZzyOQ2QoVkZjefTEQsK6dEax+yFG8a61apxTaNDhyAZZCy UNP/Ce5UDU6vuLvVHU9geu5oYXsmmiCZHbImVqC1r0vvu2u1ZlTu4pLgC39e9EJ22IZI JSWQ== X-Forwarded-Encrypted: i=1; AJvYcCXENo1I8uoWJwA58P0DrljO12xEgirOZ0okBrFL0Sw3+KUR7bGBgcZ1t/NG6qktTvXx8EOYYId2eHEkC71zK+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ0dopDHPHjkqCAuf6lHtUTN6XSefF2rddek8Frg/uoDJnCFvK NyC7SECD2JRjJBQFDpubSQzaOZWxhqX87xLcM0ggAPYnR3j6mn5M8W6Nl54x5EaJiNgmArflmft xGd5lB+k= X-Gm-Gg: ATEYQzz2cCyKVxdtqy7fzQsNYJMWdUMrUMYykinkvZxk5essbxQtVRKMJx95FRFO1YP ecCVlnIBfqq/rV5ANxvKdXPSyIsGM4UKWpBvD+XS0Vtvj/lRcJVZVfV/h6D26vpJbKr+FYxEvgA bfnB3N7kZVXaoJcpsb99hyllMl/Q3dzjmLY1KNwH20FpP492Wjw661hZOxo+/jR6u2k4oMd0Sr5 uI2TmYZQJByUceF0cLxwsNwTKUJNEN6FAQ0qGxf+YX30qBAbfnaC0W+rYyGSN9v0jw4qBg9srPD 0c5Xuot58b4uLrNBNxBSiG+9tZwxLP2ijTa3AiwPrh+PgUS4XuaClOzYOt0fFwLlvZUQ8dn5hWc ISuC7yWSqseWFpmqnYgu/CK7mgi4sXsLLSqQHSEa8DZWeHlaYJwAkO9wJQPzNF+jyrV2mY80CTA 1YYGMJx+/x67kHGWfGBZyFTuGXAdwnuP2RmVfQ/k3itL1CWNkh3946CoMTRfLbMC0CQZ13nUCHP ir/JnigDsvBuSfX6dR3wOkrMgGchtZH X-Received: by 2002:a05:7301:fa0b:b0:2be:617:2ddf with SMTP id 5a478bee46e88-2be06173268mr2046986eec.16.1772466870425; Mon, 02 Mar 2026 07:54:30 -0800 (PST) Received: from ?IPV6:2a03:83e0:1156:1:c8f:b917:4342:fa09? ([2620:10d:c090:500::badb]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bdd1a45a58sm10660215eec.0.2026.03.02.07.54.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 07:54:30 -0800 (PST) Message-ID: <90cfcf06-e987-4817-acba-2037a436a744@davidwei.uk> Date: Mon, 2 Mar 2026 07:54:28 -0800 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/3] selftests: drv-net: iou-zcrx: rework large chunks test to use common setup To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, jdamato@fastly.com, asml.silence@gmail.com, io-uring@vger.kernel.org, shuah@kernel.org, linux-kselftest@vger.kernel.org References: <20260227171305.2848240-1-kuba@kernel.org> <20260227171305.2848240-3-kuba@kernel.org> Content-Language: en-US From: David Wei In-Reply-To: <20260227171305.2848240-3-kuba@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-02-27 09:13, Jakub Kicinski wrote: > Commit a32bb32d0193 ("selftests: iou-zcrx: test large chunk sizes") > and commit de7c600e2d5b ("selftests/net: parametrise iou-zcrx.py with > ksft_variants") landed at similar time. The large chunks test was > actually not included in the list of tests, so it never run. > We haven't noticed that it uses the old-style helpers > (_get_combined_channels, _get_current_settings, _set_flow_rule) > that were removed by the other commit. > > Rework test_zcrx_large_chunks to reuse the single() setup function > and add it to the ksft_run cases list so it actually gets executed. > > Signed-off-by: Jakub Kicinski > --- > CC: shuah@kernel.org > CC: dw@davidwei.uk > CC: jdamato@fastly.com > CC: linux-kselftest@vger.kernel.org > --- > .../selftests/drivers/net/hw/iou-zcrx.py | 31 ++++--------------- > 1 file changed, 6 insertions(+), 25 deletions(-) > > diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.py b/tools/testing/selftests/drivers/net/hw/iou-zcrx.py > index c27c2064701d..1649c23e05e2 100755 > --- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.py > +++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.py > @@ -135,36 +135,16 @@ SKIP_CODE = 42 > > cfg.require_ipver('6') > > - combined_chans = _get_combined_channels(cfg) > - if combined_chans < 2: > - raise KsftSkipEx('at least 2 combined channels required') > - (rx_ring, hds_thresh) = _get_current_settings(cfg) > - port = rand_port() > - > - ethtool(f"-G {cfg.ifname} tcp-data-split on") > - defer(ethtool, f"-G {cfg.ifname} tcp-data-split auto") > - > - ethtool(f"-G {cfg.ifname} hds-thresh 0") > - defer(ethtool, f"-G {cfg.ifname} hds-thresh {hds_thresh}") > - > - ethtool(f"-G {cfg.ifname} rx 64") > - defer(ethtool, f"-G {cfg.ifname} rx {rx_ring}") > - > - ethtool(f"-X {cfg.ifname} equal {combined_chans - 1}") > - defer(ethtool, f"-X {cfg.ifname} default") > - > - flow_rule_id = _set_flow_rule(cfg, port, combined_chans - 1) > - defer(ethtool, f"-N {cfg.ifname} delete {flow_rule_id}") > - > - rx_cmd = f"{cfg.bin_local} -s -p {port} -i {cfg.ifname} -q {combined_chans - 1} -x 2" > - tx_cmd = f"{cfg.bin_remote} -c -h {cfg.addr_v['6']} -p {port} -l 12840" > + single(cfg) Let's use ksft_variants() with both single() and rss()?