From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65552C67871 for ; Tue, 25 Oct 2022 01:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbiJYBDQ (ORCPT ); Mon, 24 Oct 2022 21:03:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230026AbiJYBCs (ORCPT ); Mon, 24 Oct 2022 21:02:48 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ECDE459AE; Mon, 24 Oct 2022 16:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666655991; x=1698191991; h=message-id:date:mime-version:from:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=hdZaNs5iMO5JH6LtUCsAkiAuMuGiiXGD8WqtALn07oE=; b=JchifkzTYgeQcrxlxtKgNUQrif/YHJ1AEQksVNF9WMMfjQ/XvbtulXmF oumyvuPUx7/nQPjdnIAMyB+fUo2pDOc8UQlskX6wp3lhrBUkHOFDbezhl VwrepPVwH5953R5XVc/aJbeTNUiU0fbix22nZtjSaEhrcDm2C96h9nlp9 KmN6byn3xkFRck3qOomN0S1ce7bSLtXDdcOgetEJMgzri4Sx9FLVRl0Sg bQ2WloY3usRvcMFhGq/ubWHZol6/Xw2CvEDx9dYYr+vg75q5Yi5yZ40pr flcP+uxXBphUlSUh7XC0wncl1h96ocqAKWsmiremRC7r1IFwNRGZykn1O g==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="305160854" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="305160854" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 16:59:50 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="694746317" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="694746317" Received: from bmahadev-mobl.amr.corp.intel.com (HELO [10.212.216.245]) ([10.212.216.245]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 16:59:49 -0700 Message-ID: <91db431a-36ab-c833-1068-536695981d45@linux.intel.com> Date: Mon, 24 Oct 2022 16:59:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.2.2 From: Sathyanarayanan Kuppuswamy Subject: Re: [PATCH v15 2/3] virt: Add TDX guest driver To: Greg Kroah-Hartman , Wander Lairson Costa Cc: Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Shuah Khan , Jonathan Corbet , "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Kai Huang , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org References: <20221020045828.2354731-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20221020045828.2354731-3-sathyanarayanan.kuppuswamy@linux.intel.com> <34ef18d6-69f8-853a-d1ba-7023822e17ff@linux.intel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/24/22 6:54 AM, Greg Kroah-Hartman wrote: >>>>>> You are allowing userspace to spam the kernel logs, please do not do >>>>>> that. >>>>> Added it to help userspace understand the reason for the failure (only for >>>>> the cases like request param issues and TDCALL failure). Boris recommended >>>>> adding it in the previous review. >>>> Again, you just created a vector for userspace to spam the kernel log. >>>> No kernel driver should ever do that. >>>> >>> Brois, any comments? Do you also agree? >>> >> Maybe dev_err_once() does the job? > That does not make any sense when the userspace input can be different > each time. > > This is just yet-another-ioctl, there's nothing special about it. > Return an error for invalid input and don't log anything. Worst case, > make it a dev_dbg() call if you really really really want to see it. It is a nice to have debug info, but not very important. So I will remove it. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer