From: Edward Cree <ecree.xilinx@gmail.com>
To: Daniel Xu <dxu@dxuuu.xyz>,
pabeni@redhat.com, edumazet@google.com, davem@davemloft.net,
shuah@kernel.org, andrew+netdev@lunn.ch, kuba@kernel.org,
michael.chan@broadcom.com, martin.lau@linux.dev,
pavan.chebbi@broadcom.com
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH net v2 2/2] selftests: drv-net: rss_ctx: Add test for ntuple rule
Date: Tue, 12 Nov 2024 11:10:23 +0000 [thread overview]
Message-ID: <93831343-03c3-d540-369d-fe82eb480c58@gmail.com> (raw)
In-Reply-To: <dc4398dfe9a8e959245d2a8ffe5c2fcefbdd67f7.1731377399.git.dxu@dxuuu.xyz>
On 12/11/2024 02:23, Daniel Xu wrote:
> Extend the rss_ctx test suite to test that an ntuple action that
> redirects to an RSS context contains that information in `ethtool -n`.
> Otherwise the output from ethtool is highly deceiving. This test helps
> ensure drivers are compliant with the API.
>
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
...
> +def _ntuple_rule_check(cfg, rule_id, ctx_id):
> + """Check that ntuple rule references RSS context ID"""
> + text = ethtool(f"-n {cfg.ifname} rule {rule_id}").stdout
> + pattern = f"RSS Context ID: {ctx_id}"
> + ksft_true(re.search(pattern, text, re.IGNORECASE),
This won't match the output from your ethtool patch, because that
removes the colon. Probably want to wait until the patch is
finalised and then write a regex that matches both versions.
next prev parent reply other threads:[~2024-11-12 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 2:23 [PATCH net v2 0/2] bnxt: Fix failure to report RSS context in ntuple rule Daniel Xu
2024-11-12 2:23 ` [PATCH net v2 2/2] selftests: drv-net: rss_ctx: Add test for " Daniel Xu
2024-11-12 11:10 ` Edward Cree [this message]
2024-11-13 1:51 ` Daniel Xu
2024-11-13 1:59 ` Jakub Kicinski
2024-11-13 1:44 ` Jakub Kicinski
2024-11-13 1:58 ` Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93831343-03c3-d540-369d-fe82eb480c58@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dxu@dxuuu.xyz \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox