From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B383D3F8E2 for ; Thu, 9 May 2024 14:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715265430; cv=none; b=mI+FUvErBX4LtzCYuYZYYQNFhWYesuCSqqngu2IYmHpSiBQkW/Y162JiAvlTeCH94AlWmuYK3fnBmZn42H5wx3kN06omUkJS54Z1vYNOa+ZKrKbHqSpmXa6bwQfUBodDpStaF/xm0Faz5k1MG6vDn8QTw2rNWUhsEFMERvtYrZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715265430; c=relaxed/simple; bh=rX2HhaPr9XjslEz/iELt3o8cY4WdThK1YOL4qhZC7cc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QRAGVXflKo23MXxrT4s0g3rvzk1B1ammXFbwKKf24iKk4djWFb6RQ1RkQm/Hx5xZBCJxiWP5FsBA8xm5FjX43UgC0pcHjJO076wXtGmH7j46arixvQsVKe7FK9HFVd4GPvJeE5Hs7BYwmn0zY5m1Cfa93OjR1mfby0lemdt0JOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NTo7eWSD; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NTo7eWSD" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-7d9ef422859so8307239f.0 for ; Thu, 09 May 2024 07:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715265427; x=1715870227; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qhunxhR/OF2icvm3HmEsNbbwCxzb74IsXbKxDT8qkPs=; b=NTo7eWSDMbAgSOT7CINCmQClTKuqqKFXzf8sF9h8V2D/TL6uzIk6kNIRhOOZdzEMTW mJ9+zmh148SCPZPrjx1yCxIGvBo6MHnlbazDh1HqKyqkHbDHYDUog3Z/huvB7M1KruTH G4D/ZyTmCb4BjkMlKuDOLN5gYiVRGa28cjD1M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715265427; x=1715870227; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qhunxhR/OF2icvm3HmEsNbbwCxzb74IsXbKxDT8qkPs=; b=lyAgHBpsowQpbyRnJUCRBdmCLgeVtxp50kjjCV4fqz+DOf1sJtqW9bx+CkmFkcd35E LhSWWYOGow2DOMydn9F8a7PHtUrlSL+OBlst/QlkdFUhKPLAa0u2oKdN8488aWQviVfL N0CEG+ICau77fGEvIOe8zYqIyUIc72Zo3Tr3QDIxOdfzv6DZTFYZvi/Hj0MU21L6vIBX q+K/RMam69NiCEjpt733hn2F83dr68YzV1KzWtjJIFuJxA5+w2HJDmM7TXuohcmdegQd axyIBTQIJCuAvpvupOi+UKFrzu+Y1IibqlTVF/+xCzPetWgtQ27QwJ/9a9GfdXLgmu5Y CXiA== X-Forwarded-Encrypted: i=1; AJvYcCWjWSqUvhdOKBZEeCMGuhE0wZboHazWLgie2S5yD/yQXT0rYrHczV4ZNMHOlUyaX7/4P9U9PN6xjd583sL4kUCbI1oDVT4qOYExQwziLUej X-Gm-Message-State: AOJu0YxWd3Ba3mHfSAUhs4oA3CGmHFIOien/fOtEczfBhaPthnn4jjqX lYI1BdVp+8NPIn2AvUZ89iPZPzkzAYFRhoEnJWd1+EPeqKDtcg/Y+es6GRefN94= X-Google-Smtp-Source: AGHT+IFLPV3hTUAqtiZSXFMZ3nZtJrVA8/PdzJcN3v/yjJF832scb22cGE7mYooNXziODVFLnPMOaA== X-Received: by 2002:a6b:e618:0:b0:7e1:86e1:cd46 with SMTP id ca18e2360f4ac-7e18fd9a35cmr655432839f.2.1715265426750; Thu, 09 May 2024 07:37:06 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4893703c0c8sm386684173.48.2024.05.09.07.37.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 May 2024 07:37:06 -0700 (PDT) Message-ID: <946ae22f-a4af-448a-92e1-60afb6ed9261@linuxfoundation.org> Date: Thu, 9 May 2024 08:37:03 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org, Shuah Khan References: <20240507214254.2787305-1-edliaw@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/9/24 00:13, Edward Liaw wrote: > On Wed, May 8, 2024 at 4:10 PM Shuah Khan wrote: >> >> On 5/7/24 15:38, Edward Liaw wrote: >>> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced >>> asprintf into kselftest_harness.h, which is a GNU extension and needs >>> _GNU_SOURCE to either be defined prior to including headers or with the >>> -D_GNU_SOURCE flag passed to the compiler. >>> >>> v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ >>> v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single >>> location. Remove #define _GNU_SOURCE from source code to resolve >>> redefinition warnings. >>> >>> Edward Liaw (5): >>> selftests: Compile kselftest headers with -D_GNU_SOURCE >>> selftests/sgx: Include KHDR_INCLUDES in Makefile >> >> I appled patches 1/5 and 2.5 - The rest need to be split up. >> >>> selftests: Include KHDR_INCLUDES in Makefile >>> selftests: Drop define _GNU_SOURCE >>> selftests: Drop duplicate -D_GNU_SOURCE >>> >> >> Please split these patches pwe test directory. Otherwise it will >> cause merge conflicts which can be hard to resolve. > > Hi Shuah, > Sean asked that I rebase the patches on linux-next, and I will need to > remove additional _GNU_SOURCE defines. Should I send an unsplit v3 to > be reviewed, then split it afterwards? I'm concerned that it will be > difficult to review with ~70 patches once split. Please send them split - it will be easier to review and apply. You might as well wait until the merge window is done. I don't think anybody would have time to review now since merge window starts next week. thanks, -- Shuah